| Message ID | 20240828-imx290-avail-v2-2-bd320ac8e8fa@skidata.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | media: i2c: imx290: check for availability in probe() | expand |
Hi Benjamin, Thank you for the patch. On Wed, Aug 28, 2024 at 08:13:08PM +0200, Benjamin Bara wrote: > This register is not described in the public available imx290 datasheet. > Additionally, a read returns '0x07d0' for an imx327lqr and also for an > imx462, which means it cannot be used to distinguish between those two > imx290 derivatives. > > Signed-off-by: Benjamin Bara <benjamin.bara@skidata.com> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > introduced in v2 > --- > drivers/media/i2c/imx290.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/media/i2c/imx290.c b/drivers/media/i2c/imx290.c > index 2a869576600c..48502ba19cdc 100644 > --- a/drivers/media/i2c/imx290.c > +++ b/drivers/media/i2c/imx290.c > @@ -80,7 +80,6 @@ > #define IMX290_ADBIT2 CCI_REG8(0x317c) > #define IMX290_ADBIT2_10BIT 0x12 > #define IMX290_ADBIT2_12BIT 0x00 > -#define IMX290_CHIP_ID CCI_REG16_LE(0x319a) > #define IMX290_ADBIT3 CCI_REG8(0x31ec) > #define IMX290_ADBIT3_10BIT 0x37 > #define IMX290_ADBIT3_12BIT 0x0e >
diff --git a/drivers/media/i2c/imx290.c b/drivers/media/i2c/imx290.c index 2a869576600c..48502ba19cdc 100644 --- a/drivers/media/i2c/imx290.c +++ b/drivers/media/i2c/imx290.c @@ -80,7 +80,6 @@ #define IMX290_ADBIT2 CCI_REG8(0x317c) #define IMX290_ADBIT2_10BIT 0x12 #define IMX290_ADBIT2_12BIT 0x00 -#define IMX290_CHIP_ID CCI_REG16_LE(0x319a) #define IMX290_ADBIT3 CCI_REG8(0x31ec) #define IMX290_ADBIT3_10BIT 0x37 #define IMX290_ADBIT3_12BIT 0x0e
This register is not described in the public available imx290 datasheet. Additionally, a read returns '0x07d0' for an imx327lqr and also for an imx462, which means it cannot be used to distinguish between those two imx290 derivatives. Signed-off-by: Benjamin Bara <benjamin.bara@skidata.com> --- introduced in v2 --- drivers/media/i2c/imx290.c | 1 - 1 file changed, 1 deletion(-)