diff mbox series

ASoC: amd: yc: Add a quirk for MSI Bravo 17 (D7VEK)

Message ID 20240829130313.338508-1-markuss.broks@gmail.com (mailing list archive)
State Accepted
Commit 283844c35529300c8e10f7a263e35e3c5d3580ac
Headers show
Series ASoC: amd: yc: Add a quirk for MSI Bravo 17 (D7VEK) | expand

Commit Message

Markuss Broks Aug. 29, 2024, 1:03 p.m. UTC
MSI Bravo 17 (D7VEK), like other laptops from the family,
has broken ACPI tables and needs a quirk for internal mic
to work.

Signed-off-by: Markuss Broks <markuss.broks@gmail.com>
---
 sound/soc/amd/yc/acp6x-mach.c | 7 +++++++
 1 file changed, 7 insertions(+)

Comments

Greg KH Aug. 29, 2024, 1:49 p.m. UTC | #1
On Thu, Aug 29, 2024 at 04:03:05PM +0300, Markuss Broks wrote:
> MSI Bravo 17 (D7VEK), like other laptops from the family,
> has broken ACPI tables and needs a quirk for internal mic
> to work.
> 
> Signed-off-by: Markuss Broks <markuss.broks@gmail.com>
> ---
>  sound/soc/amd/yc/acp6x-mach.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/sound/soc/amd/yc/acp6x-mach.c b/sound/soc/amd/yc/acp6x-mach.c
> index 0523c16305db..843abc378b28 100644
> --- a/sound/soc/amd/yc/acp6x-mach.c
> +++ b/sound/soc/amd/yc/acp6x-mach.c
> @@ -353,6 +353,13 @@ static const struct dmi_system_id yc_acp_quirk_table[] = {
>  			DMI_MATCH(DMI_PRODUCT_NAME, "Bravo 15 C7VF"),
>  		}
>  	},
> +	{
> +		.driver_data = &acp6x_card,
> +		.matches = {
> +			DMI_MATCH(DMI_BOARD_VENDOR, "Micro-Star International Co., Ltd."),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "Bravo 17 D7VEK"),
> +		}
> +	},
>  	{
>  		.driver_data = &acp6x_card,
>  		.matches = {
> -- 
> 2.46.0
> 
> 

<formletter>

This is not the correct way to submit patches for inclusion in the
stable kernel tree.  Please read:
    https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.

</formletter>
Markuss Broks Aug. 29, 2024, 2:36 p.m. UTC | #2
Hi,

Sorry, misread it, so I need to include it in the mail body? Do I resend 
this patch with that change?

On 8/29/24 4:49 PM, Greg KH wrote:
> On Thu, Aug 29, 2024 at 04:03:05PM +0300, Markuss Broks wrote:
>> MSI Bravo 17 (D7VEK), like other laptops from the family,
>> has broken ACPI tables and needs a quirk for internal mic
>> to work.
>>
>> Signed-off-by: Markuss Broks <markuss.broks@gmail.com>
>> ---
>>   sound/soc/amd/yc/acp6x-mach.c | 7 +++++++
>>   1 file changed, 7 insertions(+)
>>
>> diff --git a/sound/soc/amd/yc/acp6x-mach.c b/sound/soc/amd/yc/acp6x-mach.c
>> index 0523c16305db..843abc378b28 100644
>> --- a/sound/soc/amd/yc/acp6x-mach.c
>> +++ b/sound/soc/amd/yc/acp6x-mach.c
>> @@ -353,6 +353,13 @@ static const struct dmi_system_id yc_acp_quirk_table[] = {
>>   			DMI_MATCH(DMI_PRODUCT_NAME, "Bravo 15 C7VF"),
>>   		}
>>   	},
>> +	{
>> +		.driver_data = &acp6x_card,
>> +		.matches = {
>> +			DMI_MATCH(DMI_BOARD_VENDOR, "Micro-Star International Co., Ltd."),
>> +			DMI_MATCH(DMI_PRODUCT_NAME, "Bravo 17 D7VEK"),
>> +		}
>> +	},
>>   	{
>>   		.driver_data = &acp6x_card,
>>   		.matches = {
>> -- 
>> 2.46.0
>>
>>
> <formletter>
>
> This is not the correct way to submit patches for inclusion in the
> stable kernel tree.  Please read:
>      https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
> for how to do this properly.
>
> </formletter>

- Markuss
Mark Brown Aug. 29, 2024, 2:40 p.m. UTC | #3
On Thu, Aug 29, 2024 at 05:36:06PM +0300, Markuss Broks wrote:

> Sorry, misread it, so I need to include it in the mail body? Do I resend
> this patch with that change?

No.

Please don't top post, reply in line with needed context.  This allows
readers to readily follow the flow of conversation and understand what
you are talking about and also helps ensure that everything in the
discussion is being addressed.
Mark Brown Aug. 29, 2024, 2:56 p.m. UTC | #4
On Thu, 29 Aug 2024 16:03:05 +0300, Markuss Broks wrote:
> MSI Bravo 17 (D7VEK), like other laptops from the family,
> has broken ACPI tables and needs a quirk for internal mic
> to work.
> 
> 

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: amd: yc: Add a quirk for MSI Bravo 17 (D7VEK)
      commit: 283844c35529300c8e10f7a263e35e3c5d3580ac

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark
diff mbox series

Patch

diff --git a/sound/soc/amd/yc/acp6x-mach.c b/sound/soc/amd/yc/acp6x-mach.c
index 0523c16305db..843abc378b28 100644
--- a/sound/soc/amd/yc/acp6x-mach.c
+++ b/sound/soc/amd/yc/acp6x-mach.c
@@ -353,6 +353,13 @@  static const struct dmi_system_id yc_acp_quirk_table[] = {
 			DMI_MATCH(DMI_PRODUCT_NAME, "Bravo 15 C7VF"),
 		}
 	},
+	{
+		.driver_data = &acp6x_card,
+		.matches = {
+			DMI_MATCH(DMI_BOARD_VENDOR, "Micro-Star International Co., Ltd."),
+			DMI_MATCH(DMI_PRODUCT_NAME, "Bravo 17 D7VEK"),
+		}
+	},
 	{
 		.driver_data = &acp6x_card,
 		.matches = {