| Message ID | 87y14h1b9f.wl-kuninori.morimoto.gx@renesas.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | of: property: add of_graph_get_next_port/port_endpoint() | expand |
On Wed, Aug 28, 2024 at 05:12:28AM +0000, Kuninori Morimoto wrote: > Now we can use new port related functions for port parsing. Use it. > > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> > Reviewed-by: Tomi Valkeinen <tomi.valkeinen+renesas@ideasonboard.com> > --- > drivers/media/platform/xilinx/xilinx-tpg.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/media/platform/xilinx/xilinx-tpg.c b/drivers/media/platform/xilinx/xilinx-tpg.c > index e05e528ffc6f7..a25f216b2513c 100644 > --- a/drivers/media/platform/xilinx/xilinx-tpg.c > +++ b/drivers/media/platform/xilinx/xilinx-tpg.c > @@ -13,6 +13,7 @@ > #include <linux/gpio/consumer.h> > #include <linux/module.h> > #include <linux/of.h> > +#include <linux/of_graph.h> > #include <linux/platform_device.h> > #include <linux/xilinx-v4l2-controls.h> > > @@ -744,7 +745,7 @@ static int xtpg_parse_of(struct xtpg_device *xtpg) > } > This function is looping over port nodes, why don't you make it use for_each_of_graph_port()? > if (nports == 0) { > - endpoint = of_get_next_child(port, NULL); > + endpoint = of_graph_get_next_port_endpoint(port, NULL); > if (endpoint) > has_endpoint = true; > of_node_put(endpoint); > -- > 2.43.0 >
Hi Rob Thank you for your review > > index e05e528ffc6f7..a25f216b2513c 100644 > > --- a/drivers/media/platform/xilinx/xilinx-tpg.c > > +++ b/drivers/media/platform/xilinx/xilinx-tpg.c > > @@ -13,6 +13,7 @@ > > #include <linux/gpio/consumer.h> > > #include <linux/module.h> > > #include <linux/of.h> > > +#include <linux/of_graph.h> > > #include <linux/platform_device.h> > > #include <linux/xilinx-v4l2-controls.h> > > > > @@ -744,7 +745,7 @@ static int xtpg_parse_of(struct xtpg_device *xtpg) > > } > > > > This function is looping over port nodes, why don't you make it use > for_each_of_graph_port()? Yes, indeed. Will fix in v5 Thank you for your help !! Best regards --- Kuninori Morimoto
diff --git a/drivers/media/platform/xilinx/xilinx-tpg.c b/drivers/media/platform/xilinx/xilinx-tpg.c index e05e528ffc6f7..a25f216b2513c 100644 --- a/drivers/media/platform/xilinx/xilinx-tpg.c +++ b/drivers/media/platform/xilinx/xilinx-tpg.c @@ -13,6 +13,7 @@ #include <linux/gpio/consumer.h> #include <linux/module.h> #include <linux/of.h> +#include <linux/of_graph.h> #include <linux/platform_device.h> #include <linux/xilinx-v4l2-controls.h> @@ -744,7 +745,7 @@ static int xtpg_parse_of(struct xtpg_device *xtpg) } if (nports == 0) { - endpoint = of_get_next_child(port, NULL); + endpoint = of_graph_get_next_port_endpoint(port, NULL); if (endpoint) has_endpoint = true; of_node_put(endpoint);