| Message ID | 20240829113158.3324928-1-festevam@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | ac7ee784fd00e90542411f113650222c82f86bfd |
| Headers | show |
| Series | [v4,1/3] dt-bindings: trivial-devices: Document elgin,jg10309-01 | expand |
On Thu, 29 Aug 2024 08:31:56 -0300, Fabio Estevam wrote: > The rv1108-elgin-r1 board has an LCD controlled via SPI in userspace. > The marking on the LCD is JG10309-01. > > Add an entry for the "elgin,jg10309-01" compatible string. > > Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next Thanks! [1/3] dt-bindings: trivial-devices: Document elgin,jg10309-01 (no commit info) [2/3] spi: spidev: Add an entry for elgin,jg10309-01 commit: 5f3eee1eef5d0edd23d8ac0974f56283649a1512 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
On Thu, 29 Aug 2024 08:31:56 -0300, Fabio Estevam wrote: > The rv1108-elgin-r1 board has an LCD controlled via SPI in userspace. > The marking on the LCD is JG10309-01. > > Add an entry for the "elgin,jg10309-01" compatible string. > > Applied, thanks! [3/3] ARM: dts: rockchip: rv1108-elgin-r1: Do not describe unexisting DAC device commit: 0296f20c72d23f41ca0ccd64eb849e9ef1aa8977 Best regards,
On Thu, 29 Aug 2024 08:31:56 -0300, Fabio Estevam wrote: > The rv1108-elgin-r1 board has an LCD controlled via SPI in userspace. > The marking on the LCD is JG10309-01. > > Add an entry for the "elgin,jg10309-01" compatible string. > > Signed-off-by: Fabio Estevam <festevam@gmail.com> > Acked-by: Conor Dooley <conor.dooley@microchip.com> > Acked-by: Heiko Stuebner <heiko@sntech.de> > --- > Changes since v3: > - Fix the series numbering version. > > Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++ > 1 file changed, 2 insertions(+) > My bot found new DTB warnings on the .dts files added or changed in this series. Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings are fixed by another series. Ultimately, it is up to the platform maintainer whether these warnings are acceptable or not. No need to reply unless the platform maintainer has comments. If you already ran DT checks and didn't see these error(s), then make sure dt-schema is up to date: pip3 install dtschema --upgrade New warnings running 'make CHECK_DTBS=y rockchip/rv1108-elgin-r1.dtb' for 20240829113158.3324928-1-festevam@gmail.com: arch/arm/boot/dts/rockchip/rv1108-elgin-r1.dtb: display@0: 'spi-cpha', 'spi-cpol' do not match any of the regexes: 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/trivial-devices.yaml#
On Thu, Aug 29, 2024 at 1:41 PM Rob Herring (Arm) <robh@kernel.org> wrote: > > > On Thu, 29 Aug 2024 08:31:56 -0300, Fabio Estevam wrote: > > The rv1108-elgin-r1 board has an LCD controlled via SPI in userspace. > > The marking on the LCD is JG10309-01. > > > > Add an entry for the "elgin,jg10309-01" compatible string. > > > > Signed-off-by: Fabio Estevam <festevam@gmail.com> > > Acked-by: Conor Dooley <conor.dooley@microchip.com> > > Acked-by: Heiko Stuebner <heiko@sntech.de> > > --- > > Changes since v3: > > - Fix the series numbering version. > > > > Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++ > > 1 file changed, 2 insertions(+) > > > > > My bot found new DTB warnings on the .dts files added or changed in this > series. > > Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings > are fixed by another series. Ultimately, it is up to the platform > maintainer whether these warnings are acceptable or not. No need to reply > unless the platform maintainer has comments. > > If you already ran DT checks and didn't see these error(s), then > make sure dt-schema is up to date: > > pip3 install dtschema --upgrade > > > New warnings running 'make CHECK_DTBS=y rockchip/rv1108-elgin-r1.dtb' for 20240829113158.3324928-1-festevam@gmail.com: > > arch/arm/boot/dts/rockchip/rv1108-elgin-r1.dtb: display@0: 'spi-cpha', 'spi-cpol' do not match any of the regexes: 'pinctrl-[0-9]+' > from schema $id: http://devicetree.org/schemas/trivial-devices.yaml# I'd be okay if trivial-devices.yaml references spi-peripheral-props.yaml. Rob
Hi Rob, On Thu, Aug 29, 2024 at 3:43 PM Rob Herring <robh@kernel.org> wrote: > > New warnings running 'make CHECK_DTBS=y rockchip/rv1108-elgin-r1.dtb' for 20240829113158.3324928-1-festevam@gmail.com: > > > > arch/arm/boot/dts/rockchip/rv1108-elgin-r1.dtb: display@0: 'spi-cpha', 'spi-cpol' do not match any of the regexes: 'pinctrl-[0-9]+' > > from schema $id: http://devicetree.org/schemas/trivial-devices.yaml# > > I'd be okay if trivial-devices.yaml references spi-peripheral-props.yaml. This is what I tried: --- a/Documentation/devicetree/bindings/trivial-devices.yaml +++ b/Documentation/devicetree/bindings/trivial-devices.yaml @@ -424,6 +424,9 @@ required: - compatible - reg -additionalProperties: false +allOf: + - $ref: /schemas/spi/spi-peripheral-props.yaml# + +unevaluatedProperties: false but still get: $ make CHECK_DTBS=y rockchip/rv1108-elgin-r1.dtb SCHEMA Documentation/devicetree/bindings/processed-schema.json DTC [C] arch/arm/boot/dts/rockchip/rv1108-elgin-r1.dtb /home/fabio/linux-next/arch/arm/boot/dts/rockchip/rv1108-elgin-r1.dtb: display@0: Unevaluated properties are not allowed ('spi-cpha', 'spi-cpol' were unexpected) from schema $id: http://devicetree.org/schemas/trivial-devices.yaml# Any suggestions?
On Thu, Aug 29, 2024 at 4:07 PM Fabio Estevam <festevam@gmail.com> wrote: > $ make CHECK_DTBS=y rockchip/rv1108-elgin-r1.dtb > SCHEMA Documentation/devicetree/bindings/processed-schema.json > DTC [C] arch/arm/boot/dts/rockchip/rv1108-elgin-r1.dtb > /home/fabio/linux-next/arch/arm/boot/dts/rockchip/rv1108-elgin-r1.dtb: > display@0: Unevaluated properties are not allowed ('spi-cpha', > 'spi-cpol' were unexpected) > from schema $id: http://devicetree.org/schemas/trivial-devices.yaml# > > Any suggestions? 'spi-cpha' and 'spi-cpol' are not documented in spi-peripheral-props.yaml. I can send a patch adding them to spi-peripheral-props.yaml.
diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml index 7913ca9b6b54..49dee2a1f6b4 100644 --- a/Documentation/devicetree/bindings/trivial-devices.yaml +++ b/Documentation/devicetree/bindings/trivial-devices.yaml @@ -110,6 +110,8 @@ properties: - domintech,dmard09 # DMARD10: 3-axis Accelerometer - domintech,dmard10 + # Elgin SPI-controlled LCD + - elgin,jg10309-01 # MMA7660FC: 3-Axis Orientation/Motion Detection Sensor - fsl,mma7660 # MMA8450Q: Xtrinsic Low-power, 3-axis Xtrinsic Accelerometer