diff mbox series

[net-next,1/6] net: ag71xx: add COMPILE_TEST to test compilation

Message ID 20240829214838.2235031-2-rosenp@gmail.com (mailing list archive)
State Superseded
Delegated to: Netdev Maintainers
Headers show
Series various cleanups | expand

Checks

Context Check Description
netdev/series_format success Posting correctly formatted
netdev/tree_selection success Clearly marked for net-next
netdev/ynl success Generated files up to date; no warnings/errors; no diff in generated;
netdev/fixes_present success Fixes tag not required for -next series
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit fail Errors and warnings before: 16 this patch: 17
netdev/build_tools success No tools touched, skip
netdev/cc_maintainers warning 1 maintainers not CCed: chris.snook@gmail.com
netdev/build_clang fail Errors and warnings before: 17 this patch: 18
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/deprecated_api success None detected
netdev/check_selftest success No net selftest shell script
netdev/verify_fixes success No Fixes tag
netdev/build_allmodconfig_warn fail Errors and warnings before: 22 this patch: 23
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 16 lines checked
netdev/build_clang_rust success No Rust files in patch. Skipping build
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0

Commit Message

Rosen Penev Aug. 29, 2024, 9:48 p.m. UTC 
While this driver is meant for MIPS only, it can be compiled on x86 just
fine. Remove pointless parentheses while at it.

Enables CI building of this driver.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
 drivers/net/ethernet/atheros/Kconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Simon Horman Aug. 30, 2024, 3:49 p.m. UTC | #1 
On Thu, Aug 29, 2024 at 02:48:20PM -0700, Rosen Penev wrote:
> While this driver is meant for MIPS only, it can be compiled on x86 just
> fine. Remove pointless parentheses while at it.
> 
> Enables CI building of this driver.
> 
> Signed-off-by: Rosen Penev <rosenp@gmail.com>

Thanks, this seems to work well.

Reviewed-by: Simon Horman <horms@kernel.org>

As a follow-up, could you consider adding a MODULE_DESCRIPTION()
to this module. It now gets flagged on x86_64 allmodconfig W=1 builds.

...
Rosen Penev Aug. 30, 2024, 5:32 p.m. UTC | #2 
On Fri, Aug 30, 2024 at 8:49 AM Simon Horman <horms@kernel.org> wrote:
>
> On Thu, Aug 29, 2024 at 02:48:20PM -0700, Rosen Penev wrote:
> > While this driver is meant for MIPS only, it can be compiled on x86 just
> > fine. Remove pointless parentheses while at it.
> >
> > Enables CI building of this driver.
> >
> > Signed-off-by: Rosen Penev <rosenp@gmail.com>
>
> Thanks, this seems to work well.
>
> Reviewed-by: Simon Horman <horms@kernel.org>
>
> As a follow-up, could you consider adding a MODULE_DESCRIPTION()
> to this module. It now gets flagged on x86_64 allmodconfig W=1 builds.
v2 patchset?
>
> ...
Simon Horman Aug. 30, 2024, 6:14 p.m. UTC | #3 
On Fri, Aug 30, 2024 at 10:32:08AM -0700, Rosen Penev wrote:
> On Fri, Aug 30, 2024 at 8:49 AM Simon Horman <horms@kernel.org> wrote:
> >
> > On Thu, Aug 29, 2024 at 02:48:20PM -0700, Rosen Penev wrote:
> > > While this driver is meant for MIPS only, it can be compiled on x86 just
> > > fine. Remove pointless parentheses while at it.
> > >
> > > Enables CI building of this driver.
> > >
> > > Signed-off-by: Rosen Penev <rosenp@gmail.com>
> >
> > Thanks, this seems to work well.
> >
> > Reviewed-by: Simon Horman <horms@kernel.org>
> >
> > As a follow-up, could you consider adding a MODULE_DESCRIPTION()
> > to this module. It now gets flagged on x86_64 allmodconfig W=1 builds.
> v2 patchset?

I'd wait to see if this patchset is accepted.
And if so, send a new patch separately.
If not, perhaps add it to v2.
diff mbox series

Patch

diff --git a/drivers/net/ethernet/atheros/Kconfig b/drivers/net/ethernet/atheros/Kconfig
index 482c58c4c584..03b31bedc9a5 100644
--- a/drivers/net/ethernet/atheros/Kconfig
+++ b/drivers/net/ethernet/atheros/Kconfig
@@ -6,7 +6,7 @@ 
 config NET_VENDOR_ATHEROS
 	bool "Atheros devices"
 	default y
-	depends on (PCI || ATH79)
+	depends on PCI || ATH79 || COMPILE_TEST
 	help
 	  If you have a network (Ethernet) card belonging to this class, say Y.
 
@@ -19,7 +19,7 @@  if NET_VENDOR_ATHEROS
 
 config AG71XX
 	tristate "Atheros AR7XXX/AR9XXX built-in ethernet mac support"
-	depends on ATH79
+	depends on ATH79 || COMPILE_TEST
 	select PHYLINK
 	imply NET_SELFTESTS
 	help