diff mbox series

KVM: selftests: Explicitly include committed one-off assets in .gitignore

Message ID 20240828215800.737042-1-seanjc@google.com (mailing list archive)
State New, archived
Headers show
Series KVM: selftests: Explicitly include committed one-off assets in .gitignore | expand

Commit Message

Sean Christopherson Aug. 28, 2024, 9:58 p.m. UTC 
Add KVM selftests' one-off assets, e.g. the Makefile, to the .gitignore so
that they are explicitly included.  The justification for omitting the
one-offs was that including them wouldn't help prevent mistakes:

  Deliberately do not include the one-off assets, e.g. config, settings,
  .gitignore itself, etc as Git doesn't ignore files that are already in
  the repository.  Adding the one-off assets won't prevent mistakes where
  developers forget to --force add files that don't match the "allowed".

Turns out that's not the case, as W=1 will generate warnings, and the
amazing-as-always kernel test bot reports new warnings:

   tools/testing/selftests/kvm/.gitignore: warning: ignored by one of the .gitignore files
   tools/testing/selftests/kvm/Makefile: warning: ignored by one of the .gitignore files
>> tools/testing/selftests/kvm/Makefile.kvm: warning: ignored by one of the .gitignore files
   tools/testing/selftests/kvm/config: warning: ignored by one of the .gitignore files
   tools/testing/selftests/kvm/settings: warning: ignored by one of the .gitignore files

Fixes: 43e96957e8b8 ("KVM: selftests: Use pattern matching in .gitignore")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202408211818.85zIkDEK-lkp@intel.com
Signed-off-by: Sean Christopherson <seanjc@google.com>
---
 tools/testing/selftests/kvm/.gitignore | 4 ++++
 1 file changed, 4 insertions(+)


base-commit: 15e1c3d65975524c5c792fcd59f7d89f00402261

Comments

Sean Christopherson Aug. 31, 2024, 12:21 a.m. UTC | #1 
On Wed, 28 Aug 2024 14:58:00 -0700, Sean Christopherson wrote:
> Add KVM selftests' one-off assets, e.g. the Makefile, to the .gitignore so
> that they are explicitly included.  The justification for omitting the
> one-offs was that including them wouldn't help prevent mistakes:
> 
>   Deliberately do not include the one-off assets, e.g. config, settings,
>   .gitignore itself, etc as Git doesn't ignore files that are already in
>   the repository.  Adding the one-off assets won't prevent mistakes where
>   developers forget to --force add files that don't match the "allowed".
> 
> [...]

Applied to kvm-x86 selftests, thanks!

[1/1] KVM: selftests: Explicitly include committed one-off assets in .gitignore
      https://github.com/kvm-x86/linux/commit/9d15171f39f0

--
https://github.com/kvm-x86/linux/tree/next
diff mbox series

Patch

diff --git a/tools/testing/selftests/kvm/.gitignore b/tools/testing/selftests/kvm/.gitignore
index 6d9381d60172..7f57abf936e7 100644
--- a/tools/testing/selftests/kvm/.gitignore
+++ b/tools/testing/selftests/kvm/.gitignore
@@ -5,3 +5,7 @@ 
 !*.h
 !*.S
 !*.sh
+!.gitignore
+!config
+!settings
+!Makefile