| Message ID | 20240826191728.1415189-1-robh@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | iio: adc: mcp320x: Drop vendorless compatible strings | expand |
On Mon, 26 Aug 2024 14:17:28 -0500 "Rob Herring (Arm)" <robh@kernel.org> wrote: > The vendorless compatible strings are deprecated and weren't retained > when the binding was converted to schema. As a result, they are listed > as undocumented when running "make dt_compatible_check". Rather than add > them back to the schema, let's just drop them as they are unnecessary. > Furthermore, they are unnecessary as the SPI matching will strip the > vendor prefix on compatible string and match that against the > spi_device_id table. > > Signed-off-by: Rob Herring (Arm) <robh@kernel.org> Applied. Thanks, > --- > drivers/iio/adc/mcp320x.c | 10 ---------- > 1 file changed, 10 deletions(-) > > diff --git a/drivers/iio/adc/mcp320x.c b/drivers/iio/adc/mcp320x.c > index da1421bd7b62..57cff3772ebe 100644 > --- a/drivers/iio/adc/mcp320x.c > +++ b/drivers/iio/adc/mcp320x.c > @@ -459,16 +459,6 @@ static int mcp320x_probe(struct spi_device *spi) > } > > static const struct of_device_id mcp320x_dt_ids[] = { > - /* NOTE: The use of compatibles with no vendor prefix is deprecated. */ > - { .compatible = "mcp3001" }, > - { .compatible = "mcp3002" }, > - { .compatible = "mcp3004" }, > - { .compatible = "mcp3008" }, > - { .compatible = "mcp3201" }, > - { .compatible = "mcp3202" }, > - { .compatible = "mcp3204" }, > - { .compatible = "mcp3208" }, > - { .compatible = "mcp3301" }, > { .compatible = "microchip,mcp3001" }, > { .compatible = "microchip,mcp3002" }, > { .compatible = "microchip,mcp3004" },
diff --git a/drivers/iio/adc/mcp320x.c b/drivers/iio/adc/mcp320x.c index da1421bd7b62..57cff3772ebe 100644 --- a/drivers/iio/adc/mcp320x.c +++ b/drivers/iio/adc/mcp320x.c @@ -459,16 +459,6 @@ static int mcp320x_probe(struct spi_device *spi) } static const struct of_device_id mcp320x_dt_ids[] = { - /* NOTE: The use of compatibles with no vendor prefix is deprecated. */ - { .compatible = "mcp3001" }, - { .compatible = "mcp3002" }, - { .compatible = "mcp3004" }, - { .compatible = "mcp3008" }, - { .compatible = "mcp3201" }, - { .compatible = "mcp3202" }, - { .compatible = "mcp3204" }, - { .compatible = "mcp3208" }, - { .compatible = "mcp3301" }, { .compatible = "microchip,mcp3001" }, { .compatible = "microchip,mcp3002" }, { .compatible = "microchip,mcp3004" },
The vendorless compatible strings are deprecated and weren't retained when the binding was converted to schema. As a result, they are listed as undocumented when running "make dt_compatible_check". Rather than add them back to the schema, let's just drop them as they are unnecessary. Furthermore, they are unnecessary as the SPI matching will strip the vendor prefix on compatible string and match that against the spi_device_id table. Signed-off-by: Rob Herring (Arm) <robh@kernel.org> --- drivers/iio/adc/mcp320x.c | 10 ---------- 1 file changed, 10 deletions(-)