| Message ID | 20240831110743.14280-3-tarang.raval@siliconsignals.io (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Add support for Variscite Symphony board and VAR-SOM-MX8MP SoM | expand |
On 31/08/2024 13:07, Tarang Raval wrote: > Adds support for the Variscite VAR-SOM-MX8MP System on Module and > the Variscite Symphony Evaluation Kit. > > Signed-off-by: Tarang Raval <tarang.raval@siliconsignals.io> > --- > Documentation/devicetree/bindings/arm/fsl.yaml | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml > index 6d185d09cb6a..db835947f5ed 100644 > --- a/Documentation/devicetree/bindings/arm/fsl.yaml > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml > @@ -1071,6 +1071,7 @@ properties: > - toradex,verdin-imx8mp # Verdin iMX8M Plus Modules > - toradex,verdin-imx8mp-nonwifi # Verdin iMX8M Plus Modules without Wi-Fi / BT > - toradex,verdin-imx8mp-wifi # Verdin iMX8M Plus Wi-Fi / BT Modules > + - variscite,var-som-mx8mp # i.MX8MP Variscite VAR-SOM-MX8M Plus module That's not correct. You cannot use this SoM alone. > - const: fsl,imx8mp Best regards, Krzysztof
Hi , >> - toradex,verdin-imx8mp-wifi # Verdin iMX8M Plus Wi-Fi / BT Modules >> + - variscite,var-som-mx8mp # i.MX8MP Variscite VAR-SOM-MX8M Plus module > >That's not correct. You cannot use this SoM alone. I took the reference from var-som-imx8mm, where they use "variscite,var-som-mx8mm" in a similar manner. However, if you still believe it's incorrect, I will change it. One more thing: should I change "VAR-SOM-MX8M Plus" to "VAR-SOM-MX8MP" in the DTSI model name and in the YAML file as well, or keep it as it is? Best regards, Tarang
On 31/08/2024 15:51, Tarang Raval wrote: > Hi , > >>> - toradex,verdin-imx8mp-wifi # Verdin iMX8M Plus Wi-Fi / BT Modules >>> + - variscite,var-som-mx8mp # i.MX8MP Variscite VAR-SOM-MX8M Plus module >> >> That's not correct. You cannot use this SoM alone. > > I took the reference from var-som-imx8mm, where they use "variscite,var-som-mx8mm" in a similar manner. However, if you still believe it's incorrect, I will change it. I posted that patch, but I don't think it was correct. > > One more thing: should I change "VAR-SOM-MX8M Plus" to "VAR-SOM-MX8MP" in the DTSI model name and in the YAML file as well, or keep it as it is? No clue, these comments are basically repeating compatible name so not much helpful anyway. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml index 6d185d09cb6a..db835947f5ed 100644 --- a/Documentation/devicetree/bindings/arm/fsl.yaml +++ b/Documentation/devicetree/bindings/arm/fsl.yaml @@ -1071,6 +1071,7 @@ properties: - toradex,verdin-imx8mp # Verdin iMX8M Plus Modules - toradex,verdin-imx8mp-nonwifi # Verdin iMX8M Plus Modules without Wi-Fi / BT - toradex,verdin-imx8mp-wifi # Verdin iMX8M Plus Wi-Fi / BT Modules + - variscite,var-som-mx8mp # i.MX8MP Variscite VAR-SOM-MX8M Plus module - const: fsl,imx8mp - description: Avnet (MSC Branded) Boards with SM2S i.MX8M Plus Modules @@ -1149,6 +1150,12 @@ properties: - const: tq,imx8mp-tqma8mpql # TQ-Systems GmbH i.MX8MP TQMa8MPQL SOM - const: fsl,imx8mp + - description: Variscite VAR-SOM-MX8M Plus based boards + items: + - const: variscite,var-som-mx8mp-symphony + - const: variscite,var-som-mx8mp + - const: fsl,imx8mp + - description: i.MX8MQ based Boards items: - enum:
Adds support for the Variscite VAR-SOM-MX8MP System on Module and the Variscite Symphony Evaluation Kit. Signed-off-by: Tarang Raval <tarang.raval@siliconsignals.io> --- Documentation/devicetree/bindings/arm/fsl.yaml | 7 +++++++ 1 file changed, 7 insertions(+)