diff mbox series

[v2] media: atomisp: Remove unused declartion

Message ID 20240830030035.15686-1-zhangzekun11@huawei.com (mailing list archive)
State New
Headers show
Series [v2] media: atomisp: Remove unused declartion | expand

Commit Message

zhangzekun (A) Aug. 30, 2024, 3 a.m. UTC
v4l2_get_acpi_sensor_info() has been removed since commit d80be6a10cd3
("media: atomisp: Drop v4l2_get_acpi_sensor_info() function"), remain
the declaration untouched in the header file. So, let's remove this
unused declartion.

Signed-off-by: Zhang Zekun <zhangzekun11@huawei.com>
---
v2: Improve commit message

 drivers/staging/media/atomisp/include/linux/atomisp_platform.h | 2 --
 1 file changed, 2 deletions(-)

Comments

Changhuang Liang Aug. 30, 2024, 11:28 a.m. UTC | #1
Hi, Zekun

> v4l2_get_acpi_sensor_info() has been removed since commit d80be6a10cd3
> ("media: atomisp: Drop v4l2_get_acpi_sensor_info() function"), remain the
> declaration untouched in the header file. So, let's remove this unused
> declartion.
> 

Reviewed-by: Changhuang Liang <changhuang.liang@starfivetech.com>

> Signed-off-by: Zhang Zekun <zhangzekun11@huawei.com>
> ---
> v2: Improve commit message
>
Hans de Goede Sept. 2, 2024, 10:33 a.m. UTC | #2
Hi,

On 8/30/24 5:00 AM, Zhang Zekun wrote:
> v4l2_get_acpi_sensor_info() has been removed since commit d80be6a10cd3
> ("media: atomisp: Drop v4l2_get_acpi_sensor_info() function"), remain
> the declaration untouched in the header file. So, let's remove this
> unused declartion.
> 
> Signed-off-by: Zhang Zekun <zhangzekun11@huawei.com>
> Reviewed-by: Changhuang Liang <changhuang.liang@starfivetech.com>

Thank you for your patch(es).

I have merged this/these in my media-atomisp branch:
https://git.kernel.org/pub/scm/linux/kernel/git/hansg/linux.git/log/?h=media-atomisp

And this/these will be included in my next pull-request to
Mauro (to media subsystem maintainer)

Regards,

Hans




> ---
> v2: Improve commit message
> 
>  drivers/staging/media/atomisp/include/linux/atomisp_platform.h | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/staging/media/atomisp/include/linux/atomisp_platform.h b/drivers/staging/media/atomisp/include/linux/atomisp_platform.h
> index fdeb247036b0..ca31eea41f39 100644
> --- a/drivers/staging/media/atomisp/include/linux/atomisp_platform.h
> +++ b/drivers/staging/media/atomisp/include/linux/atomisp_platform.h
> @@ -175,8 +175,6 @@ int atomisp_register_sensor_no_gmin(struct v4l2_subdev *subdev, u32 lanes,
>  				    enum atomisp_bayer_order bayer_order);
>  void atomisp_unregister_subdev(struct v4l2_subdev *subdev);
>  
> -int v4l2_get_acpi_sensor_info(struct device *dev, char **module_id_str);
> -
>  /* API from old platform_camera.h, new CPUID implementation */
>  #define __IS_SOC(x) (boot_cpu_data.x86_vfm == x)
>  #define __IS_SOCS(x, y) (boot_cpu_data.x86_vfm == x || boot_cpu_data.x86_vfm == y)
diff mbox series

Patch

diff --git a/drivers/staging/media/atomisp/include/linux/atomisp_platform.h b/drivers/staging/media/atomisp/include/linux/atomisp_platform.h
index fdeb247036b0..ca31eea41f39 100644
--- a/drivers/staging/media/atomisp/include/linux/atomisp_platform.h
+++ b/drivers/staging/media/atomisp/include/linux/atomisp_platform.h
@@ -175,8 +175,6 @@  int atomisp_register_sensor_no_gmin(struct v4l2_subdev *subdev, u32 lanes,
 				    enum atomisp_bayer_order bayer_order);
 void atomisp_unregister_subdev(struct v4l2_subdev *subdev);
 
-int v4l2_get_acpi_sensor_info(struct device *dev, char **module_id_str);
-
 /* API from old platform_camera.h, new CPUID implementation */
 #define __IS_SOC(x) (boot_cpu_data.x86_vfm == x)
 #define __IS_SOCS(x, y) (boot_cpu_data.x86_vfm == x || boot_cpu_data.x86_vfm == y)