[-next,00/15] sysctl: move sysctls from vm_table into its own files

Message

yukaixiong Aug. 26, 2024, 12:04 p.m. UTC

This patch series moves sysctls of vm_table in kernel/sysctl.c to
places where they actually belong, and do some related code clean-ups.
After this patch series, all sysctls in vm_table have been moved into its
own files, meanwhile, delete vm_table.

All the modifications of this patch series base on
linux-next(tags/next-20240823). To test this patch series, the code was
compiled with both the CONFIG_SYSCTL enabled and disabled on arm64 and
x86_64 architectures. After this patch series is applied, all files
under /proc/sys/vm can be read or written normally.

Kaixiong Yu (15):
  mm: vmstat: move sysctls to its own files
  mm: filemap: move sysctl to its own file
  mm: swap: move sysctl to its own file
  mm: vmscan: move vmscan sysctls to its own file
  mm: util: move sysctls into it own files
  mm: mmap: move sysctl into its own file
  security: min_addr: move sysctl into its own file
  mm: nommu: move sysctl to its own file
  fs: fs-writeback: move sysctl to its own file
  fs: drop_caches: move sysctl to its own file
  sunrpc: use vfs_pressure_ratio() helper
  fs: dcache: move the sysctl into its own file
  x86: vdso: move the sysctl into its own file
  sh: vdso: move the sysctl into its own file
  sysctl: remove unneeded include

 arch/sh/kernel/vsyscall/vsyscall.c |  14 ++
 arch/x86/entry/vdso/vdso32-setup.c |  16 ++-
 fs/dcache.c                        |  21 ++-
 fs/drop_caches.c                   |  23 ++-
 fs/fs-writeback.c                  |  28 ++--
 include/linux/dcache.h             |   7 +-
 include/linux/mm.h                 |  42 ------
 include/linux/mman.h               |   2 -
 include/linux/swap.h               |   9 --
 include/linux/vmstat.h             |  11 --
 include/linux/writeback.h          |   4 -
 kernel/sysctl.c                    | 221 -----------------------------
 mm/filemap.c                       |  18 ++-
 mm/internal.h                      |  10 ++
 mm/mmap.c                          |  75 ++++++++++
 mm/nommu.c                         |  15 +-
 mm/swap.c                          |  16 ++-
 mm/swap.h                          |   1 +
 mm/util.c                          |  68 +++++++--
 mm/vmscan.c                        |  23 +++
 mm/vmstat.c                        |  42 +++++-
 net/sunrpc/auth.c                  |   2 +-
 security/min_addr.c                |  11 ++
 23 files changed, 349 insertions(+), 330 deletions(-)

Comments

Kees Cook Aug. 26, 2024, 7:57 p.m. UTC | #1

On Mon, Aug 26, 2024 at 08:04:34PM +0800, Kaixiong Yu wrote:
> This patch series moves sysctls of vm_table in kernel/sysctl.c to
> places where they actually belong, and do some related code clean-ups.
> After this patch series, all sysctls in vm_table have been moved into its
> own files, meanwhile, delete vm_table.

This is really nice! Thanks for doing this migration. I sent a note
about the "fs: dcache: ..." patch that I don't think will be a problem.

Reviewed-by: Kees Cook <[e-mail]>

yukaixiong Aug. 27, 2024, 2:03 a.m. UTC | #2

On 2024/8/27 3:57, Kees Cook wrote:
> On Mon, Aug 26, 2024 at 08:04:34PM +0800, Kaixiong Yu wrote:
>> This patch series moves sysctls of vm_table in kernel/sysctl.c to
>> places where they actually belong, and do some related code clean-ups.
>> After this patch series, all sysctls in vm_table have been moved into its
>> own files, meanwhile, delete vm_table.
> This is really nice! Thanks for doing this migration. I sent a note
> about the "fs: dcache: ..." patch that I don't think will be a problem.
>
> Reviewed-by: Kees Cook <[e-mail]>
>
Thanks for your review !:-) Looking forward to future opportunities for 
further discussion and collaboration.

Joel Granados Sept. 2, 2024, 7:17 a.m. UTC | #3

On Mon, Aug 26, 2024 at 08:04:34PM +0800, Kaixiong Yu wrote:
> This patch series moves sysctls of vm_table in kernel/sysctl.c to
> places where they actually belong, and do some related code clean-ups.
> After this patch series, all sysctls in vm_table have been moved into its
> own files, meanwhile, delete vm_table.
> 
> All the modifications of this patch series base on
> linux-next(tags/next-20240823). To test this patch series, the code was
> compiled with both the CONFIG_SYSCTL enabled and disabled on arm64 and
> x86_64 architectures. After this patch series is applied, all files
> under /proc/sys/vm can be read or written normally.
> 
> Kaixiong Yu (15):
>   mm: vmstat: move sysctls to its own files
>   mm: filemap: move sysctl to its own file
>   mm: swap: move sysctl to its own file
>   mm: vmscan: move vmscan sysctls to its own file
>   mm: util: move sysctls into it own files
>   mm: mmap: move sysctl into its own file
>   security: min_addr: move sysctl into its own file
>   mm: nommu: move sysctl to its own file
>   fs: fs-writeback: move sysctl to its own file
>   fs: drop_caches: move sysctl to its own file
>   sunrpc: use vfs_pressure_ratio() helper
>   fs: dcache: move the sysctl into its own file
>   x86: vdso: move the sysctl into its own file
>   sh: vdso: move the sysctl into its own file
>   sysctl: remove unneeded include
> 

Thx for this.

I passed this through 0-day testing and it return some errors. Please
address those build errors/regrssions before you send V2.

Best

yukaixiong Sept. 2, 2024, 10:55 a.m. UTC | #4

On 2024/9/2 15:17, Joel Granados wrote:
> On Mon, Aug 26, 2024 at 08:04:34PM +0800, Kaixiong Yu wrote:
>> This patch series moves sysctls of vm_table in kernel/sysctl.c to
>> places where they actually belong, and do some related code clean-ups.
>> After this patch series, all sysctls in vm_table have been moved into its
>> own files, meanwhile, delete vm_table.
>>
>> All the modifications of this patch series base on
>> linux-next(tags/next-20240823). To test this patch series, the code was
>> compiled with both the CONFIG_SYSCTL enabled and disabled on arm64 and
>> x86_64 architectures. After this patch series is applied, all files
>> under /proc/sys/vm can be read or written normally.
>>
>> Kaixiong Yu (15):
>>    mm: vmstat: move sysctls to its own files
>>    mm: filemap: move sysctl to its own file
>>    mm: swap: move sysctl to its own file
>>    mm: vmscan: move vmscan sysctls to its own file
>>    mm: util: move sysctls into it own files
>>    mm: mmap: move sysctl into its own file
>>    security: min_addr: move sysctl into its own file
>>    mm: nommu: move sysctl to its own file
>>    fs: fs-writeback: move sysctl to its own file
>>    fs: drop_caches: move sysctl to its own file
>>    sunrpc: use vfs_pressure_ratio() helper
>>    fs: dcache: move the sysctl into its own file
>>    x86: vdso: move the sysctl into its own file
>>    sh: vdso: move the sysctl into its own file
>>    sysctl: remove unneeded include
>>
> Thx for this.
>
> I passed this through 0-day testing and it return some errors. Please
> address those build errors/regrssions before you send V2.
>
> Best

ok，I will fix those  errors/warnings in v2