diff mbox series

[RFC,02/20] adi: remove unused f_version

Message ID 20240830-vfs-file-f_version-v1-2-6d3e4816aa7b@kernel.org (mailing list archive)
State New
Headers show
Series file: remove f_version | expand

Commit Message

Christian Brauner Aug. 30, 2024, 1:04 p.m. UTC
It's not used for adi so don't bother with it at all.

Signed-off-by: Christian Brauner <brauner@kernel.org>
---
 drivers/char/adi.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Jan Kara Sept. 3, 2024, 10:30 a.m. UTC | #1
On Fri 30-08-24 15:04:43, Christian Brauner wrote:
> It's not used for adi so don't bother with it at all.
> 
> Signed-off-by: Christian Brauner <brauner@kernel.org>

Furthermore we allocate new files with kzalloc. Feel free to add:

Reviewed-by: Jan Kara <jack@suse.cz>

								Honza

> ---
>  drivers/char/adi.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/char/adi.c b/drivers/char/adi.c
> index 751d7cc0da1b..c091a0282ad0 100644
> --- a/drivers/char/adi.c
> +++ b/drivers/char/adi.c
> @@ -196,7 +196,6 @@ static loff_t adi_llseek(struct file *file, loff_t offset, int whence)
>  
>  	if (offset != file->f_pos) {
>  		file->f_pos = offset;
> -		file->f_version = 0;
>  		ret = offset;
>  	}
>  
> 
> -- 
> 2.45.2
>
diff mbox series

Patch

diff --git a/drivers/char/adi.c b/drivers/char/adi.c
index 751d7cc0da1b..c091a0282ad0 100644
--- a/drivers/char/adi.c
+++ b/drivers/char/adi.c
@@ -196,7 +196,6 @@  static loff_t adi_llseek(struct file *file, loff_t offset, int whence)
 
 	if (offset != file->f_pos) {
 		file->f_pos = offset;
-		file->f_version = 0;
 		ret = offset;
 	}