Message ID | 20240809094804.391441-1-francesco@dolcini.it (mailing list archive) |
---|---|
Headers | show |
Series | net: fec: add PPS channel configuration | expand |
Hi! I already proposed this 2 years ago. I was just about to resubmit it and found this series. Link: https://lore.kernel.org/netdev/20220803112449.37309-1-csokas.bence@prolan.hu/ What's the status of this? Also, please Cc: me in further conversations/revisions as well. Reviewed-by: "Csókás, Bence" <csokas.bence@prolan.hu> Thanks, Bence On 8/9/24 11:48, Francesco Dolcini wrote: > From: Francesco Dolcini <francesco.dolcini@toradex.com> > > Make the FEC Ethernet PPS channel configurable from device tree. > > v3 to just add the missing "net-next" subject prefix, sorry about the spam, it > seems like friday morning plus the mid of august heat wave is badly affecting > myself ... > > v2: https://lore.kernel.org/all/20240809091844.387824-1-francesco@dolcini.it/ > v1: https://lore.kernel.org/all/20240807144349.297342-1-francesco@dolcini.it/ > > Francesco Dolcini (3): > dt-bindings: net: fec: add pps channel property > net: fec: refactor PPS channel configuration > net: fec: make PPS channel configurable > > Documentation/devicetree/bindings/net/fsl,fec.yaml | 7 +++++++ > drivers/net/ethernet/freescale/fec_ptp.c | 11 ++++++----- > 2 files changed, 13 insertions(+), 5 deletions(-) >
Hello, On Tue, Sep 03, 2024 at 04:10:28PM +0200, Csókás Bence wrote: > What's the status of this? Also, please Cc: me in further > conversations/revisions as well. I am going to send a v4 in the next few days to address the comments on the dt-bindings change and apart of that I hope is good to go. Francesco
On 03.09.2024 18:07:00, Francesco Dolcini wrote: > On Tue, Sep 03, 2024 at 04:10:28PM +0200, Csókás Bence wrote: > > What's the status of this? Also, please Cc: me in further > > conversations/revisions as well. > > I am going to send a v4 in the next few days to address the comments > on the dt-bindings change and apart of that I hope is good to go. Have you read Richard's feedback on this? | https://lore.kernel.org/all/YvLJJkV2GRJWl7tA@hoboy.vegasvil.org There seems to be a standard interface for what you're trying to do, right? regards, Marc
Hi! On 9/3/24 18:57, Marc Kleine-Budde wrote: > On 03.09.2024 18:07:00, Francesco Dolcini wrote: >> On Tue, Sep 03, 2024 at 04:10:28PM +0200, Csókás Bence wrote: >>> What's the status of this? Also, please Cc: me in further >>> conversations/revisions as well. >> >> I am going to send a v4 in the next few days to address the comments >> on the dt-bindings change and apart of that I hope is good to go. > > Have you read Richard's feedback on this? > > | https://lore.kernel.org/all/YvLJJkV2GRJWl7tA@hoboy.vegasvil.org > > There seems to be a standard interface for what you're trying to do, > right? Yes, he was opposing the sysfs knobs I added, which is not in this patch series. Back then, I got moved to another project so I didn't have the time to address it. But once this series is merged, we can work on run-time output switching using the API. > regards, > Marc Bence
From: Francesco Dolcini <francesco.dolcini@toradex.com> Make the FEC Ethernet PPS channel configurable from device tree. v3 to just add the missing "net-next" subject prefix, sorry about the spam, it seems like friday morning plus the mid of august heat wave is badly affecting myself ... v2: https://lore.kernel.org/all/20240809091844.387824-1-francesco@dolcini.it/ v1: https://lore.kernel.org/all/20240807144349.297342-1-francesco@dolcini.it/ Francesco Dolcini (3): dt-bindings: net: fec: add pps channel property net: fec: refactor PPS channel configuration net: fec: make PPS channel configurable Documentation/devicetree/bindings/net/fsl,fec.yaml | 7 +++++++ drivers/net/ethernet/freescale/fec_ptp.c | 11 ++++++----- 2 files changed, 13 insertions(+), 5 deletions(-)