[v5,9/9] media: xilinx-tpg: use new of_graph functions

Commit Message

Kuninori Morimoto Sept. 4, 2024, 6:11 a.m. UTC

Now we can use new port related functions for port parsing. Use it.

Signed-off-by: Kuninori Morimoto <[e-mail]>
Reviewed-by: Tomi Valkeinen <[e-mail]>
---
 drivers/media/platform/xilinx/xilinx-tpg.c | 13 +++----------
 1 file changed, 3 insertions(+), 10 deletions(-)

Comments

Kuninori Morimoto Sept. 4, 2024, 7:56 a.m. UTC | #1

Hi

> Now we can use new port related functions for port parsing. Use it.
> 
> Signed-off-by: Kuninori Morimoto <[e-mail]>
> Reviewed-by: Tomi Valkeinen <[e-mail]>
> ---

I'm sorry, but this patch will get below warning

   drivers/media/platform/xilinx/xilinx-tpg.c: In function 'xtpg_parse_of':
>> drivers/media/platform/xilinx/xilinx-tpg.c:715:29: warning: unused variable 'port' [-Wunused-variable]

I will post v6 after review

Thank you for your help !!

Best regards
---
Kuninori Morimoto

Patch

diff --git a/drivers/media/platform/xilinx/xilinx-tpg.c b/drivers/media/platform/xilinx/xilinx-tpg.c
index e05e528ffc6f7..d8336965085d2 100644
--- a/drivers/media/platform/xilinx/xilinx-tpg.c
+++ b/drivers/media/platform/xilinx/xilinx-tpg.c
@@ -13,6 +13,7 @@ 
 #include <linux/gpio/consumer.h>
 #include <linux/module.h>
 #include <linux/of.h>
+#include <linux/of_graph.h>
 #include <linux/platform_device.h>
 #include <linux/xilinx-v4l2-controls.h>
 
@@ -711,22 +712,14 @@  static int xtpg_parse_of(struct xtpg_device *xtpg)
 {
 	struct device *dev = xtpg->xvip.dev;
 	struct device_node *node = xtpg->xvip.dev->of_node;
-	struct device_node *ports;
 	struct device_node *port;
 	unsigned int nports = 0;
 	bool has_endpoint = false;
 
-	ports = of_get_child_by_name(node, "ports");
-	if (ports == NULL)
-		ports = node;
-
-	for_each_child_of_node(ports, port) {
+	for_each_of_graph_port(node, port) {
 		const struct xvip_video_format *format;
 		struct device_node *endpoint;
 
-		if (!of_node_name_eq(port, "port"))
-			continue;
-
 		format = xvip_of_get_format(port);
 		if (IS_ERR(format)) {
 			dev_err(dev, "invalid format in DT");
@@ -744,7 +737,7 @@  static int xtpg_parse_of(struct xtpg_device *xtpg)
 		}
 
 		if (nports == 0) {
-			endpoint = of_get_next_child(port, NULL);
+			endpoint = of_graph_get_next_port_endpoint(port, NULL);
 			if (endpoint)
 				has_endpoint = true;
 			of_node_put(endpoint);