| Message ID | 20240828-remove-invalid-cc-v1-1-b29dbb379b28@bootlin.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [b4] Remove message-id from cc list | expand |
On Wed, 28 Aug 2024 12:39, Louis Chauvet <louis.chauvet@bootlin.com> wrote: >As the algorithm to detect mails to add in CC is very simple, it also >include the prerequisite-message-id to CC as they look like mails. In >order to avoid this kind of issue, filter out prerequisite-message-id >lines. > >Signed-off-by: Louis Chauvet <louis.chauvet@bootlin.com> >--- > src/b4/__init__.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/src/b4/__init__.py b/src/b4/__init__.py >index ec230e7ace66..b0d91c0e4017 100644 >--- a/src/b4/__init__.py >+++ b/src/b4/__init__.py >@@ -1990,7 +1990,7 @@ class LoreMessage: > > @staticmethod > def find_trailers(body: str, followup: bool = False) -> Tuple[List[LoreTrailer], List[str]]: >- ignores = {'phone', 'email'} >+ ignores = {'phone', 'email', 'prerequisite-message-id'} > headers = {'subject', 'date', 'from'} > links = {'link', 'buglink', 'closes'} > nonperson = links | {'fixes', 'subject', 'date', 'obsoleted-by', 'change-id', 'base-commit'} > >--- >base-commit: 99b128995f27cd9aa6fa8adf7588f339919ac14d >change-id: 20240828-remove-invalid-cc-eecbd7d43b3d > >Best regards, >-- >Louis Chauvet <louis.chauvet@bootlin.com> > Reviewed-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org> Tested-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
Louis Chauvet <louis.chauvet@bootlin.com> writes: > As the algorithm to detect mails to add in CC is very simple, it also > include the prerequisite-message-id to CC as they look like mails. In > order to avoid this kind of issue, filter out prerequisite-message-id > lines. > > Signed-off-by: Louis Chauvet <louis.chauvet@bootlin.com> > --- > src/b4/__init__.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/b4/__init__.py b/src/b4/__init__.py > index ec230e7ace66..b0d91c0e4017 100644 > --- a/src/b4/__init__.py > +++ b/src/b4/__init__.py > @@ -1990,7 +1990,7 @@ class LoreMessage: > > @staticmethod > def find_trailers(body: str, followup: bool = False) -> Tuple[List[LoreTrailer], List[str]]: > - ignores = {'phone', 'email'} > + ignores = {'phone', 'email', 'prerequisite-message-id'} > headers = {'subject', 'date', 'from'} > links = {'link', 'buglink', 'closes'} > nonperson = links | {'fixes', 'subject', 'date', 'obsoleted-by', 'change-id', 'base-commit'} > > --- > base-commit: 99b128995f27cd9aa6fa8adf7588f339919ac14d > change-id: 20240828-remove-invalid-cc-eecbd7d43b3d I have not been able to test (yet), but I'm guessing this should fix this bug[1] I reported a couple weeks ago. Thanks for the fix! Kevin [1] https://bugzilla.kernel.org/show_bug.cgi?id=219138
Kevin Hilman <khilman@baylibre.com> writes: > Louis Chauvet <louis.chauvet@bootlin.com> writes: > >> As the algorithm to detect mails to add in CC is very simple, it also >> include the prerequisite-message-id to CC as they look like mails. In >> order to avoid this kind of issue, filter out prerequisite-message-id >> lines. >> >> Signed-off-by: Louis Chauvet <louis.chauvet@bootlin.com> >> --- >> src/b4/__init__.py | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/src/b4/__init__.py b/src/b4/__init__.py >> index ec230e7ace66..b0d91c0e4017 100644 >> --- a/src/b4/__init__.py >> +++ b/src/b4/__init__.py >> @@ -1990,7 +1990,7 @@ class LoreMessage: >> >> @staticmethod >> def find_trailers(body: str, followup: bool = False) -> Tuple[List[LoreTrailer], List[str]]: >> - ignores = {'phone', 'email'} >> + ignores = {'phone', 'email', 'prerequisite-message-id'} >> headers = {'subject', 'date', 'from'} >> links = {'link', 'buglink', 'closes'} >> nonperson = links | {'fixes', 'subject', 'date', 'obsoleted-by', 'change-id', 'base-commit'} >> >> --- >> base-commit: 99b128995f27cd9aa6fa8adf7588f339919ac14d >> change-id: 20240828-remove-invalid-cc-eecbd7d43b3d > > I have not been able to test (yet), but I'm guessing this should fix this > bug[1] I reported a couple weeks ago. I can now confirm that this patch fixes this bug[1]. Thanks Louis for the fix! Kevin P.S. is there some bugbot magic to connect this thread to an existing bug? [1] https://bugzilla.kernel.org/show_bug.cgi?id=219138
On Wed, 28 Aug 2024 11:39:51 +0200, Louis Chauvet wrote: > As the algorithm to detect mails to add in CC is very simple, it also > include the prerequisite-message-id to CC as they look like mails. In > order to avoid this kind of issue, filter out prerequisite-message-id > lines. > > Applied, thanks! [1/1] Remove message-id from cc list commit: 77eaedc7de548fdaa289c51f62278633bd815d01 Best regards,
diff --git a/src/b4/__init__.py b/src/b4/__init__.py index ec230e7ace66..b0d91c0e4017 100644 --- a/src/b4/__init__.py +++ b/src/b4/__init__.py @@ -1990,7 +1990,7 @@ class LoreMessage: @staticmethod def find_trailers(body: str, followup: bool = False) -> Tuple[List[LoreTrailer], List[str]]: - ignores = {'phone', 'email'} + ignores = {'phone', 'email', 'prerequisite-message-id'} headers = {'subject', 'date', 'from'} links = {'link', 'buglink', 'closes'} nonperson = links | {'fixes', 'subject', 'date', 'obsoleted-by', 'change-id', 'base-commit'}
As the algorithm to detect mails to add in CC is very simple, it also include the prerequisite-message-id to CC as they look like mails. In order to avoid this kind of issue, filter out prerequisite-message-id lines. Signed-off-by: Louis Chauvet <louis.chauvet@bootlin.com> --- src/b4/__init__.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- base-commit: 99b128995f27cd9aa6fa8adf7588f339919ac14d change-id: 20240828-remove-invalid-cc-eecbd7d43b3d Best regards,