| Message ID | 20240908-regmap-config-const-v1-1-28f349004811@linaro.org (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | drm: misc: few simple cleanups | expand |
On 08/09/2024 16:21, Krzysztof Kozlowski wrote: > static inline dw_hdmi_dwc_write_bits() function is not used at all: > > drivers/gpu/drm/meson/meson_dw_hdmi.c:276:20: error: unused function 'dw_hdmi_dwc_write_bits' [-Werror,-Wunused-function] > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > drivers/gpu/drm/meson/meson_dw_hdmi.c | 14 -------------- > 1 file changed, 14 deletions(-) > > diff --git a/drivers/gpu/drm/meson/meson_dw_hdmi.c b/drivers/gpu/drm/meson/meson_dw_hdmi.c > index 5565f7777529..b75db829b1da 100644 > --- a/drivers/gpu/drm/meson/meson_dw_hdmi.c > +++ b/drivers/gpu/drm/meson/meson_dw_hdmi.c > @@ -272,20 +272,6 @@ static inline void dw_hdmi_g12a_dwc_write(struct meson_dw_hdmi *dw_hdmi, > writeb(data, dw_hdmi->hdmitx + addr); > } > > -/* Helper to change specific bits in controller registers */ > -static inline void dw_hdmi_dwc_write_bits(struct meson_dw_hdmi *dw_hdmi, > - unsigned int addr, > - unsigned int mask, > - unsigned int val) > -{ > - unsigned int data = dw_hdmi->data->dwc_read(dw_hdmi, addr); > - > - data &= ~mask; > - data |= val; > - > - dw_hdmi->data->dwc_write(dw_hdmi, addr, data); > -} > - > /* Bridge */ > > /* Setup PHY bandwidth modes */ > Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
On Sun, Sep 8, 2024 at 4:21 PM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > static inline dw_hdmi_dwc_write_bits() function is not used at all: > > drivers/gpu/drm/meson/meson_dw_hdmi.c:276:20: error: unused function 'dw_hdmi_dwc_write_bits' [-Werror,-Wunused-function] > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> maybe s/staitc/static/ can be applied to $SUBJECT when applying this patch Best regards, Martin
diff --git a/drivers/gpu/drm/meson/meson_dw_hdmi.c b/drivers/gpu/drm/meson/meson_dw_hdmi.c index 5565f7777529..b75db829b1da 100644 --- a/drivers/gpu/drm/meson/meson_dw_hdmi.c +++ b/drivers/gpu/drm/meson/meson_dw_hdmi.c @@ -272,20 +272,6 @@ static inline void dw_hdmi_g12a_dwc_write(struct meson_dw_hdmi *dw_hdmi, writeb(data, dw_hdmi->hdmitx + addr); } -/* Helper to change specific bits in controller registers */ -static inline void dw_hdmi_dwc_write_bits(struct meson_dw_hdmi *dw_hdmi, - unsigned int addr, - unsigned int mask, - unsigned int val) -{ - unsigned int data = dw_hdmi->data->dwc_read(dw_hdmi, addr); - - data &= ~mask; - data |= val; - - dw_hdmi->data->dwc_write(dw_hdmi, addr, data); -} - /* Bridge */ /* Setup PHY bandwidth modes */
static inline dw_hdmi_dwc_write_bits() function is not used at all: drivers/gpu/drm/meson/meson_dw_hdmi.c:276:20: error: unused function 'dw_hdmi_dwc_write_bits' [-Werror,-Wunused-function] Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- drivers/gpu/drm/meson/meson_dw_hdmi.c | 14 -------------- 1 file changed, 14 deletions(-)