| Message ID | 20240909133034.1296930-5-ruanjinjie@huawei.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | net: Use IRQF_NO_AUTOEN flag in request_irq() | expand |
Hi Jinjie, ruanjinjie@huawei.com wrote on Mon, 9 Sep 2024 21:30:31 +0800: > disable_irq() after request_irq() still has a time gap in which > interrupts can come. request_irq() with IRQF_NO_AUTOEN flag will > disable IRQ auto-enable when request IRQ. > > Fixes: 8c6ad9cc5157 ("ieee802154: Add NXP MCR20A IEEE 802.15.4 transceiver driver") > Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com> This one could go through wpan(-next), but otherwise: Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com> Thanks, Miquèl
Hello Jinjie Ruan. On 9/9/24 3:30 PM, Jinjie Ruan wrote: > disable_irq() after request_irq() still has a time gap in which > interrupts can come. request_irq() with IRQF_NO_AUTOEN flag will > disable IRQ auto-enable when request IRQ. > > Fixes: 8c6ad9cc5157 ("ieee802154: Add NXP MCR20A IEEE 802.15.4 transceiver driver") > Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com> > --- > drivers/net/ieee802154/mcr20a.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/net/ieee802154/mcr20a.c b/drivers/net/ieee802154/mcr20a.c > index 433fb5839203..020d392a98b6 100644 > --- a/drivers/net/ieee802154/mcr20a.c > +++ b/drivers/net/ieee802154/mcr20a.c > @@ -1302,16 +1302,13 @@ mcr20a_probe(struct spi_device *spi) > irq_type = IRQF_TRIGGER_FALLING; > > ret = devm_request_irq(&spi->dev, spi->irq, mcr20a_irq_isr, > - irq_type, dev_name(&spi->dev), lp); > + irq_type | IRQF_NO_AUTOEN, dev_name(&spi->dev), lp); > if (ret) { > dev_err(&spi->dev, "could not request_irq for mcr20a\n"); > ret = -ENODEV; > goto free_dev; > } > > - /* disable_irq by default and wait for starting hardware */ > - disable_irq(spi->irq); > - > ret = ieee802154_register_hw(hw); > if (ret) { > dev_crit(&spi->dev, "ieee802154_register_hw failed\n"); Dave, Eric, Jakub, if you are taking them into net/net-next directly here is my ack (and Miquel's review as well). Acked-by: Stefan Schmidt <stefan@datenfreihafen.org> regards Stefan Schmidt
diff --git a/drivers/net/ieee802154/mcr20a.c b/drivers/net/ieee802154/mcr20a.c index 433fb5839203..020d392a98b6 100644 --- a/drivers/net/ieee802154/mcr20a.c +++ b/drivers/net/ieee802154/mcr20a.c @@ -1302,16 +1302,13 @@ mcr20a_probe(struct spi_device *spi) irq_type = IRQF_TRIGGER_FALLING; ret = devm_request_irq(&spi->dev, spi->irq, mcr20a_irq_isr, - irq_type, dev_name(&spi->dev), lp); + irq_type | IRQF_NO_AUTOEN, dev_name(&spi->dev), lp); if (ret) { dev_err(&spi->dev, "could not request_irq for mcr20a\n"); ret = -ENODEV; goto free_dev; } - /* disable_irq by default and wait for starting hardware */ - disable_irq(spi->irq); - ret = ieee802154_register_hw(hw); if (ret) { dev_crit(&spi->dev, "ieee802154_register_hw failed\n");
disable_irq() after request_irq() still has a time gap in which interrupts can come. request_irq() with IRQF_NO_AUTOEN flag will disable IRQ auto-enable when request IRQ. Fixes: 8c6ad9cc5157 ("ieee802154: Add NXP MCR20A IEEE 802.15.4 transceiver driver") Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com> --- drivers/net/ieee802154/mcr20a.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)