| Message ID | 20240911115448.277828-1-suhui@nfschina.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 38cc0334baabc5baf08a1db753de521e016c0432 |
| Headers | show |
| Series | ASoC: codecs: avoid possible garbage value in peb2466_reg_read() | expand |
On Wed, 11 Sep 2024 19:54:50 +0800, Su Hui wrote: > Clang static checker (scan-build) warning: > sound/soc/codecs/peb2466.c:232:8: > Assigned value is garbage or undefined [core.uninitialized.Assign] > 232 | *val = tmp; > | ^ ~~~ > > When peb2466_read_byte() fails, 'tmp' will have a garbage value. > Add a judgemnet to avoid this problem. > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] ASoC: codecs: avoid possible garbage value in peb2466_reg_read() commit: 38cc0334baabc5baf08a1db753de521e016c0432 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
diff --git a/sound/soc/codecs/peb2466.c b/sound/soc/codecs/peb2466.c index 76ee7e3f4d9b..67ea70cef0c7 100644 --- a/sound/soc/codecs/peb2466.c +++ b/sound/soc/codecs/peb2466.c @@ -229,7 +229,8 @@ static int peb2466_reg_read(void *context, unsigned int reg, unsigned int *val) case PEB2466_CMD_XOP: case PEB2466_CMD_SOP: ret = peb2466_read_byte(peb2466, reg, &tmp); - *val = tmp; + if (!ret) + *val = tmp; break; default: dev_err(&peb2466->spi->dev, "Not a XOP or SOP command\n");
Clang static checker (scan-build) warning: sound/soc/codecs/peb2466.c:232:8: Assigned value is garbage or undefined [core.uninitialized.Assign] 232 | *val = tmp; | ^ ~~~ When peb2466_read_byte() fails, 'tmp' will have a garbage value. Add a judgemnet to avoid this problem. Fixes: 227f609c7c0e ("ASoC: codecs: Add support for the Infineon PEB2466 codec") Signed-off-by: Su Hui <suhui@nfschina.com> --- sound/soc/codecs/peb2466.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)