| Message ID | 20240910075357.3531211-1-Delphine_CC_Chiu@wiwynn.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v1] ARM: dts: aspeed: yosemite4: Add power module and ADC on Medusa Board | expand |
On Tue, 10 Sep 2024 15:53:56 +0800, Delphine CC Chiu wrote: > From: Ricky CX Wu <ricky.cx.wu.wiwynn@gmail.com> > > Add RTQ6056 as 2nd source ADC sensor on Medusa Board. > Add power sensors on Medusa board: > - Add XDP710 as 2nd source HSC to monitor P48V PSU power. > - Add MP5023 as P12V efuse (Driver exists but un-documented). > - Add PMBUS sensors as P12V Delta Module. > > Signed-off-by: Ricky CX Wu <ricky.cx.wu.wiwynn@gmail.com> > Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@wiwynn.com> > --- > .../aspeed/aspeed-bmc-facebook-yosemite4.dts | 45 ++++++++++++++++++- > 1 file changed, 43 insertions(+), 2 deletions(-) > My bot found new DTB warnings on the .dts files added or changed in this series. Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings are fixed by another series. Ultimately, it is up to the platform maintainer whether these warnings are acceptable or not. No need to reply unless the platform maintainer has comments. If you already ran DT checks and didn't see these error(s), then make sure dt-schema is up to date: pip3 install dtschema --upgrade New warnings running 'make CHECK_DTBS=y aspeed/aspeed-bmc-facebook-yosemite4.dtb' for 20240910075357.3531211-1-Delphine_CC_Chiu@wiwynn.com: arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dtb: /ahb/apb/bus@1e78a000/i2c@600/power-sensor@40: failed to match any schema with compatible: ['mps,mp5023'] arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dtb: /ahb/apb/bus@1e78a000/i2c@600/power-sensor@62: failed to match any schema with compatible: ['pmbus'] arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dtb: /ahb/apb/bus@1e78a000/i2c@600/power-sensor@64: failed to match any schema with compatible: ['pmbus'] arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dtb: /ahb/apb/bus@1e78a000/i2c@600/power-sensor@65: failed to match any schema with compatible: ['pmbus'] arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dtb: /ahb/apb/bus@1e78a000/i2c@600/power-sensor@68: failed to match any schema with compatible: ['pmbus']
Hi Ricky, On Tue, 2024-09-10 at 09:15 -0500, Rob Herring (Arm) wrote: > On Tue, 10 Sep 2024 15:53:56 +0800, Delphine CC Chiu wrote: > > From: Ricky CX Wu <ricky.cx.wu.wiwynn@gmail.com> > > > > Add RTQ6056 as 2nd source ADC sensor on Medusa Board. > > Add power sensors on Medusa board: > > - Add XDP710 as 2nd source HSC to monitor P48V PSU power. > > - Add MP5023 as P12V efuse (Driver exists but un-documented). > > - Add PMBUS sensors as P12V Delta Module. > > > > Signed-off-by: Ricky CX Wu <ricky.cx.wu.wiwynn@gmail.com> > > Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@wiwynn.com> > > --- > > .../aspeed/aspeed-bmc-facebook-yosemite4.dts | 45 ++++++++++++++++++- > > 1 file changed, 43 insertions(+), 2 deletions(-) > > > > > My bot found new DTB warnings on the .dts files added or changed in this > series. > > Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings > are fixed by another series. Ultimately, it is up to the platform > maintainer whether these warnings are acceptable or not. No need to reply > unless the platform maintainer has comments. > > If you already ran DT checks and didn't see these error(s), then > make sure dt-schema is up to date: > > pip3 install dtschema --upgrade > > > New warnings running 'make CHECK_DTBS=y aspeed/aspeed-bmc-facebook-yosemite4.dtb' for 20240910075357.3531211-1-Delphine_CC_Chiu@wiwynn.com: > > arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dtb: /ahb/apb/bus@1e78a000/i2c@600/power-sensor@40: failed to match any schema with compatible: ['mps,mp5023'] > arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dtb: /ahb/apb/bus@1e78a000/i2c@600/power-sensor@62: failed to match any schema with compatible: ['pmbus'] > arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dtb: /ahb/apb/bus@1e78a000/i2c@600/power-sensor@64: failed to match any schema with compatible: ['pmbus'] > arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dtb: /ahb/apb/bus@1e78a000/i2c@600/power-sensor@65: failed to match any schema with compatible: ['pmbus'] > arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dtb: /ahb/apb/bus@1e78a000/i2c@600/power-sensor@68: failed to match any schema with compatible: ['pmbus'] Can you please either: 1. Drop these nodes so we're not adding more warnings, or 2. Write the appropriate bindings and send them in a v2? Andrew
diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts index 98477792aa00..e486b9d78f61 100644 --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts @@ -284,15 +284,25 @@ &i2c10 { &i2c11 { status = "okay"; power-sensor@10 { - compatible = "adi, adm1272"; + compatible = "adi,adm1272"; reg = <0x10>; }; + power-sensor@11 { + compatible = "infineon,xdp710"; + reg = <0x11>; + }; + power-sensor@12 { - compatible = "adi, adm1272"; + compatible = "adi,adm1272"; reg = <0x12>; }; + power-sensor@13 { + compatible = "infineon,xdp710"; + reg = <0x13>; + }; + gpio@20 { compatible = "nxp,pca9555"; reg = <0x20>; @@ -321,6 +331,17 @@ gpio@23 { #gpio-cells = <2>; }; + power-sensor@40 { + compatible = "mps,mp5023"; + reg = <0x40>; + }; + + adc@41 { + compatible = "richtek,rtq6056"; + reg = <0x41>; + #io-channel-cells = <1>; + }; + temperature-sensor@48 { compatible = "ti,tmp75"; reg = <0x48>; @@ -345,6 +366,26 @@ eeprom@54 { compatible = "atmel,24c256"; reg = <0x54>; }; + + power-sensor@62 { + compatible = "pmbus"; + reg = <0x62>; + }; + + power-sensor@64 { + compatible = "pmbus"; + reg = <0x64>; + }; + + power-sensor@65 { + compatible = "pmbus"; + reg = <0x65>; + }; + + power-sensor@68 { + compatible = "pmbus"; + reg = <0x68>; + }; }; &i2c12 {