| Message ID | 20240911-topic-amlogic-arm32-upstream-bindings-fixes-v1-6-feaabb45916b@linaro.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | ARM: dts: amlogic: first easy dtbs fixes | expand |
Hi Neil, On Wed, Sep 11, 2024 at 12:19 PM Neil Armstrong <neil.armstrong@linaro.org> wrote: [...] > - memory { > + memory@0 { > device_type = "memory"; > reg = <0x40000000 0x80000000>; On the 32-bit SoCs we specify memory at an 0x40000000 offset. Shouldn't we use memory@40000000 in that case?
On 15/09/2024 21:05, Martin Blumenstingl wrote: > Hi Neil, > > On Wed, Sep 11, 2024 at 12:19 PM Neil Armstrong > <neil.armstrong@linaro.org> wrote: > [...] >> - memory { >> + memory@0 { >> device_type = "memory"; >> reg = <0x40000000 0x80000000>; > On the 32-bit SoCs we specify memory at an 0x40000000 offset. > Shouldn't we use memory@40000000 in that case? Yes you're right, I'll fix it in v2 Neil
diff --git a/arch/arm/boot/dts/amlogic/meson6-atv1200.dts b/arch/arm/boot/dts/amlogic/meson6-atv1200.dts index 98e1c94c0261..f3529e5b0f13 100644 --- a/arch/arm/boot/dts/amlogic/meson6-atv1200.dts +++ b/arch/arm/boot/dts/amlogic/meson6-atv1200.dts @@ -18,7 +18,7 @@ chosen { stdout-path = "serial0:115200n8"; }; - memory { + memory@0 { device_type = "memory"; reg = <0x40000000 0x80000000>; }; diff --git a/arch/arm/boot/dts/amlogic/meson8-minix-neo-x8.dts b/arch/arm/boot/dts/amlogic/meson8-minix-neo-x8.dts index c6d1c5a8a3bf..e7f5d290c1b8 100644 --- a/arch/arm/boot/dts/amlogic/meson8-minix-neo-x8.dts +++ b/arch/arm/boot/dts/amlogic/meson8-minix-neo-x8.dts @@ -19,7 +19,7 @@ chosen { stdout-path = "serial0:115200n8"; }; - memory { + memory@0 { device_type = "memory"; reg = <0x40000000 0x80000000>; }; diff --git a/arch/arm/boot/dts/amlogic/meson8b-ec100.dts b/arch/arm/boot/dts/amlogic/meson8b-ec100.dts index 49890eb12781..bf5e80c874a7 100644 --- a/arch/arm/boot/dts/amlogic/meson8b-ec100.dts +++ b/arch/arm/boot/dts/amlogic/meson8b-ec100.dts @@ -22,7 +22,7 @@ chosen { stdout-path = "serial0:115200n8"; }; - memory { + memory@0 { device_type = "memory"; reg = <0x40000000 0x40000000>; }; diff --git a/arch/arm/boot/dts/amlogic/meson8b-mxq.dts b/arch/arm/boot/dts/amlogic/meson8b-mxq.dts index 7adedd3258c3..f48748a02409 100644 --- a/arch/arm/boot/dts/amlogic/meson8b-mxq.dts +++ b/arch/arm/boot/dts/amlogic/meson8b-mxq.dts @@ -22,7 +22,7 @@ chosen { stdout-path = "serial0:115200n8"; }; - memory { + memory@0 { device_type = "memory"; reg = <0x40000000 0x40000000>; }; diff --git a/arch/arm/boot/dts/amlogic/meson8b-odroidc1.dts b/arch/arm/boot/dts/amlogic/meson8b-odroidc1.dts index 962bbe3337db..85dae08afe9e 100644 --- a/arch/arm/boot/dts/amlogic/meson8b-odroidc1.dts +++ b/arch/arm/boot/dts/amlogic/meson8b-odroidc1.dts @@ -22,7 +22,7 @@ chosen { stdout-path = "serial0:115200n8"; }; - memory { + memory@0 { device_type = "memory"; reg = <0x40000000 0x40000000>; }; diff --git a/arch/arm/boot/dts/amlogic/meson8m2-mxiii-plus.dts b/arch/arm/boot/dts/amlogic/meson8m2-mxiii-plus.dts index aa4d4bf70629..587bbe706fd1 100644 --- a/arch/arm/boot/dts/amlogic/meson8m2-mxiii-plus.dts +++ b/arch/arm/boot/dts/amlogic/meson8m2-mxiii-plus.dts @@ -26,7 +26,7 @@ chosen { stdout-path = "serial0:115200n8"; }; - memory { + memory@0 { device_type = "memory"; reg = <0x40000000 0x80000000>; };
Use proper address in /memory node name, fixing: /: memory: False schema does not allow {'device_type': ['memory'], 'reg': [[1073741824, 2147483648]]} Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> --- arch/arm/boot/dts/amlogic/meson6-atv1200.dts | 2 +- arch/arm/boot/dts/amlogic/meson8-minix-neo-x8.dts | 2 +- arch/arm/boot/dts/amlogic/meson8b-ec100.dts | 2 +- arch/arm/boot/dts/amlogic/meson8b-mxq.dts | 2 +- arch/arm/boot/dts/amlogic/meson8b-odroidc1.dts | 2 +- arch/arm/boot/dts/amlogic/meson8m2-mxiii-plus.dts | 2 +- 6 files changed, 6 insertions(+), 6 deletions(-)