diff mbox series

[v1] hwmon: Convert comma to semicolon

Message ID 20240918033512.9351-1-shenlichuan@vivo.com (mailing list archive)
State Changes Requested
Headers show
Series [v1] hwmon: Convert comma to semicolon | expand

Commit Message

Shen Lichuan Sept. 18, 2024, 3:35 a.m. UTC 
To ensure code clarity and prevent potential errors, it's advisable
to employ the ';' as a statement separator, except when ',' are
intentionally used for specific purposes.

Signed-off-by: Shen Lichuan <shenlichuan@vivo.com>
---
 drivers/hwmon/pmbus/mpq8785.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Guenter Roeck Sept. 18, 2024, 3:45 a.m. UTC | #1 
On 9/17/24 20:35, Shen Lichuan wrote:
> To ensure code clarity and prevent potential errors, it's advisable
> to employ the ';' as a statement separator, except when ',' are
> intentionally used for specific purposes.
> 
> Signed-off-by: Shen Lichuan <shenlichuan@vivo.com>

The is expected to include include the driver name. Please check other patches
into the hwmon subsystem for reference, and please consider reading the
documentation about submitting patches. I am _not_ going to accept any patches
which lack this information.

Guenter
diff mbox series

Patch

diff --git a/drivers/hwmon/pmbus/mpq8785.c b/drivers/hwmon/pmbus/mpq8785.c
index 7f87e117b49d..0d16491cd770 100644
--- a/drivers/hwmon/pmbus/mpq8785.c
+++ b/drivers/hwmon/pmbus/mpq8785.c
@@ -22,7 +22,7 @@  static int mpq8785_identify(struct i2c_client *client,
 		break;
 	case 1:
 	case 2:
-		info->format[PSC_VOLTAGE_OUT] = direct,
+		info->format[PSC_VOLTAGE_OUT] = direct;
 		info->m[PSC_VOLTAGE_OUT] = 64;
 		info->b[PSC_VOLTAGE_OUT] = 0;
 		info->R[PSC_VOLTAGE_OUT] = 1;