| Message ID | 20240913100011.4618-1-Jianping.Shen@de.bosch.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | iio: imu: smi240: add bosch smi240 driver | expand |
On 13/09/2024 12:00, Jianping.Shen@de.bosch.com wrote: > From: Shen Jianping <Jianping.Shen@de.bosch.com> > > Add the iio driver for bosch imu smi240. The smi240 is a combined > three axis angular rate and three axis acceleration sensor module > with a measurement range of +/-300°/s and up to 16g. This driver > provides raw data access for each axis through sysfs, and tiggered > buffer for continuous sampling. A synchronous acc and gyro sampling > can be triggered by setting the capture bit in spi read command. > > dt-bindings: > v1 -> v2 > - Add more detail in description > - Add maintainer > - Add vdd and vddio power supply > - Use generic node name > - Order the properties according to DTS coding style > > v2 -> v3 > - Improve description > - Improve supply definition > - Make supply definition as required > - Add supply definition in example > > v3 -> v4 > - No changes > > v4 -> v5 > - No changes > > v5 -> v6 > - Fix checkpatch findings > > v6 -> v7 > - No changes > > imu driver: > v1 -> v2 > - Use regmap for register access > - Redefine channel for each singel axis > - Provide triggered buffer > - Fix findings in Kconfig > - Remove unimportant functions > > v2 -> v3 > - Use enum für capture mode > - Using spi default init value instead manual init > - remove duplicated module declaration > - Fix code to avoid warning > > v3 -> v4 > - Use DMA safe buffer > - Use channel info instead of custom ABI > - Fix other findings > > v4 -> v5 > - Merge the implementation in one simple file > - Add channel info for acc/gyro data channel > - Fix other findings ? > > v5 -> v6 > - Fix checkpatch findings > - Fix review findings ? What exactly happened? Your changelog is way too vague. What happened with our reviews? Why did you get multiple of them? Best regards, Krzysztof
>> Add the iio driver for bosch imu smi240. The smi240 is a combined >> three axis angular rate and three axis acceleration sensor module with >> a measurement range of +/-300°/s and up to 16g. This driver provides >> raw data access for each axis through sysfs, and tiggered buffer for >> continuous sampling. A synchronous acc and gyro sampling can be >> triggered by setting the capture bit in spi read command. >> >> dt-bindings: >> v1 -> v2 >> - Add more detail in description >> - Add maintainer >> - Add vdd and vddio power supply >> - Use generic node name >> - Order the properties according to DTS coding style >> >> v2 -> v3 >> - Improve description >> - Improve supply definition >> - Make supply definition as required >> - Add supply definition in example >> >> v3 -> v4 >> - No changes >> >> v4 -> v5 >> - No changes >> >> v5 -> v6 >> - Fix checkpatch findings >> >> v6 -> v7 >> - No changes >> >> imu driver: >> v1 -> v2 >> - Use regmap for register access >> - Redefine channel for each singel axis >> - Provide triggered buffer >> - Fix findings in Kconfig >> - Remove unimportant functions >> >> v2 -> v3 >> - Use enum für capture mode >> - Using spi default init value instead manual init >> - remove duplicated module declaration >> - Fix code to avoid warning >> >> v3 -> v4 >> - Use DMA safe buffer >> - Use channel info instead of custom ABI >> - Fix other findings >> >> v4 -> v5 >> - Merge the implementation in one simple file >> - Add channel info for acc/gyro data channel >> - Fix other findings > >? > >> >> v5 -> v6 >> - Fix checkpatch findings >> - Fix review findings > >? What exactly happened? Your changelog is way too vague. > >What happened with our reviews? Why did you get multiple of them? > Sorry for the confusing. let me make it clear 1. On 15.08 Conor reviewed the V3 dt-binding 2. On 26.08 we submit V4 (same as v3) without adding review tag. Krzysztof reviewed again and told us, that we need add review tag in patch. 3. On 05.09 we submit V5 which contains 2 tailing space in the description. This leads to checkpatch error. Krzysztof told us to get rid of those checkpatch errors. 4. On 10.09 we removed the tailing space and submit V6 (same as v3 and v4) without adding review tag. Rog gave the last review. 5. On 13.09 we submit V7 (same as v3, v4, and v6) with review tag of Conor, Krzysztof, and Rob. That is where the 3 reviews come from. In the dt-binding changelog we have "v5 -> v6 Fix checkpatch findings" Best regards Jianping
From: Shen Jianping <Jianping.Shen@de.bosch.com> Add the iio driver for bosch imu smi240. The smi240 is a combined three axis angular rate and three axis acceleration sensor module with a measurement range of +/-300°/s and up to 16g. This driver provides raw data access for each axis through sysfs, and tiggered buffer for continuous sampling. A synchronous acc and gyro sampling can be triggered by setting the capture bit in spi read command. dt-bindings: v1 -> v2 - Add more detail in description - Add maintainer - Add vdd and vddio power supply - Use generic node name - Order the properties according to DTS coding style v2 -> v3 - Improve description - Improve supply definition - Make supply definition as required - Add supply definition in example v3 -> v4 - No changes v4 -> v5 - No changes v5 -> v6 - Fix checkpatch findings v6 -> v7 - No changes imu driver: v1 -> v2 - Use regmap for register access - Redefine channel for each singel axis - Provide triggered buffer - Fix findings in Kconfig - Remove unimportant functions v2 -> v3 - Use enum für capture mode - Using spi default init value instead manual init - remove duplicated module declaration - Fix code to avoid warning v3 -> v4 - Use DMA safe buffer - Use channel info instead of custom ABI - Fix other findings v4 -> v5 - Merge the implementation in one simple file - Add channel info for acc/gyro data channel - Fix other findings v5 -> v6 - Fix checkpatch findings - Fix review findings v6 -> v7 - Fix offset and scale Shen Jianping (2): dt-bindings: iio: imu: smi240: add Bosch smi240 iio: imu: smi240: add driver .../bindings/iio/imu/bosch,smi240.yaml | 51 ++ drivers/iio/imu/Kconfig | 14 + drivers/iio/imu/Makefile | 2 + drivers/iio/imu/smi240.c | 611 ++++++++++++++++++ 4 files changed, 678 insertions(+) create mode 100644 Documentation/devicetree/bindings/iio/imu/bosch,smi240.yaml create mode 100644 drivers/iio/imu/smi240.c