| Message ID | 20240920133615.167726-2-inv.git-commit@tdk.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | Add support of IAM-20680 HP & HT | expand |
On 20/09/2024 15:36, inv.git-commit@tdk.com wrote: > From: Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@tdk.com> > > IAM-20680HT & HP are 2 variants of IAM-20680 fully compatible. > They just have better specs, temperature range and a bigger FIFO. > > Signed-off-by: Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@tdk.com> You just sent it... please do not send the same over and over again. See submitting patches. Your contributions should be versioned and provide changelog in cover letter or within patch's changelog (---). Sending the same over and over will get the same answer: nope. Best regards, Krzysztof
Hello, sorry about that, since there are no modifications at all in the patches and just sent them with the added email lists, I wasn't thinking there was a need to update the version. I will resend with an updated version number to the right lists then, even if the patches are strictly the same. Sorry about that. Thanks, JB
On Fri, 20 Sep 2024 14:39:14 +0000 Jean-Baptiste Maneyrol <Jean-Baptiste.Maneyrol@tdk.com> wrote: > Hello, > > sorry about that, since there are no modifications at all in the patches and just sent them with the added email lists, I wasn't thinking there was a need to update the version. > > I will resend with an updated version number to the right lists then, even if the patches are strictly the same. [RESEND PATCH...] and say in the cover letter why the resend and then don't change the revision. Jonathan > > Sorry about that. > > Thanks, > JB > > ________________________________________ > From: Krzysztof Kozlowski <krzk@kernel.org> > Sent: Friday, September 20, 2024 15:39 > To: INV Git Commit <INV.git-commit@tdk.com>; jic23@kernel.org <jic23@kernel.org>; robh@kernel.org <robh@kernel.org>; krzk+dt@kernel.org <krzk+dt@kernel.org>; conor+dt@kernel.org <conor+dt@kernel.org> > Cc: lars@metafoo.de <lars@metafoo.de>; linux-iio@vger.kernel.org <linux-iio@vger.kernel.org>; devicetree@vger.kernel.org <devicetree@vger.kernel.org>; Jean-Baptiste Maneyrol <Jean-Baptiste.Maneyrol@tdk.com> > Subject: Re: [PATCH 1/2] dt-bindings: iio: imu: mpu6050: Add iam20680ht/hp bindings to mpu6050 > > This Message Is From an External Sender > This message came from outside your organization. > > On 20/09/2024 15:36, inv.git-commit@tdk.com wrote: > > From: Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@tdk.com> > > > > IAM-20680HT & HP are 2 variants of IAM-20680 fully compatible. > > They just have better specs, temperature range and a bigger FIFO. > > > > Signed-off-by: Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@tdk.com> > > You just sent it... please do not send the same over and over again. See > submitting patches. Your contributions should be versioned and provide > changelog in cover letter or within patch's changelog (---). > > Sending the same over and over will get the same answer: nope. > > Best regards, > Krzysztof >
On Fri, 20 Sep 2024 13:36:14 +0000 inv.git-commit@tdk.com wrote: > From: Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@tdk.com> > > IAM-20680HT & HP are 2 variants of IAM-20680 fully compatible. > They just have better specs, temperature range and a bigger FIFO. Is that fifo size discoverable? If not then I'd describe them as 'backwards compatible' but not 'fully' compatible. So the binding is fine, as an aware driver would use the more specific choice anyway and hence deal with that fifo size change correctly. Someone who paid for this part probably wants their bigger fifo. Otherwise this looks fine to me as does the next patch. Jonathan > > Signed-off-by: Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@tdk.com> > --- > .../devicetree/bindings/iio/imu/invensense,mpu6050.yaml | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/Documentation/devicetree/bindings/iio/imu/invensense,mpu6050.yaml b/Documentation/devicetree/bindings/iio/imu/invensense,mpu6050.yaml > index 587ff2bced2d..a8d30ef015fa 100644 > --- a/Documentation/devicetree/bindings/iio/imu/invensense,mpu6050.yaml > +++ b/Documentation/devicetree/bindings/iio/imu/invensense,mpu6050.yaml > @@ -36,6 +36,11 @@ properties: > - items: > - const: invensense,icm20608d > - const: invensense,icm20608 > + - items: > + - enum: > + - invensense,iam20680hp > + - invensense,iam20680ht > + - const: invensense,iam20680 > > reg: > maxItems: 1 > -- > 2.34.1 >
diff --git a/Documentation/devicetree/bindings/iio/imu/invensense,mpu6050.yaml b/Documentation/devicetree/bindings/iio/imu/invensense,mpu6050.yaml index 587ff2bced2d..a8d30ef015fa 100644 --- a/Documentation/devicetree/bindings/iio/imu/invensense,mpu6050.yaml +++ b/Documentation/devicetree/bindings/iio/imu/invensense,mpu6050.yaml @@ -36,6 +36,11 @@ properties: - items: - const: invensense,icm20608d - const: invensense,icm20608 + - items: + - enum: + - invensense,iam20680hp + - invensense,iam20680ht + - const: invensense,iam20680 reg: maxItems: 1