diff mbox series

[1/3] dt-bindings: pinctrl: renesas,rzg2l-pinctrl: Allow 'input-schmitt-{enable,disable}' and 'drive-open-drain' properties

Message ID 20240918120909.284930-2-prabhakar.mahadev-lad.rj@bp.renesas.com (mailing list archive)
State Superseded
Delegated to: Geert Uytterhoeven
Headers show
Series pinctrl: renesas: rzg2l: Add support to configure open-drain and schmitt-trigger properties | expand

Commit Message

Lad, Prabhakar Sept. 18, 2024, 12:09 p.m. UTC 
From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

On the RZ/V2H(P) SoC we can configure the 'input-schmitt-{enable,disable}'
and 'drive-open-drain' of multiplexed pins. Update the binding
documentation to include these properties.

Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
---
 .../devicetree/bindings/pinctrl/renesas,rzg2l-pinctrl.yaml     | 3 +++
 1 file changed, 3 insertions(+)

Comments

Rob Herring Sept. 21, 2024, 12:52 a.m. UTC | #1 
On Wed, 18 Sep 2024 13:09:07 +0100, Prabhakar wrote:
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> 
> On the RZ/V2H(P) SoC we can configure the 'input-schmitt-{enable,disable}'
> and 'drive-open-drain' of multiplexed pins. Update the binding
> documentation to include these properties.
> 
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> ---
>  .../devicetree/bindings/pinctrl/renesas,rzg2l-pinctrl.yaml     | 3 +++
>  1 file changed, 3 insertions(+)
> 

Acked-by: Rob Herring (Arm) <robh@kernel.org>
Geert Uytterhoeven Oct. 4, 2024, 7:53 a.m. UTC | #2 
Hi Fabrizio,

On Wed, Sep 18, 2024 at 2:09 PM Prabhakar <prabhakar.csengg@gmail.com> wrote:
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>
> On the RZ/V2H(P) SoC we can configure the 'input-schmitt-{enable,disable}'
> and 'drive-open-drain' of multiplexed pins. Update the binding
> documentation to include these properties.
>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

Thanks for your patch!

> --- a/Documentation/devicetree/bindings/pinctrl/renesas,rzg2l-pinctrl.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/renesas,rzg2l-pinctrl.yaml
> @@ -119,6 +119,9 @@ additionalProperties:
>          bias-disable: true
>          bias-pull-down: true
>          bias-pull-up: true
> +        input-schmitt-enable: true
> +        input-schmitt-disable: true
> +        drive-open-drain: true

I think you also need "drive-push-pull", to disable open drain.

>          renesas,output-impedance:
>            description:
>              Output impedance for pins on the RZ/V2H(P) SoC. The value provided by this

Gr{oetje,eeting}s,

                        Geert
Lad, Prabhakar Oct. 4, 2024, 11:40 a.m. UTC | #3 
Hi Geert,

Thank you for the review.

On Fri, Oct 4, 2024 at 8:54 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
>
> Hi Fabrizio,
>
> On Wed, Sep 18, 2024 at 2:09 PM Prabhakar <prabhakar.csengg@gmail.com> wrote:
> > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> >
> > On the RZ/V2H(P) SoC we can configure the 'input-schmitt-{enable,disable}'
> > and 'drive-open-drain' of multiplexed pins. Update the binding
> > documentation to include these properties.
> >
> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>
> Thanks for your patch!
>
> > --- a/Documentation/devicetree/bindings/pinctrl/renesas,rzg2l-pinctrl.yaml
> > +++ b/Documentation/devicetree/bindings/pinctrl/renesas,rzg2l-pinctrl.yaml
> > @@ -119,6 +119,9 @@ additionalProperties:
> >          bias-disable: true
> >          bias-pull-down: true
> >          bias-pull-up: true
> > +        input-schmitt-enable: true
> > +        input-schmitt-disable: true
> > +        drive-open-drain: true
>
> I think you also need "drive-push-pull", to disable open drain.
>
Agreed, I will add support for it and send a v2.

Cheers,
Prabhakar

> >          renesas,output-impedance:
> >            description:
> >              Output impedance for pins on the RZ/V2H(P) SoC. The value provided by this
>
> Gr{oetje,eeting}s,
>
>                         Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/pinctrl/renesas,rzg2l-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/renesas,rzg2l-pinctrl.yaml
index 56d90c8e1fa3..745794597e93 100644
--- a/Documentation/devicetree/bindings/pinctrl/renesas,rzg2l-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/renesas,rzg2l-pinctrl.yaml
@@ -119,6 +119,9 @@  additionalProperties:
         bias-disable: true
         bias-pull-down: true
         bias-pull-up: true
+        input-schmitt-enable: true
+        input-schmitt-disable: true
+        drive-open-drain: true
         renesas,output-impedance:
           description:
             Output impedance for pins on the RZ/V2H(P) SoC. The value provided by this