| Message ID | 20240924021426.1980-1-bajing@cmss.chinamobile.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 12833a732346dcf4e3bde55d6556fedf90743656 |
| Headers | show |
| Series | [v2] selftests/damon/access_memory_even: remove unused variables | expand |
Hi Ba, Thank you for revising this patch following my comment. On Tue, 24 Sep 2024 10:14:26 +0800 Ba Jing <bajing@cmss.chinamobile.com> wrote: > By reading the code, I found these variables are never > referenced in the code. Just remove them. > > Signed-off-by: Ba Jing <bajing@cmss.chinamobile.com> Reviewed-by: SeongJae Park <sj@kernel.org> Thanks, SJ > --- > Notes: > v1: https://lore.kernel.org/all/20240903034300.10443-1-bajing@cmss.chinamobile.com/ > > v2: Modify the commit subject and commit log. > > tools/testing/selftests/damon/access_memory_even.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/tools/testing/selftests/damon/access_memory_even.c b/tools/testing/selftests/damon/access_memory_even.c > index 3be121487432..a9f4e9aaf3a9 100644 > --- a/tools/testing/selftests/damon/access_memory_even.c > +++ b/tools/testing/selftests/damon/access_memory_even.c > @@ -14,10 +14,8 @@ > int main(int argc, char *argv[]) > { > char **regions; > - clock_t start_clock; > int nr_regions; > int sz_region; > - int access_time_ms; > int i; > > if (argc != 3) { > -- > 2.33.0
On 9/24/24 07:44, Ba Jing wrote: > By reading the code, I found these variables are never > referenced in the code. Just remove them. > > Signed-off-by: Ba Jing <bajing@cmss.chinamobile.com> Reviewed-by: Dev Jain <dev.jain@arm.com>
On 9/23/24 20:14, Ba Jing wrote: > By reading the code, I found these variables are never > referenced in the code. Just remove them. > > Signed-off-by: Ba Jing <bajing@cmss.chinamobile.com> > --- > Notes: > v1: https://lore.kernel.org/all/20240903034300.10443-1-bajing@cmss.chinamobile.com/ > > v2: Modify the commit subject and commit log. Thank you. Reviewed-by: Shuah Khan <skhan@linuxfoundation.org> thanks, -- Shuah
From: sj@kernel.org On Mon, 23 Sep 2024 21:08:45 -0700 SeongJae Park <sj@kernel.org> wrote: > Hi Ba, > > > Thank you for revising this patch following my comment. > > On Tue, 24 Sep 2024 10:14:26 +0800 Ba Jing <bajing@cmss.chinamobile.com> wrote: > > > By reading the code, I found these variables are never > > referenced in the code. Just remove them. > > > > Signed-off-by: Ba Jing <bajing@cmss.chinamobile.com> > > Reviewed-by: SeongJae Park <sj@kernel.org> Andrew, could you please add this patch to relevant mm trees? Thanks, SJ [...]
diff --git a/tools/testing/selftests/damon/access_memory_even.c b/tools/testing/selftests/damon/access_memory_even.c index 3be121487432..a9f4e9aaf3a9 100644 --- a/tools/testing/selftests/damon/access_memory_even.c +++ b/tools/testing/selftests/damon/access_memory_even.c @@ -14,10 +14,8 @@ int main(int argc, char *argv[]) { char **regions; - clock_t start_clock; int nr_regions; int sz_region; - int access_time_ms; int i; if (argc != 3) {
By reading the code, I found these variables are never referenced in the code. Just remove them. Signed-off-by: Ba Jing <bajing@cmss.chinamobile.com> --- Notes: v1: https://lore.kernel.org/all/20240903034300.10443-1-bajing@cmss.chinamobile.com/ v2: Modify the commit subject and commit log. tools/testing/selftests/damon/access_memory_even.c | 2 -- 1 file changed, 2 deletions(-)