| Message ID | 20240829175639.6478-1-gjoyce@linux.ibm.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | add ioctl IOC_OPAL_SET_SID_PW | expand |
It's been about a month with no comments. Does anyone have any feedback on this patchset? Thanks, Greg On Thu, 2024-08-29 at 12:56 -0500, gjoyce@linux.ibm.com wrote: > From: Greg Joyce <gjoyce@linux.ibm.com> > > This version does not reflect any code changes since there have > been no comments on the patchset since the original submission > on 13 Aug 2024. > > As requersted, it does contain an expanded description of the > patchset and a pointer to the CLI change. Thanks > to Daniel Wagner and Michal Suchánek for the feedback. > > SED Opal allows a password for the SID user as well as the Admin1 > user. If a CLI wishes to change the password of both users there > is currently no way to accomplish that using the SED Opal block > driver ioctls. The Admin1 password can be changes using the > IOC_OPAL_SET_PW ioctl but the SID password remains the password > that was set when the SED drive was provisioned (ownership). > > To allow a CLI to change the SID password, a new ioctl > IOC_OPAL_SET_SID_PW has been created. The valid current password is > required to change the SID password. > > The nvme-cli has been changed to use this ioctl such that the > "sed password" can change both the Admin1 and SID passwords. > The pull request can be found here: > https://github.com/linux-nvme/nvme-cli/pull/2467 > > Greg Joyce (1): > block: sed-opal: add ioctl IOC_OPAL_SET_SID_PW > > block/sed-opal.c | 26 ++++++++++++++++++++++++++ > include/linux/sed-opal.h | 1 + > include/uapi/linux/sed-opal.h | 1 + > 3 files changed, 28 insertions(+) >
On Thu, 29 Aug 2024 12:56:10 -0500, gjoyce@linux.ibm.com wrote: > This version does not reflect any code changes since there have > been no comments on the patchset since the original submission > on 13 Aug 2024. > > As requersted, it does contain an expanded description of the > patchset and a pointer to the CLI change. Thanks > to Daniel Wagner and Michal Suchánek for the feedback. > > [...] Applied, thanks! [1/1] block: sed-opal: add ioctl IOC_OPAL_SET_SID_PW commit: 010194b33241ca05a0ccc952dcb94f89f68b9846 Best regards,
From: Greg Joyce <gjoyce@linux.ibm.com> This version does not reflect any code changes since there have been no comments on the patchset since the original submission on 13 Aug 2024. As requersted, it does contain an expanded description of the patchset and a pointer to the CLI change. Thanks to Daniel Wagner and Michal Suchánek for the feedback. SED Opal allows a password for the SID user as well as the Admin1 user. If a CLI wishes to change the password of both users there is currently no way to accomplish that using the SED Opal block driver ioctls. The Admin1 password can be changes using the IOC_OPAL_SET_PW ioctl but the SID password remains the password that was set when the SED drive was provisioned (ownership). To allow a CLI to change the SID password, a new ioctl IOC_OPAL_SET_SID_PW has been created. The valid current password is required to change the SID password. The nvme-cli has been changed to use this ioctl such that the "sed password" can change both the Admin1 and SID passwords. The pull request can be found here: https://github.com/linux-nvme/nvme-cli/pull/2467 Greg Joyce (1): block: sed-opal: add ioctl IOC_OPAL_SET_SID_PW block/sed-opal.c | 26 ++++++++++++++++++++++++++ include/linux/sed-opal.h | 1 + include/uapi/linux/sed-opal.h | 1 + 3 files changed, 28 insertions(+)