| Message ID | 20240925-selftests-gitignore-v2-1-bbbbdef21959@gmail.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | selftsets: gitignore and clean target file additions | expand |
On 9/25/24 06:23, Javier Carrasco wrote: > These executables are missing from their corresponding gitignore files. > Add them to the lists. > > Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com> > --- > tools/testing/selftests/core/.gitignore | 1 + > tools/testing/selftests/net/.gitignore | 1 + > 2 files changed, 2 insertions(+) > Can you split these into two patches. It will be easier for the net patch to go through the net tree. I take the core changes through my tree. net changes go through net tree. Also helps avoid any future merge conflicts if new tests get added to net > diff --git a/tools/testing/selftests/core/.gitignore b/tools/testing/selftests/core/.gitignore > index 6e6712ce5817..7999361992aa 100644 > --- a/tools/testing/selftests/core/.gitignore > +++ b/tools/testing/selftests/core/.gitignore > @@ -1 +1,2 @@ > close_range_test > +unshare_test > diff --git a/tools/testing/selftests/net/.gitignore b/tools/testing/selftests/net/.gitignore > index 1c04c780db66..9dcdff533414 100644 > --- a/tools/testing/selftests/net/.gitignore > +++ b/tools/testing/selftests/net/.gitignore > @@ -17,6 +17,7 @@ ipv6_flowlabel > ipv6_flowlabel_mgr > log.txt > msg_zerocopy > +msg_oob > ncdevmem > nettest > psock_fanout > thanks, -- Shuah
On 9/25/24 18:41, Shuah Khan wrote: > On 9/25/24 06:23, Javier Carrasco wrote: >> These executables are missing from their corresponding gitignore files. >> Add them to the lists. >> >> Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com> >> --- >> tools/testing/selftests/core/.gitignore | 1 + >> tools/testing/selftests/net/.gitignore | 1 + >> 2 files changed, 2 insertions(+) >> > > Can you split these into two patches. It will be easier > for the net patch to go through the net tree. > > I take the core changes through my tree. net changes go > through net tree. @Javier, while at the above, please split the changes in two separate series: one for core and one for net. It will additionally simplify the patch handling, thanks! Paolo
On 26/09/2024 11:32, Paolo Abeni wrote: > On 9/25/24 18:41, Shuah Khan wrote: >> On 9/25/24 06:23, Javier Carrasco wrote: >>> These executables are missing from their corresponding gitignore files. >>> Add them to the lists. >>> >>> Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com> >>> --- >>> tools/testing/selftests/core/.gitignore | 1 + >>> tools/testing/selftests/net/.gitignore | 1 + >>> 2 files changed, 2 insertions(+) >>> >> >> Can you split these into two patches. It will be easier >> for the net patch to go through the net tree. >> >> I take the core changes through my tree. net changes go >> through net tree. > > @Javier, while at the above, please split the changes in two separate > series: one for core and one for net. It will additionally simplify the > patch handling, thanks! > > Paolo > Hi Paolo, as I have already sent a v3 where I split this patch, I will send a new series with the patches under selftests/net from that v3: selftests: net: add msg_oob to gitignore selftests: net: rds: add include.sh to EXTRA_CLEAN selftests: net: rds: add gitignore file for include.sh Best regards, Javier Carrasco
diff --git a/tools/testing/selftests/core/.gitignore b/tools/testing/selftests/core/.gitignore index 6e6712ce5817..7999361992aa 100644 --- a/tools/testing/selftests/core/.gitignore +++ b/tools/testing/selftests/core/.gitignore @@ -1 +1,2 @@ close_range_test +unshare_test diff --git a/tools/testing/selftests/net/.gitignore b/tools/testing/selftests/net/.gitignore index 1c04c780db66..9dcdff533414 100644 --- a/tools/testing/selftests/net/.gitignore +++ b/tools/testing/selftests/net/.gitignore @@ -17,6 +17,7 @@ ipv6_flowlabel ipv6_flowlabel_mgr log.txt msg_zerocopy +msg_oob ncdevmem nettest psock_fanout
These executables are missing from their corresponding gitignore files. Add them to the lists. Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com> --- tools/testing/selftests/core/.gitignore | 1 + tools/testing/selftests/net/.gitignore | 1 + 2 files changed, 2 insertions(+)