diff mbox series

[v1] ARM: dts: aspeed: yosemite4: correct the compatible string of adm1272

Message ID 20240926013411.3701546-1-Delphine_CC_Chiu@wiwynn.com (mailing list archive)
State New, archived
Headers show
Series [v1] ARM: dts: aspeed: yosemite4: correct the compatible string of adm1272 | expand

Commit Message

Delphine CC Chiu Sept. 26, 2024, 1:34 a.m. UTC 
From: Ricky CX Wu <ricky.cx.wu.wiwynn@gmail.com>

Remove the redundant space in the compatible string of adm1272.

Signed-off-by: Ricky CX Wu <ricky.cx.wu.wiwynn@gmail.com>
Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@wiwynn.com>
---
 arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Andrew Jeffery Sept. 27, 2024, 6 a.m. UTC | #1 
On Thu, 2024-09-26 at 09:34 +0800, Delphine CC Chiu wrote:
> From: Ricky CX Wu <ricky.cx.wu.wiwynn@gmail.com>
> 
> Remove the redundant space in the compatible string of adm1272.

In this case the space is not redundant, it's just incorrect, the
compatible string doesn't match any specified. Do you mind fixing the
wording?

> 
> Signed-off-by: Ricky CX Wu <ricky.cx.wu.wiwynn@gmail.com>
> Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@wiwynn.com>

Can you please add an appropriate Fixes: tag?

Thanks,

Andrew

> ---
>  arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts
> index 98477792aa00..7ed76cd4fd2d 100644
> --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts
> +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts
> @@ -284,12 +284,12 @@ &i2c10 {
>  &i2c11 {
>  	status = "okay";
>  	power-sensor@10 {
> -		compatible = "adi, adm1272";
> +		compatible = "adi,adm1272";
>  		reg = <0x10>;
>  	};
>  
>  	power-sensor@12 {
> -		compatible = "adi, adm1272";
> +		compatible = "adi,adm1272";
>  		reg = <0x12>;
>  	};
>
Delphine CC Chiu Sept. 27, 2024, 6:21 a.m. UTC | #2 
> -----Original Message-----
> From: Andrew Jeffery <andrew@codeconstruct.com.au>
> Sent: Friday, September 27, 2024 2:01 PM
> To: Delphine_CC_Chiu/WYHQ/Wiwynn <Delphine_CC_Chiu@wiwynn.com>;
> patrick@stwcx.xyz; Rob Herring <robh@kernel.org>; Krzysztof Kozlowski
> <krzk+dt@kernel.org>; Conor Dooley <conor+dt@kernel.org>; Joel Stanley
> <joel@jms.id.au>
> Cc: Ricky CX Wu <ricky.cx.wu.wiwynn@gmail.com>;
> devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org;
> linux-aspeed@lists.ozlabs.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH v1] ARM: dts: aspeed: yosemite4: correct the compatible
> string of adm1272
> 
>  [External Sender]
> 
>  [External Sender]
> 
> On Thu, 2024-09-26 at 09:34 +0800, Delphine CC Chiu wrote:
> > From: Ricky CX Wu <ricky.cx.wu.wiwynn@gmail.com>
> >
> > Remove the redundant space in the compatible string of adm1272.
> 
> In this case the space is not redundant, it's just incorrect, the compatible string
> doesn't match any specified. Do you mind fixing the wording?
> 
Sure, I'll fixing the wording in v2.

> >
> > Signed-off-by: Ricky CX Wu <ricky.cx.wu.wiwynn@gmail.com>
> > Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@wiwynn.com>
> 
> Can you please add an appropriate Fixes: tag?
> 
> Thanks,
> 
> Andrew
> 
Would like to ask where should I add the Fixes: tag?
Should I add in the patch title like:
Fixes: ARM: dts: aspeed: yosemite4: correct the compatible string of adm1272

Or should I add in the commit message?
Andrew Jeffery Sept. 27, 2024, 6:28 a.m. UTC | #3 
On Fri, 2024-09-27 at 06:21 +0000, Delphine_CC_Chiu/WYHQ/Wiwynn wrote:
> 
> > -----Original Message-----
> > From: Andrew Jeffery <andrew@codeconstruct.com.au>
> > Sent: Friday, September 27, 2024 2:01 PM
> > To: Delphine_CC_Chiu/WYHQ/Wiwynn <Delphine_CC_Chiu@wiwynn.com>;
> > patrick@stwcx.xyz; Rob Herring <robh@kernel.org>; Krzysztof Kozlowski
> > <krzk+dt@kernel.org>; Conor Dooley <conor+dt@kernel.org>; Joel Stanley
> > <joel@jms.id.au>
> > Cc: Ricky CX Wu <ricky.cx.wu.wiwynn@gmail.com>;
> > devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org;
> > linux-aspeed@lists.ozlabs.org; linux-kernel@vger.kernel.org
> > Subject: Re: [PATCH v1] ARM: dts: aspeed: yosemite4: correct the compatible
> > string of adm1272
> > 
> >  [External Sender]
> > 
> >  [External Sender]
> > 
> > On Thu, 2024-09-26 at 09:34 +0800, Delphine CC Chiu wrote:
> > > From: Ricky CX Wu <ricky.cx.wu.wiwynn@gmail.com>
> > > 
> > > Remove the redundant space in the compatible string of adm1272.
> > 
> > In this case the space is not redundant, it's just incorrect, the compatible string
> > doesn't match any specified. Do you mind fixing the wording?
> > 
> Sure, I'll fixing the wording in v2.

Thanks.

> 
> > > 
> > > Signed-off-by: Ricky CX Wu <ricky.cx.wu.wiwynn@gmail.com>
> > > Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@wiwynn.com>
> > 
> > Can you please add an appropriate Fixes: tag?
> > 
> > Thanks,
> > 
> > Andrew
> > 
> Would like to ask where should I add the Fixes: tag?
> Should I add in the patch title like:
> Fixes: ARM: dts: aspeed: yosemite4: correct the compatible string of adm1272
> 
> Or should I add in the commit message?

It goes in the trailer block above your Signed-off-by tag. It will be
worth your time to review the following documentation:

- https://docs.kernel.org/process/5.Posting.html#patch-formatting-and-changelogs
- https://docs.kernel.org/process/submitting-patches.html#describe-your-changes

The expected format and other details are described there.

Thanks,

Andrew
Ricky CX Wu/WYHQ/Wiwynn Sept. 27, 2024, 7:22 a.m. UTC | #4 
> -----Original Message-----
> From: Andrew Jeffery <andrew@codeconstruct.com.au>
> Sent: Friday, September 27, 2024 2:29 PM
> To: Delphine_CC_Chiu/WYHQ/Wiwynn <Delphine_CC_Chiu@wiwynn.com>;
> patrick@stwcx.xyz; Rob Herring <robh@kernel.org>; Krzysztof Kozlowski
> <krzk+dt@kernel.org>; Conor Dooley <conor+dt@kernel.org>; Joel Stanley
> <joel@jms.id.au>
> Cc: Ricky CX Wu <ricky.cx.wu.wiwynn@gmail.com>;
> devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org;
> linux-aspeed@lists.ozlabs.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH v1] ARM: dts: aspeed: yosemite4: correct the compatible
> string of adm1272
>
>  [External Sender]
>
>  [External Sender]
>
> On Fri, 2024-09-27 at 06:21 +0000, Delphine_CC_Chiu/WYHQ/Wiwynn wrote:
> >
> > > -----Original Message-----
> > > From: Andrew Jeffery <andrew@codeconstruct.com.au>
> > > Sent: Friday, September 27, 2024 2:01 PM
> > > To: Delphine_CC_Chiu/WYHQ/Wiwynn
> <Delphine_CC_Chiu@wiwynn.com>;
> > > patrick@stwcx.xyz; Rob Herring <robh@kernel.org>; Krzysztof
> > > Kozlowski <krzk+dt@kernel.org>; Conor Dooley <conor+dt@kernel.org>;
> > > Joel Stanley <joel@jms.id.au>
> > > Cc: Ricky CX Wu <ricky.cx.wu.wiwynn@gmail.com>;
> > > devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org;
> > > linux-aspeed@lists.ozlabs.org; linux-kernel@vger.kernel.org
> > > Subject: Re: [PATCH v1] ARM: dts: aspeed: yosemite4: correct the
> > > compatible string of adm1272
> > >
> > >  [External Sender]
> > >
> > >  [External Sender]
> > >
> > > On Thu, 2024-09-26 at 09:34 +0800, Delphine CC Chiu wrote:
> > > > From: Ricky CX Wu <ricky.cx.wu.wiwynn@gmail.com>
> > > >
> > > > Remove the redundant space in the compatible string of adm1272.
> > >
> > > In this case the space is not redundant, it's just incorrect, the
> > > compatible string doesn't match any specified. Do you mind fixing the
> wording?
> > >
> > Sure, I'll fixing the wording in v2.
>
> Thanks.
>
> >
> > > >
> > > > Signed-off-by: Ricky CX Wu <ricky.cx.wu.wiwynn@gmail.com>
> > > > Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@wiwynn.com>
> > >
> > > Can you please add an appropriate Fixes: tag?
> > >
> > > Thanks,
> > >
> > > Andrew
> > >
> > Would like to ask where should I add the Fixes: tag?
> > Should I add in the patch title like:
> > Fixes: ARM: dts: aspeed: yosemite4: correct the compatible string of
> > adm1272
> >
> > Or should I add in the commit message?
>
> It goes in the trailer block above your Signed-off-by tag. It will be worth your
> time to review the following documentation:
>
> -
> https://urldefense.com/v3/__https://docs.kernel.org/process/5.Posting.html*p
> atch-formatting-and-changelogs__;Iw!!J63qqgXj!LdpKTr36YV5e4cCRly5lII5iCF
> m9zsnavi_vRueNWvNHGQ8SimCf-YfL14fxXTRL3Fxnkmid4VLDlGSY_GxdXBhSTrA
> $
> -
> https://urldefense.com/v3/__https://docs.kernel.org/process/submitting-patch
> es.html*describe-your-changes__;Iw!!J63qqgXj!LdpKTr36YV5e4cCRly5lII5iCFm
> 9zsnavi_vRueNWvNHGQ8SimCf-YfL14fxXTRL3Fxnkmid4VLDlGSY_Gxd0pKAYmU
> $
>
> The expected format and other details are described there.
>
> Thanks,
>
> Andrew

WIWYNN PROPRIETARY
This email (and any attachments) contains proprietary or confidential information and is for the sole use of its intended recipient. Any unauthorized review, use, copying or distribution of this email or the content of this email is strictly prohibited. If you are not the intended recipient, please notify the sender and delete this email immediately.
Delphine CC Chiu Sept. 27, 2024, 7:23 a.m. UTC | #5 
> -----Original Message-----
> From: Andrew Jeffery <andrew@codeconstruct.com.au>
> Sent: Friday, September 27, 2024 2:29 PM
> To: Delphine_CC_Chiu/WYHQ/Wiwynn <Delphine_CC_Chiu@wiwynn.com>;
> patrick@stwcx.xyz; Rob Herring <robh@kernel.org>; Krzysztof Kozlowski
> <krzk+dt@kernel.org>; Conor Dooley <conor+dt@kernel.org>; Joel Stanley
> <joel@jms.id.au>
> Cc: Ricky CX Wu <ricky.cx.wu.wiwynn@gmail.com>;
> devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org;
> linux-aspeed@lists.ozlabs.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH v1] ARM: dts: aspeed: yosemite4: correct the compatible
> string of adm1272
> 
>  [External Sender]
> 
>  [External Sender]
> 
> On Fri, 2024-09-27 at 06:21 +0000, Delphine_CC_Chiu/WYHQ/Wiwynn wrote:
> >
> > > -----Original Message-----
> > > From: Andrew Jeffery <andrew@codeconstruct.com.au>
> > > Sent: Friday, September 27, 2024 2:01 PM
> > > To: Delphine_CC_Chiu/WYHQ/Wiwynn
> <Delphine_CC_Chiu@wiwynn.com>;
> > > patrick@stwcx.xyz; Rob Herring <robh@kernel.org>; Krzysztof
> > > Kozlowski <krzk+dt@kernel.org>; Conor Dooley <conor+dt@kernel.org>;
> > > Joel Stanley <joel@jms.id.au>
> > > Cc: Ricky CX Wu <ricky.cx.wu.wiwynn@gmail.com>;
> > > devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org;
> > > linux-aspeed@lists.ozlabs.org; linux-kernel@vger.kernel.org
> > > Subject: Re: [PATCH v1] ARM: dts: aspeed: yosemite4: correct the
> > > compatible string of adm1272
> > >
> > >  [External Sender]
> > >
> > >  [External Sender]
> > >
> > > On Thu, 2024-09-26 at 09:34 +0800, Delphine CC Chiu wrote:
> > > > From: Ricky CX Wu <ricky.cx.wu.wiwynn@gmail.com>
> > > >
> > > > Remove the redundant space in the compatible string of adm1272.
> > >
> > > In this case the space is not redundant, it's just incorrect, the
> > > compatible string doesn't match any specified. Do you mind fixing the
> wording?
> > >
> > Sure, I'll fixing the wording in v2.
> 
> Thanks.
> 
> >
> > > >
> > > > Signed-off-by: Ricky CX Wu <ricky.cx.wu.wiwynn@gmail.com>
> > > > Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@wiwynn.com>
> > >
> > > Can you please add an appropriate Fixes: tag?
> > >
> > > Thanks,
> > >
> > > Andrew
> > >
> > Would like to ask where should I add the Fixes: tag?
> > Should I add in the patch title like:
> > Fixes: ARM: dts: aspeed: yosemite4: correct the compatible string of
> > adm1272
> >
> > Or should I add in the commit message?
> 
> It goes in the trailer block above your Signed-off-by tag. It will be worth your
> time to review the following documentation:
> 
> -
> https://urldefense.com/v3/__https://docs.kernel.org/process/5.Posting.html*p
> atch-formatting-and-changelogs__;Iw!!J63qqgXj!LdpKTr36YV5e4cCRly5lII5iCF
> m9zsnavi_vRueNWvNHGQ8SimCf-YfL14fxXTRL3Fxnkmid4VLDlGSY_GxdXBhSTrA
> $
> -
> https://urldefense.com/v3/__https://docs.kernel.org/process/submitting-patch
> es.html*describe-your-changes__;Iw!!J63qqgXj!LdpKTr36YV5e4cCRly5lII5iCFm
> 9zsnavi_vRueNWvNHGQ8SimCf-YfL14fxXTRL3Fxnkmid4VLDlGSY_Gxd0pKAYmU
> $
> 
> The expected format and other details are described there.
> 
> Thanks,
> 
> Andrew
Hi Andrew,

Thanks for your information!
I'll follow the format described in the document and send the v2 patch.

Ricky
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts
index 98477792aa00..7ed76cd4fd2d 100644
--- a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts
+++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts
@@ -284,12 +284,12 @@  &i2c10 {
 &i2c11 {
 	status = "okay";
 	power-sensor@10 {
-		compatible = "adi, adm1272";
+		compatible = "adi,adm1272";
 		reg = <0x10>;
 	};
 
 	power-sensor@12 {
-		compatible = "adi, adm1272";
+		compatible = "adi,adm1272";
 		reg = <0x12>;
 	};