| Message ID | 20240906-dev-mule-i2c-mux-v8-3-dbd28a150e41@cherry.de (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | Add tsd,mule-i2c-mux support | expand |
Hi, On 06.09.24 17:54, Farouk Bouabid wrote: > Add dt-bindings for amc6821 intelligent temperature monitor and > pulse-width modulation (PWM) fan controller. > > Reviewed-by: Rob Herring (Arm) <robh@kernel.org> > Signed-off-by: Farouk Bouabid <farouk.bouabid@cherry.de> > --- > > Notes: > Merge after patch 1 Patch 1 is merged in next-20240910 and it represents the dependency required for patches 3. I guess we should be ready to merge patches 3 and 4 through the hwmon subsystem. Thanks, Farouk
On 9/27/24 07:58, Farouk Bouabid wrote: > Hi, > > On 06.09.24 17:54, Farouk Bouabid wrote: >> Add dt-bindings for amc6821 intelligent temperature monitor and >> pulse-width modulation (PWM) fan controller. >> >> Reviewed-by: Rob Herring (Arm) <robh@kernel.org> >> Signed-off-by: Farouk Bouabid <farouk.bouabid@cherry.de> >> --- >> >> Notes: >> Merge after patch 1 > > Patch 1 is merged in next-20240910 and it represents the dependency required for patches 3. I guess we should be ready to merge patches 3 and 4 through the hwmon subsystem. > I'll do that after the commit window closes. Guenter
On Fri, Sep 06, 2024 at 05:54:14PM +0200, Farouk Bouabid wrote: > Add dt-bindings for amc6821 intelligent temperature monitor and > pulse-width modulation (PWM) fan controller. > > Reviewed-by: Rob Herring (Arm) <robh@kernel.org> > Signed-off-by: Farouk Bouabid <farouk.bouabid@cherry.de> Applied to hwmon-next. Thanks, Guenter > --- > > Notes: > Merge after patch 1 > > .../devicetree/bindings/hwmon/ti,amc6821.yaml | 86 ++++++++++++++++++++++ > .../devicetree/bindings/trivial-devices.yaml | 2 - > 2 files changed, 86 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/hwmon/ti,amc6821.yaml b/Documentation/devicetree/bindings/hwmon/ti,amc6821.yaml > new file mode 100644 > index 000000000000..5d33f1a23d03 > --- /dev/null > +++ b/Documentation/devicetree/bindings/hwmon/ti,amc6821.yaml > @@ -0,0 +1,86 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/hwmon/ti,amc6821.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: AMC6821 Intelligent Temperature Monitor and PWM Fan Controller > + > +maintainers: > + - Farouk Bouabid <farouk.bouabid@cherry.de> > + - Quentin Schulz <quentin.schulz@cherry.de> > + > +description: > + Intelligent temperature monitor and pulse-width modulation (PWM) fan > + controller. > + > +properties: > + compatible: > + oneOf: > + - items: > + - const: tsd,mule > + - const: ti,amc6821 > + - const: ti,amc6821 > + > + reg: > + maxItems: 1 > + > + i2c-mux: > + type: object > + > +required: > + - compatible > + - reg > + > +if: > + properties: > + compatible: > + contains: > + const: tsd,mule > + > +then: > + required: > + - i2c-mux > + > +additionalProperties: false > + > +examples: > + - | > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + fan@18 { > + compatible = "ti,amc6821"; > + reg = <0x18>; > + }; > + }; > + > + - | > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + fan@18 { > + compatible = "tsd,mule", "ti,amc6821"; > + reg = <0x18>; > + > + i2c-mux { > + compatible = "tsd,mule-i2c-mux"; > + #address-cells = <1>; > + #size-cells = <0>; > + > + i2c@0 { > + reg = <0x0>; > + #address-cells = <1>; > + #size-cells = <0>; > + > + rtc@6f { > + compatible = "isil,isl1208"; > + reg = <0x6f>; > + }; > + }; > + }; > + }; > + }; > +... > diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml > index 7913ca9b6b54..8ba53cc2672b 100644 > --- a/Documentation/devicetree/bindings/trivial-devices.yaml > +++ b/Documentation/devicetree/bindings/trivial-devices.yaml > @@ -370,8 +370,6 @@ properties: > - swir,mangoh-iotport-spi > # Ambient Light Sensor with SMBUS/Two Wire Serial Interface > - taos,tsl2550 > - # Temperature Monitoring and Fan Control > - - ti,amc6821 > # Temperature and humidity sensor with i2c interface > - ti,hdc1000 > # Temperature and humidity sensor with i2c interface
diff --git a/Documentation/devicetree/bindings/hwmon/ti,amc6821.yaml b/Documentation/devicetree/bindings/hwmon/ti,amc6821.yaml new file mode 100644 index 000000000000..5d33f1a23d03 --- /dev/null +++ b/Documentation/devicetree/bindings/hwmon/ti,amc6821.yaml @@ -0,0 +1,86 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/hwmon/ti,amc6821.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: AMC6821 Intelligent Temperature Monitor and PWM Fan Controller + +maintainers: + - Farouk Bouabid <farouk.bouabid@cherry.de> + - Quentin Schulz <quentin.schulz@cherry.de> + +description: + Intelligent temperature monitor and pulse-width modulation (PWM) fan + controller. + +properties: + compatible: + oneOf: + - items: + - const: tsd,mule + - const: ti,amc6821 + - const: ti,amc6821 + + reg: + maxItems: 1 + + i2c-mux: + type: object + +required: + - compatible + - reg + +if: + properties: + compatible: + contains: + const: tsd,mule + +then: + required: + - i2c-mux + +additionalProperties: false + +examples: + - | + i2c { + #address-cells = <1>; + #size-cells = <0>; + + fan@18 { + compatible = "ti,amc6821"; + reg = <0x18>; + }; + }; + + - | + i2c { + #address-cells = <1>; + #size-cells = <0>; + + fan@18 { + compatible = "tsd,mule", "ti,amc6821"; + reg = <0x18>; + + i2c-mux { + compatible = "tsd,mule-i2c-mux"; + #address-cells = <1>; + #size-cells = <0>; + + i2c@0 { + reg = <0x0>; + #address-cells = <1>; + #size-cells = <0>; + + rtc@6f { + compatible = "isil,isl1208"; + reg = <0x6f>; + }; + }; + }; + }; + }; +... diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml index 7913ca9b6b54..8ba53cc2672b 100644 --- a/Documentation/devicetree/bindings/trivial-devices.yaml +++ b/Documentation/devicetree/bindings/trivial-devices.yaml @@ -370,8 +370,6 @@ properties: - swir,mangoh-iotport-spi # Ambient Light Sensor with SMBUS/Two Wire Serial Interface - taos,tsl2550 - # Temperature Monitoring and Fan Control - - ti,amc6821 # Temperature and humidity sensor with i2c interface - ti,hdc1000 # Temperature and humidity sensor with i2c interface