| Message ID | 20240928021620.8369-9-kanchana.p.sridhar@intel.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | mm: zswap swap-out of large folios | expand |
On Fri, Sep 27, 2024 at 7:16 PM Kanchana P Sridhar <kanchana.p.sridhar@intel.com> wrote: > > Added documentation for the newly added sysfs per-order hugepage > "zswpout" stats. > > Clarified that only non-zswap swapouts will be accounted in the existing > "swpout" stats. > > Signed-off-by: Kanchana P Sridhar <kanchana.p.sridhar@intel.com> LGTM. Reviewed-by: Nhat Pham <nphamcs@gmail.com> I think you can squash this to the last commit (i.e adding the new stats and the documentation for that stats at the same time). But no strong opinions :)
> -----Original Message----- > From: Nhat Pham <nphamcs@gmail.com> > Sent: Sunday, September 29, 2024 3:35 PM > To: Sridhar, Kanchana P <kanchana.p.sridhar@intel.com> > Cc: linux-kernel@vger.kernel.org; linux-mm@kvack.org; > hannes@cmpxchg.org; yosryahmed@google.com; > chengming.zhou@linux.dev; usamaarif642@gmail.com; > shakeel.butt@linux.dev; ryan.roberts@arm.com; Huang, Ying > <ying.huang@intel.com>; 21cnbao@gmail.com; akpm@linux-foundation.org; > Zou, Nanhai <nanhai.zou@intel.com>; Feghali, Wajdi K > <wajdi.k.feghali@intel.com>; Gopal, Vinodh <vinodh.gopal@intel.com> > Subject: Re: [PATCH v8 8/8] mm: Document the newly added sysfs large folios > zswpout stats. > > On Fri, Sep 27, 2024 at 7:16 PM Kanchana P Sridhar > <kanchana.p.sridhar@intel.com> wrote: > > > > Added documentation for the newly added sysfs per-order hugepage > > "zswpout" stats. > > > > Clarified that only non-zswap swapouts will be accounted in the existing > > "swpout" stats. > > > > Signed-off-by: Kanchana P Sridhar <kanchana.p.sridhar@intel.com> > > LGTM. > Reviewed-by: Nhat Pham <nphamcs@gmail.com> > > I think you can squash this to the last commit (i.e adding the new > stats and the documentation for that stats at the same time). But no > strong opinions :) Sure this sounds good, Nhat! Thanks, Kanchana
diff --git a/Documentation/admin-guide/mm/transhuge.rst b/Documentation/admin-guide/mm/transhuge.rst index cfdd16a52e39..2a171ed5206e 100644 --- a/Documentation/admin-guide/mm/transhuge.rst +++ b/Documentation/admin-guide/mm/transhuge.rst @@ -530,10 +530,14 @@ anon_fault_fallback_charge instead falls back to using huge pages with lower orders or small pages even though the allocation was successful. -swpout - is incremented every time a huge page is swapped out in one +zswpout + is incremented every time a huge page is swapped out to zswap in one piece without splitting. +swpout + is incremented every time a huge page is swapped out to a non-zswap + swap device in one piece without splitting. + swpout_fallback is incremented if a huge page has to be split before swapout. Usually because failed to allocate some continuous swap space
Added documentation for the newly added sysfs per-order hugepage "zswpout" stats. Clarified that only non-zswap swapouts will be accounted in the existing "swpout" stats. Signed-off-by: Kanchana P Sridhar <kanchana.p.sridhar@intel.com> --- Documentation/admin-guide/mm/transhuge.rst | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-)