diff mbox series

[2/4] ARM: dts: renesas: genmai: use interrupts-extended for gpio-keys

Message ID 20240927095414.10241-8-wsa+renesas@sang-engineering.com (mailing list archive)
State Under Review
Delegated to: Geert Uytterhoeven
Headers show
Series ARM: dts: renesas: use interrupts-extended for gpio-keys | expand

Commit Message

Wolfram Sang Sept. 27, 2024, 9:54 a.m. UTC
Use the more concise interrupts-extended property to fully describe the
interrupt.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
 arch/arm/boot/dts/renesas/r7s72100-genmai.dts | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Krzysztof Kozlowski Sept. 27, 2024, 12:29 p.m. UTC | #1
On 27/09/2024 11:54, Wolfram Sang wrote:
> Use the more concise interrupts-extended property to fully describe the
> interrupt.
> 
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
>  arch/arm/boot/dts/renesas/r7s72100-genmai.dts | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 

Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>

Best regards,
Krzysztof
Geert Uytterhoeven Sept. 30, 2024, 2:29 p.m. UTC | #2
Hi Wolfram,

On Fri, Sep 27, 2024 at 11:54 AM Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
> Use the more concise interrupts-extended property to fully describe the
> interrupt.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

> --- a/arch/arm/boot/dts/renesas/r7s72100-genmai.dts
> +++ b/arch/arm/boot/dts/renesas/r7s72100-genmai.dts
> @@ -67,8 +67,7 @@ keyboard {
>
>                 key-1 {
>                         /* JP3 must be set to 1-2 (default) */
> -                       interrupt-parent = <&irqc>;
> -                       interrupts = <6 IRQ_TYPE_EDGE_BOTH>;
> +                       interrupts-extended = <&irqc 6 IRQ_TYPE_EDGE_BOTH>;
>                         linux,code = <KEY_1>;
>                         label = "SW6,SW7";
>                         wakeup-source;

Given the changed code was introduced only very recently, I will fold this
into "ARM: dts: renesas: genmai: Define keyboard switch".

Gr{oetje,eeting}s,

                        Geert
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/renesas/r7s72100-genmai.dts b/arch/arm/boot/dts/renesas/r7s72100-genmai.dts
index d0b2b4ea1734..e3fb54616537 100644
--- a/arch/arm/boot/dts/renesas/r7s72100-genmai.dts
+++ b/arch/arm/boot/dts/renesas/r7s72100-genmai.dts
@@ -67,8 +67,7 @@  keyboard {
 
 		key-1 {
 			/* JP3 must be set to 1-2 (default) */
-			interrupt-parent = <&irqc>;
-			interrupts = <6 IRQ_TYPE_EDGE_BOTH>;
+			interrupts-extended = <&irqc 6 IRQ_TYPE_EDGE_BOTH>;
 			linux,code = <KEY_1>;
 			label = "SW6,SW7";
 			wakeup-source;