| Message ID | 20240927095414.10241-9-wsa+renesas@sang-engineering.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | b630352660cd1377364d21c643b1bd8d972537f6 |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
| Series | ARM: dts: renesas: use interrupts-extended for gpio-keys | expand |
On 27/09/2024 11:54, Wolfram Sang wrote: > Use the more concise interrupts-extended property to fully describe the > interrupt. > > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> > --- The code is correct, but are you sure this is not just a churn? Best regards, Krzysztof
On Fri, Sep 27, 2024 at 11:54 AM Wolfram Sang <wsa+renesas@sang-engineering.com> wrote: > Use the more concise interrupts-extended property to fully describe the > interrupt. > > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> i.e. will queue in renesas-devel for v6.13. Gr{oetje,eeting}s, Geert
> The code is correct, but are you sure this is not just a churn?
A little, but I prefer the consistency among Renesas boards here.
diff --git a/arch/arm/boot/dts/renesas/r7s72100-rskrza1.dts b/arch/arm/boot/dts/renesas/r7s72100-rskrza1.dts index b547216d4801..9ff3f04c1b02 100644 --- a/arch/arm/boot/dts/renesas/r7s72100-rskrza1.dts +++ b/arch/arm/boot/dts/renesas/r7s72100-rskrza1.dts @@ -78,24 +78,21 @@ keyboard { pinctrl-0 = <&keyboard_pins>; key-1 { - interrupt-parent = <&irqc>; - interrupts = <3 IRQ_TYPE_EDGE_BOTH>; + interrupts-extended = <&irqc 3 IRQ_TYPE_EDGE_BOTH>; linux,code = <KEY_1>; label = "SW1"; wakeup-source; }; key-2 { - interrupt-parent = <&irqc>; - interrupts = <2 IRQ_TYPE_EDGE_BOTH>; + interrupts-extended = <&irqc 2 IRQ_TYPE_EDGE_BOTH>; linux,code = <KEY_2>; label = "SW2"; wakeup-source; }; key-3 { - interrupt-parent = <&irqc>; - interrupts = <5 IRQ_TYPE_EDGE_BOTH>; + interrupts-extended = <&irqc 5 IRQ_TYPE_EDGE_BOTH>; linux,code = <KEY_3>; label = "SW3"; wakeup-source;
Use the more concise interrupts-extended property to fully describe the interrupt. Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> --- arch/arm/boot/dts/renesas/r7s72100-rskrza1.dts | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-)