| Message ID | 87jzephowk.wl-kuninori.morimoto.gx@renesas.com (mailing list archive) |
|---|---|
| State | New |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
| Series | dt-bindings: memory: renesas,rpc-if: Document R-Car S4-8 support | expand |
On Thu, Oct 03, 2024 at 02:59:55AM +0000, Kuninori Morimoto wrote: > Document Renesas RPC-IF for R-Car S4-8 (R8A779F0) SoC, which is > compatible with R-Car Gen4 SoC family. > > Signed-off-by: Vinh Nguyen <vinh.nguyen.xz@renesas.com> > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> Of course, we can always have the binding. But there is no node in the upstream S8 DTSI file because we were explicitly asked to *not* upstream RPC support for S8. I can't sadly find the mail anymore, but BSP commit 92e6619c6bdd ("arm64: dts: renesas: spider-cpu: Disable SPI flash via RPC") says that RPC access is handled by OP-TEE on that SoC.
On 03/10/2024 04:59, Kuninori Morimoto wrote: > Document Renesas RPC-IF for R-Car S4-8 (R8A779F0) SoC, which is > compatible with R-Car Gen4 SoC family. > > Signed-off-by: Vinh Nguyen <vinh.nguyen.xz@renesas.com> > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> > --- > .../devicetree/bindings/memory-controllers/renesas,rpc-if.yaml | 1 + So you skipped multiple maintainers and multiple subsystems... <form letter> Please use scripts/get_maintainers.pl to get a list of necessary people and lists to CC. It might happen, that command when run on an older kernel, gives you outdated entries. Therefore please be sure you base your patches on recent Linux kernel. Tools like b4 or scripts/get_maintainer.pl provide you proper list of people, so fix your workflow. Tools might also fail if you work on some ancient tree (don't, instead use mainline) or work on fork of kernel (don't, instead use mainline). Just use b4 and everything should be fine, although remember about `b4 prep --auto-to-cc` if you added new patches to the patchset. You missed at least devicetree list (maybe more), so this won't be tested by automated tooling. Performing review on untested code might be a waste of time. Please kindly resend and include all necessary To/Cc entries. </form letter> Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/memory-controllers/renesas,rpc-if.yaml b/Documentation/devicetree/bindings/memory-controllers/renesas,rpc-if.yaml index 4f4bc953e31a..b6215d86b9d3 100644 --- a/Documentation/devicetree/bindings/memory-controllers/renesas,rpc-if.yaml +++ b/Documentation/devicetree/bindings/memory-controllers/renesas,rpc-if.yaml @@ -44,6 +44,7 @@ properties: - items: - enum: + - renesas,r8a779f0-rpc-if # R-Car S4-8 - renesas,r8a779g0-rpc-if # R-Car V4H - renesas,r8a779h0-rpc-if # R-Car V4M - const: renesas,rcar-gen4-rpc-if # a generic R-Car gen4 device