| Message ID | 20241003154819.1075141-1-andriy.shevchenko@linux.intel.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | [v1,1/1] platform/x86: intel_scu_ipc: Don't use "proxy" headers | expand |
On Thu, Oct 03, 2024 at 06:48:19PM +0300, Andy Shevchenko wrote: > Update header inclusions to follow IWYU (Include What You Use) > principle. Is this some new Coding Style thing? > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Fine by me, Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
On Thu, Oct 3, 2024 at 7:03 PM Mika Westerberg <mika.westerberg@linux.intel.com> wrote: > On Thu, Oct 03, 2024 at 06:48:19PM +0300, Andy Shevchenko wrote: > > Update header inclusions to follow IWYU (Include What You Use) > > principle. > > Is this some new Coding Style thing? It's useful to unravel a tangle of the dependency hell. Yet it needs to be documented. > Fine by me, > > Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com> Thank you!
On Thu, 03 Oct 2024 18:48:19 +0300, Andy Shevchenko wrote: > Update header inclusions to follow IWYU (Include What You Use) > principle. > > Thank you for your contribution, it has been applied to my local review-ilpo branch. Note it will show up in the public platform-drivers-x86/review-ilpo branch only once I've pushed my local branch there, which might take a while. The list of commits applied: [1/1] platform/x86: intel_scu_ipc: Don't use "proxy" headers commit: 066c779b094b63754e0742ad8675d72d6c0a46f6 -- i.
diff --git a/include/linux/platform_data/x86/intel_scu_ipc.h b/include/linux/platform_data/x86/intel_scu_ipc.h index 0ca9962e97f2..b287627759f7 100644 --- a/include/linux/platform_data/x86/intel_scu_ipc.h +++ b/include/linux/platform_data/x86/intel_scu_ipc.h @@ -2,9 +2,13 @@ #ifndef __PLATFORM_X86_INTEL_SCU_IPC_H_ #define __PLATFORM_X86_INTEL_SCU_IPC_H_ +#include <linux/init.h> #include <linux/ioport.h> +#include <linux/types.h> struct device; +struct module; + struct intel_scu_ipc_dev; /**
Update header inclusions to follow IWYU (Include What You Use) principle. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- include/linux/platform_data/x86/intel_scu_ipc.h | 4 ++++ 1 file changed, 4 insertions(+)