| Message ID | 20241003220820.1345048-2-CFSworks@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Add support for Zyxel EX3510-B | expand |
On Thu, Oct 03, 2024 at 03:08:19PM -0700, Sam Edwards wrote: > This is a series (EX3510-B0 and EX3510-B1) of residential gateways based > on BCM4906, a stripped-down version of the BCM4908 SoC. Although Zyxel's > marketing materials call this a "series," the EX3510-B1 appears to be a > very minor revision of the EX3510-B0, with only changes that are > transparent to software. As far as Linux is concerned, this "series" > effectively represents a single model. > > Signed-off-by: Sam Edwards <CFSworks@gmail.com> Can you use the same email as for SoB? Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On 04/10/2024 08:49, Krzysztof Kozlowski wrote: > On Thu, Oct 03, 2024 at 03:08:19PM -0700, Sam Edwards wrote: >> This is a series (EX3510-B0 and EX3510-B1) of residential gateways based >> on BCM4906, a stripped-down version of the BCM4908 SoC. Although Zyxel's >> marketing materials call this a "series," the EX3510-B1 appears to be a >> very minor revision of the EX3510-B0, with only changes that are >> transparent to software. As far as Linux is concerned, this "series" >> effectively represents a single model. >> >> Signed-off-by: Sam Edwards <CFSworks@gmail.com> > > Can you use the same email as for SoB? I meant, same for patch author and SoB. How is even possible to generate different data? You had to change it manually, which should make you wondering if this is correct. > > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > Best regards, > Krzysztof > Best regards, Krzysztof
On Thu, Oct 3, 2024 at 11:51 PM Krzysztof Kozlowski <krzk@kernel.org> wrote: > > On 04/10/2024 08:49, Krzysztof Kozlowski wrote: > > On Thu, Oct 03, 2024 at 03:08:19PM -0700, Sam Edwards wrote: > >> This is a series (EX3510-B0 and EX3510-B1) of residential gateways based > >> on BCM4906, a stripped-down version of the BCM4908 SoC. Although Zyxel's > >> marketing materials call this a "series," the EX3510-B1 appears to be a > >> very minor revision of the EX3510-B0, with only changes that are > >> transparent to software. As far as Linux is concerned, this "series" > >> effectively represents a single model. > >> > >> Signed-off-by: Sam Edwards <CFSworks@gmail.com> Good day Krzysztof, > > > > Can you use the same email as for SoB? I have sent patches to the LKML from a work email before, but I just double-checked that I am using my personal email for everything here: $ git show ec8e6d96a05f04 | grep -E 'dt-bindings|Author|Signed' Author: Sam Edwards <CFSworks@gmail.com> dt-bindings: arm64: bcmbca: Add Zyxel EX3510-B based on BCM4906 Signed-off-by: Sam Edwards <CFSworks@gmail.com> $ grep -E '^From|^Signed' outgoing-ex3510b/0001-dt-bindings-arm64-bcmbca-Add-Zyxel-EX3510-B-based-on.patch From ec8e6d96a05f04df00d05dec00df80172d233d8c Mon Sep 17 00:00:00 2001 From: Sam Edwards <CFSworks@gmail.com> Signed-off-by: Sam Edwards <CFSworks@gmail.com> $ > I meant, same for patch author and SoB. How is even possible to generate > different data? You had to change it manually, which should make you > wondering if this is correct. Hey, on a meta level: I’d appreciate it if we could try to rule out other possibilities before jumping to conclusions. Reading this made me feel accused, and I think framing things collaboratively rather than assigning blame will make it easier for all of us. How about we start with what you’re seeing and work backwards? Wishing you well, Sam > > > > > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > > > Best regards, > > Krzysztof > > > > Best regards, > Krzysztof >
On 04/10/2024 19:21, Sam Edwards wrote: > On Thu, Oct 3, 2024 at 11:51 PM Krzysztof Kozlowski <krzk@kernel.org> wrote: >> >> On 04/10/2024 08:49, Krzysztof Kozlowski wrote: >>> On Thu, Oct 03, 2024 at 03:08:19PM -0700, Sam Edwards wrote: >>>> This is a series (EX3510-B0 and EX3510-B1) of residential gateways based >>>> on BCM4906, a stripped-down version of the BCM4908 SoC. Although Zyxel's >>>> marketing materials call this a "series," the EX3510-B1 appears to be a >>>> very minor revision of the EX3510-B0, with only changes that are >>>> transparent to software. As far as Linux is concerned, this "series" >>>> effectively represents a single model. >>>> >>>> Signed-off-by: Sam Edwards <CFSworks@gmail.com> > > Good day Krzysztof, > >>> >>> Can you use the same email as for SoB? > > I have sent patches to the LKML from a work email before, but I just That's not what I asked. You can send them from whatever, I asked that commit identity should match SoB in exact way. > double-checked that I am using my personal email for everything here: > > $ git show ec8e6d96a05f04 | grep -E 'dt-bindings|Author|Signed' > Author: Sam Edwards <CFSworks@gmail.com> > dt-bindings: arm64: bcmbca: Add Zyxel EX3510-B based on BCM4906 > Signed-off-by: Sam Edwards <CFSworks@gmail.com> > $ grep -E '^From|^Signed' > outgoing-ex3510b/0001-dt-bindings-arm64-bcmbca-Add-Zyxel-EX3510-B-based-on.patch > From ec8e6d96a05f04df00d05dec00df80172d233d8c Mon Sep 17 00:00:00 2001 > From: Sam Edwards <CFSworks@gmail.com> > Signed-off-by: Sam Edwards <CFSworks@gmail.com> So apply the patch from the mailing list and you will see: Author: Sam Edwards <cfsworks@gmail.com> Signed-off-by: Sam Edwards <CFSworks@gmail.com> Best regards, Krzysztof
On Sat, Oct 5, 2024 at 1:54 AM Krzysztof Kozlowski <krzk@kernel.org> wrote: > > On 04/10/2024 19:21, Sam Edwards wrote: > > On Thu, Oct 3, 2024 at 11:51 PM Krzysztof Kozlowski <krzk@kernel.org> wrote: > >> > >> On 04/10/2024 08:49, Krzysztof Kozlowski wrote: > >>> On Thu, Oct 03, 2024 at 03:08:19PM -0700, Sam Edwards wrote: > >>>> This is a series (EX3510-B0 and EX3510-B1) of residential gateways based > >>>> on BCM4906, a stripped-down version of the BCM4908 SoC. Although Zyxel's > >>>> marketing materials call this a "series," the EX3510-B1 appears to be a > >>>> very minor revision of the EX3510-B0, with only changes that are > >>>> transparent to software. As far as Linux is concerned, this "series" > >>>> effectively represents a single model. > >>>> > >>>> Signed-off-by: Sam Edwards <CFSworks@gmail.com> > > > > Good day Krzysztof, > > > >>> > >>> Can you use the same email as for SoB? > > > > I have sent patches to the LKML from a work email before, but I just > > That's not what I asked. You can send them from whatever, I asked that > commit identity should match SoB in exact way. > > > > double-checked that I am using my personal email for everything here: > > > > $ git show ec8e6d96a05f04 | grep -E 'dt-bindings|Author|Signed' > > Author: Sam Edwards <CFSworks@gmail.com> > > dt-bindings: arm64: bcmbca: Add Zyxel EX3510-B based on BCM4906 > > Signed-off-by: Sam Edwards <CFSworks@gmail.com> > > $ grep -E '^From|^Signed' > > outgoing-ex3510b/0001-dt-bindings-arm64-bcmbca-Add-Zyxel-EX3510-B-based-on.patch > > From ec8e6d96a05f04df00d05dec00df80172d233d8c Mon Sep 17 00:00:00 2001 > > From: Sam Edwards <CFSworks@gmail.com> > > Signed-off-by: Sam Edwards <CFSworks@gmail.com> Greetings Krzysztof, > So apply the patch from the mailing list and you will see: > > Author: Sam Edwards <cfsworks@gmail.com> > Signed-off-by: Sam Edwards <CFSworks@gmail.com> Looks fine to me, those are both set to my personal (non-work) account. The only difference I'm seeing is that the capitalization in my email address is being discarded in the author field, but in light of the case-insensitive nature of email addresses: these are an exact match. Still, I was interested to see what was affecting the capitalization in one field but not the other, so I did some digging. To answer your previous question: they can differ because they are transported in different ways. Evidently git-am considers a few headers in the email envelope significant (e.g. Subject/From/Date) by default. The envelope's "From:" is what specifies the patch author, while the Signed-off-by tag is just part of the message body. The envelope is unfortunately fair game for modification by various MTAs, which would explain why my patches aren't arriving with my 'From:' email address capitalization intact. When I have time, I'd like to look into what specific hop in the mail path is doing that. Hopefully it's something I can reconfigure, but it might also be out of my hands. Is there some other difference you're noticing that's too subtle for me to spot? Or is it indeed the capitalization that's the key issue here? If the latter, I want to understand why it's important so I can see if there’s a way to work around it, or if we need to consider other options for getting patches delivered in the preferred format in the future. COMMITTER: In light of the above, could you kindly add this flag to git-am to fix the capitalization issue: --author="Sam Edwards <CFSworks@gmail.com>" > > Best regards, > Krzysztof Have a relaxing weekend, Sam
diff --git a/Documentation/devicetree/bindings/arm/bcm/brcm,bcmbca.yaml b/Documentation/devicetree/bindings/arm/bcm/brcm,bcmbca.yaml index 07892cbdd23c..4999568225f1 100644 --- a/Documentation/devicetree/bindings/arm/bcm/brcm,bcmbca.yaml +++ b/Documentation/devicetree/bindings/arm/bcm/brcm,bcmbca.yaml @@ -34,6 +34,7 @@ properties: - enum: - netgear,r8000p - tplink,archer-c2300-v1 + - zyxel,ex3510b - const: brcm,bcm4906 - const: brcm,bcm4908 - const: brcm,bcmbca
This is a series (EX3510-B0 and EX3510-B1) of residential gateways based on BCM4906, a stripped-down version of the BCM4908 SoC. Although Zyxel's marketing materials call this a "series," the EX3510-B1 appears to be a very minor revision of the EX3510-B0, with only changes that are transparent to software. As far as Linux is concerned, this "series" effectively represents a single model. Signed-off-by: Sam Edwards <CFSworks@gmail.com> --- Documentation/devicetree/bindings/arm/bcm/brcm,bcmbca.yaml | 1 + 1 file changed, 1 insertion(+)