[BlueZ,1/3] audio/player: Fix media_player_set_metadata item destination

Commit Message

Frédéric Danis Oct. 4, 2024, 2:40 p.m. UTC

Use item provided as parameter, or mp->track if NULL which is used
by MCP.
---
 profiles/audio/player.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

Comments

[e-mail] Oct. 4, 2024, 5:28 p.m. UTC | #1

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=895618

---Test result---

Test Summary:
CheckPatch                    PASS      1.45 seconds
GitLint                       PASS      1.25 seconds
BuildEll                      PASS      24.25 seconds
BluezMake                     PASS      1588.13 seconds
MakeCheck                     PASS      13.20 seconds
MakeDistcheck                 PASS      182.09 seconds
CheckValgrind                 PASS      250.48 seconds
CheckSmatch                   PASS      349.91 seconds
bluezmakeextell               PASS      117.60 seconds
IncrementalBuild              PASS      4269.75 seconds
ScanBuild                     PASS      1023.16 seconds



---
Regards,
Linux Bluetooth

Patch

diff --git a/profiles/audio/player.c b/profiles/audio/player.c
index b3a6920fc..5bb3bc1a9 100644
--- a/profiles/audio/player.c
+++ b/profiles/audio/player.c
@@ -1438,18 +1438,19 @@  void media_player_set_metadata(struct media_player *mp,
 				void *data, size_t len)
 {
 	char *value, *curval;
+	GHashTable *metadata = item ? item->metadata : mp->track;
 
 	value = g_strndup(data, len);
 
 	DBG("%s: %s", key, value);
 
-	curval = g_hash_table_lookup(mp->track, key);
+	curval = g_hash_table_lookup(metadata, key);
 	if (g_strcmp0(curval, value) == 0) {
 		g_free(value);
 		return;
 	}
 
-	g_hash_table_replace(mp->track, g_strdup(key), value);
+	g_hash_table_replace(metadata, g_strdup(key), value);
 }
 
 void media_player_metadata_changed(struct media_player *mp)