| Message ID | 20241003152739.9650-1-zichenxie0106@gmail.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | ASoC: qcom: Fix NULL Dereference in asoc_qcom_lpass_cpu_platform_probe() | expand |
> A devm_kzalloc() in asoc_qcom_lpass_cpu_platform_probe() could call? > possibly return NULL pointer. NULL Pointer Dereference may be > triggerred without addtional check. … * How do you think about to use the term “null pointer dereference” for the final commit message (including the summary phrase)? * Would you like to avoid any typos here? … > --- > sound/soc/qcom/lpass-cpu.c | 2 ++ Did you overlook to add a version description behind the marker line? https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.12-rc1#n723 Regards, Markus
On Sat, Oct 05, 2024 at 05:40:53PM +0200, Markus Elfring wrote: > > A devm_kzalloc() in asoc_qcom_lpass_cpu_platform_probe() could > > call? > > > > possibly return NULL pointer. NULL Pointer Dereference may be > > triggerred without addtional check. > … > > * How do you think about to use the term “null pointer dereference” > for the final commit message (including the summary phrase)? > > * Would you like to avoid any typos here? > > > … > > --- > > sound/soc/qcom/lpass-cpu.c | 2 ++ > > Did you overlook to add a version description behind the marker line? > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.12-rc1#n723 > > Regards, > Markus Hi, This is the semi-friendly patch-bot of Greg Kroah-Hartman. Markus, you seem to have sent a nonsensical or otherwise pointless review comment to a patch submission on a Linux kernel developer mailing list. I strongly suggest that you not do this anymore. Please do not bother developers who are actively working to produce patches and features with comments that, in the end, are a waste of time. Patch submitter, please ignore Markus's suggestion; you do not need to follow it at all. The person/bot/AI that sent it is being ignored by almost all Linux kernel maintainers for having a persistent pattern of behavior of producing distracting and pointless commentary, and inability to adapt to feedback. Please feel free to also ignore emails from them. thanks, greg k-h's patch email bot
>>> A devm_kzalloc() in asoc_qcom_lpass_cpu_platform_probe() could >> >> call? >> >> >>> possibly return NULL pointer. NULL Pointer Dereference may be >>> triggerred without addtional check. >> … >> >> * How do you think about to use the term “null pointer dereference” >> for the final commit message (including the summary phrase)? >> >> * Would you like to avoid any typos here? >> >> >> … >>> --- >>> sound/soc/qcom/lpass-cpu.c | 2 ++ >> >> Did you overlook to add a version description behind the marker line? >> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.12-rc1#n723 … > This is the semi-friendly patch-bot of Greg Kroah-Hartman. > > Markus, you seem to have sent a nonsensical or otherwise pointless > review comment to a patch submission on a Linux kernel developer mailing > list. I strongly suggest that you not do this anymore. Please do not > bother developers who are actively working to produce patches and > features with comments that, in the end, are a waste of time. > > Patch submitter, please ignore Markus's suggestion; you do not need to > follow it at all. The person/bot/AI that sent it is being ignored by > almost all Linux kernel maintainers for having a persistent pattern of > behavior of producing distracting and pointless commentary, and > inability to adapt to feedback. Please feel free to also ignore emails > from them. * Do you care for any spell checking? * Do you find any related advice (from other automated responses) helpful? Regards, Markus
On Sun, Oct 06, 2024 at 10:56:51AM +0200, Markus Elfring wrote: > >>> A devm_kzalloc() in asoc_qcom_lpass_cpu_platform_probe() could > >> > >> call? > >> > >> > >>> possibly return NULL pointer. NULL Pointer Dereference may be > >>> triggerred without addtional check. > >> … > >> > >> * How do you think about to use the term “null pointer dereference” > >> for the final commit message (including the summary phrase)? > >> > >> * Would you like to avoid any typos here? > >> > >> > >> … > >>> --- > >>> sound/soc/qcom/lpass-cpu.c | 2 ++ > >> > >> Did you overlook to add a version description behind the marker line? > >> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.12-rc1#n723 > … > > This is the semi-friendly patch-bot of Greg Kroah-Hartman. > > > > Markus, you seem to have sent a nonsensical or otherwise pointless > > review comment to a patch submission on a Linux kernel developer mailing > > list. I strongly suggest that you not do this anymore. Please do not > > bother developers who are actively working to produce patches and > > features with comments that, in the end, are a waste of time. > > > > Patch submitter, please ignore Markus's suggestion; you do not need to > > follow it at all. The person/bot/AI that sent it is being ignored by > > almost all Linux kernel maintainers for having a persistent pattern of > > behavior of producing distracting and pointless commentary, and > > inability to adapt to feedback. Please feel free to also ignore emails > > from them. > * Do you care for any spell checking? No. > * Do you find any related advice (from other automated responses) helpful? No.
>>>>> A devm_kzalloc() in asoc_qcom_lpass_cpu_platform_probe() could >>>> >>>> call? >>>> >>>> >>>>> possibly return NULL pointer. NULL Pointer Dereference may be >>>>> triggerred without addtional check. >>>> … >>>> >>>> * How do you think about to use the term “null pointer dereference” >>>> for the final commit message (including the summary phrase)? >>>> >>>> * Would you like to avoid any typos here? >>>> >>>> >>>> … >>>>> --- >>>>> sound/soc/qcom/lpass-cpu.c | 2 ++ >>>> >>>> Did you overlook to add a version description behind the marker line? >>>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.12-rc1#n723 >> … >>> This is the semi-friendly patch-bot of Greg Kroah-Hartman. … >> * Do you care for any spell checking? > > No. I find such a feedback surprising. Does it indicate any recurring communication difficulties? >> * Do you find any related advice (from other automated responses) helpful? > > No. I wonder how this answer fits to reminders for the Linux patch review process (which were also automatically sent) according to your inbox filter rules. Regards, Markus
On Thu, Oct 03, 2024 at 10:27:39AM GMT, Gax-c wrote: > From: Zichen Xie <zichenxie0106@gmail.com> > > A devm_kzalloc() in asoc_qcom_lpass_cpu_platform_probe() could > possibly return NULL pointer. NULL Pointer Dereference may be > triggerred without addtional check. > Add a NULL check for the returned pointer. > > Fixes: b5022a36d28f ("ASoC: qcom: lpass: Use regmap_field for i2sctl and dmactl registers") > Signed-off-by: Zichen Xie <zichenxie0106@gmail.com> > Cc: stable@vger.kernel.org I think Fixes / Cc / Signed-off-by is more logical. > --- > sound/soc/qcom/lpass-cpu.c | 2 ++ > 1 file changed, 2 insertions(+) > This is version two of your patch (even though the patch contents didn't change). Please tag your patches accordingly, provide a changelog and don't send next iteration as a reply to the existing thread (it might get lost or mishandled). Please send a proper v3 of your patch.
>>> * Do you find any related advice (from other automated responses) helpful? >> >> No. > > I wonder how this answer fits to reminders for the Linux patch review process > (which were also automatically sent) according to your inbox filter rules. See also: https://lore.kernel.org/all/?q=%22This+looks+like+a+new+version+of+a+previously+submitted+patch%22 Regards, Markus
diff --git a/sound/soc/qcom/lpass-cpu.c b/sound/soc/qcom/lpass-cpu.c index 5a47f661e0c6..242bc16da36d 100644 --- a/sound/soc/qcom/lpass-cpu.c +++ b/sound/soc/qcom/lpass-cpu.c @@ -1242,6 +1242,8 @@ int asoc_qcom_lpass_cpu_platform_probe(struct platform_device *pdev) /* Allocation for i2sctl regmap fields */ drvdata->i2sctl = devm_kzalloc(&pdev->dev, sizeof(struct lpaif_i2sctl), GFP_KERNEL); + if (!drvdata->i2sctl) + return -ENOMEM; /* Initialize bitfields for dai I2SCTL register */ ret = lpass_cpu_init_i2sctl_bitfields(dev, drvdata->i2sctl,