| Message ID | 20241005144146.2345-1-jonathan@marek.ca (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | usb: typec: qcom-pmic-typec: fix sink status being overwritten with RP_DEF | expand |
On 05/10/2024 15:41, Jonathan Marek wrote: > This line is overwriting the result of the above switch-case. > > This fixes the tcpm driver getting stuck in a "Sink TX No Go" loop. > > Fixes: a4422ff22142 ("usb: typec: qcom: Add Qualcomm PMIC Type-C driver") > Signed-off-by: Jonathan Marek <jonathan@marek.ca> > --- > drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_port.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_port.c b/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_port.c > index a747baa297849..c37dede62e12c 100644 > --- a/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_port.c > +++ b/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_port.c > @@ -432,7 +432,6 @@ static int qcom_pmic_typec_port_get_cc(struct tcpc_dev *tcpc, > val = TYPEC_CC_RP_DEF; > break; > } > - val = TYPEC_CC_RP_DEF; > } > > if (misc & CC_ORIENTATION) Acked-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
On Sat, Oct 05, 2024 at 10:41:46AM GMT, Jonathan Marek wrote: > This line is overwriting the result of the above switch-case. > > This fixes the tcpm driver getting stuck in a "Sink TX No Go" loop. > > Fixes: a4422ff22142 ("usb: typec: qcom: Add Qualcomm PMIC Type-C driver") > Signed-off-by: Jonathan Marek <jonathan@marek.ca> > --- > drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_port.c | 1 - > 1 file changed, 1 deletion(-) > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
On Sat, Oct 05, 2024 at 10:41:46AM -0400, Jonathan Marek wrote: > This line is overwriting the result of the above switch-case. > > This fixes the tcpm driver getting stuck in a "Sink TX No Go" loop. > > Fixes: a4422ff22142 ("usb: typec: qcom: Add Qualcomm PMIC Type-C driver") > Signed-off-by: Jonathan Marek <jonathan@marek.ca> Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com> > --- > drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_port.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_port.c b/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_port.c > index a747baa297849..c37dede62e12c 100644 > --- a/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_port.c > +++ b/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_port.c > @@ -432,7 +432,6 @@ static int qcom_pmic_typec_port_get_cc(struct tcpc_dev *tcpc, > val = TYPEC_CC_RP_DEF; > break; > } > - val = TYPEC_CC_RP_DEF; > } > > if (misc & CC_ORIENTATION) > -- > 2.45.1
diff --git a/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_port.c b/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_port.c index a747baa297849..c37dede62e12c 100644 --- a/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_port.c +++ b/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_port.c @@ -432,7 +432,6 @@ static int qcom_pmic_typec_port_get_cc(struct tcpc_dev *tcpc, val = TYPEC_CC_RP_DEF; break; } - val = TYPEC_CC_RP_DEF; } if (misc & CC_ORIENTATION)
This line is overwriting the result of the above switch-case. This fixes the tcpm driver getting stuck in a "Sink TX No Go" loop. Fixes: a4422ff22142 ("usb: typec: qcom: Add Qualcomm PMIC Type-C driver") Signed-off-by: Jonathan Marek <jonathan@marek.ca> --- drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_port.c | 1 - 1 file changed, 1 deletion(-)