[v2,0/7] Add support for Synopsis DWMAC IP on NXP Automotive SoCs S32G2xx/S32G3xx/S32R45

Message

Jan Petrous Aug. 18, 2024, 9:50 p.m. UTC

The SoC series S32G2xx and S32G3xx feature one DWMAC instance,
the SoC S32R45 has two instances. The devices can use RGMII/RMII/MII
interface over Pinctrl device or the output can be routed
to the embedded SerDes for SGMII connectivity.

The provided stmmac glue code implements only basic functionality,
interface support is restricted to RGMII only.

This patchset adds stmmac glue driver based on downstream NXP git [0].

[0] https://github.com/nxp-auto-linux/linux

v2:
- send to wider audience as first version missed many maintainers
- created rgmi_clk() helper as Russell suggested (see patch#4)
- address Andrew's, Russell's, Serge's and Simon's comments

Jan Petrous (OSS) (7):
  net: driver: stmmac: extend CSR calc support
  net: stmmac: Expand clock rate variables
  dt-bindings: net: Add DT bindings for DWMAC on NXP S32G/R SoCs
  net: phy: add helper for mapping RGMII link speed to clock rate
  net: stmmac: dwmac-s32cc: add basic NXP S32G/S32R glue driver
  MAINTAINERS: Add Jan Petrous as the NXP S32G/R DWMAC driver maintainer
  net: stmmac: dwmac-s32cc: Read PTP clock rate when ready

 .../bindings/net/nxp,s32cc-dwmac.yaml         | 127 +++++++++
 .../devicetree/bindings/net/snps,dwmac.yaml   |   1 +
 MAINTAINERS                                   |   7 +
 drivers/net/ethernet/stmicro/stmmac/Kconfig   |  12 +
 drivers/net/ethernet/stmicro/stmmac/Makefile  |   1 +
 drivers/net/ethernet/stmicro/stmmac/common.h  |   2 +
 .../stmicro/stmmac/dwmac-qcom-ethqos.c        |   2 +-
 .../net/ethernet/stmicro/stmmac/dwmac-s32cc.c | 248 ++++++++++++++++++
 .../net/ethernet/stmicro/stmmac/dwmac4_core.c |   2 +-
 .../net/ethernet/stmicro/stmmac/stmmac_main.c |   6 +-
 .../ethernet/stmicro/stmmac/stmmac_platform.c |   2 +-
 include/linux/phy.h                           |  21 ++
 include/linux/stmmac.h                        |  10 +-
 13 files changed, 433 insertions(+), 8 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/net/nxp,s32cc-dwmac.yaml
 create mode 100644 drivers/net/ethernet/stmicro/stmmac/dwmac-s32cc.c

Comments

Krzysztof Kozlowski Aug. 19, 2024, 6:03 a.m. UTC | #1

On 18/08/2024 23:50, Jan Petrous (OSS) wrote:
> The SoC series S32G2xx and S32G3xx feature one DWMAC instance,
> the SoC S32R45 has two instances. The devices can use RGMII/RMII/MII
> interface over Pinctrl device or the output can be routed
> to the embedded SerDes for SGMII connectivity.
> 
> The provided stmmac glue code implements only basic functionality,
> interface support is restricted to RGMII only.
> 
> This patchset adds stmmac glue driver based on downstream NXP git [0].
> 
> [0] https://github.com/nxp-auto-linux/linux

All your threading is completely broken which makes it difficult to
apply and compare patchsets. Just try - use b4 diff on this...

Best regards,
Krzysztof

Jan Petrous Oct. 6, 2024, 6:24 p.m. UTC | #2

On Mon, Aug 19, 2024 at 08:03:30AM +0200, Krzysztof Kozlowski wrote:
> On 18/08/2024 23:50, Jan Petrous (OSS) wrote:
> > The SoC series S32G2xx and S32G3xx feature one DWMAC instance,
> > the SoC S32R45 has two instances. The devices can use RGMII/RMII/MII
> > interface over Pinctrl device or the output can be routed
> > to the embedded SerDes for SGMII connectivity.
> > 
> > The provided stmmac glue code implements only basic functionality,
> > interface support is restricted to RGMII only.
> > 
> > This patchset adds stmmac glue driver based on downstream NXP git [0].
> > 
> > [0] https://github.com/nxp-auto-linux/linux
> 
> All your threading is completely broken which makes it difficult to
> apply and compare patchsets. Just try - use b4 diff on this...
> 

Sorry for that. I had some difficulties with enabling SMTP traffic,
so I used Outlook what I see is totally unusable solution.

Now I have all b4/lei/msmtp/mutt tools installed and will use
it for v3.

BR.
/Jan