| Message ID | 20241006-starqltechn_integration_upstream-v6-1-8336b9cd6c34@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Add Samsung S6E3HA8 panel driver | expand |
On 06/10/2024 20:18, Dzmitry Sankouski wrote: > mipi_dsi_compression_mode_multi can help with > error handling. > > Signed-off-by: Dzmitry Sankouski <dsankouski@gmail.com> > --- > drivers/gpu/drm/drm_mipi_dsi.c | 16 ++++++++++++++++ > include/drm/drm_mipi_dsi.h | 2 ++ > 2 files changed, 18 insertions(+) > > diff --git a/drivers/gpu/drm/drm_mipi_dsi.c b/drivers/gpu/drm/drm_mipi_dsi.c > index 2bc3973d35a1..d8ee74701f1e 100644 > --- a/drivers/gpu/drm/drm_mipi_dsi.c > +++ b/drivers/gpu/drm/drm_mipi_dsi.c > @@ -1520,6 +1520,22 @@ void mipi_dsi_compression_mode_ext_multi(struct mipi_dsi_multi_context *ctx, > } > EXPORT_SYMBOL(mipi_dsi_compression_mode_ext_multi); > > +/** > + * mipi_dsi_compression_mode_multi() - enable/disable DSC on the peripheral > + * @dsi: DSI peripheral device > + * @enable: Whether to enable or disable the DSC > + * > + * Enable or disable Display Stream Compression on the peripheral using the > + * default Picture Parameter Set and VESA DSC 1.1 algorithm. > + */ > +void mipi_dsi_compression_mode_multi(struct mipi_dsi_multi_context *ctx, > + bool enable) > +{ > + return mipi_dsi_compression_mode_ext_multi(ctx, enable, > + MIPI_DSI_COMPRESSION_DSC, 0); > +} > +EXPORT_SYMBOL(mipi_dsi_compression_mode_multi); > + > /** > * mipi_dsi_dcs_nop_multi() - send DCS NOP packet > * @ctx: Context for multiple DSI transactions > diff --git a/include/drm/drm_mipi_dsi.h b/include/drm/drm_mipi_dsi.h > index f725f8654611..94400a78031f 100644 > --- a/include/drm/drm_mipi_dsi.h > +++ b/include/drm/drm_mipi_dsi.h > @@ -280,6 +280,8 @@ void mipi_dsi_compression_mode_ext_multi(struct mipi_dsi_multi_context *ctx, > bool enable, > enum mipi_dsi_compression_algo algo, > unsigned int pps_selector); > +void mipi_dsi_compression_mode_multi(struct mipi_dsi_multi_context *ctx, > + bool enable); > void mipi_dsi_picture_parameter_set_multi(struct mipi_dsi_multi_context *ctx, > const struct drm_dsc_picture_parameter_set *pps); > > Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Hi Dzmitry, kernel test robot noticed the following build warnings: [auto build test WARNING on 58ca61c1a866bfdaa5e19fb19a2416764f847d75] url: https://github.com/intel-lab-lkp/linux/commits/Dzmitry-Sankouski/drm-mipi-dsi-add-mipi_dsi_compression_mode_multi/20241007-022151 base: 58ca61c1a866bfdaa5e19fb19a2416764f847d75 patch link: https://lore.kernel.org/r/20241006-starqltechn_integration_upstream-v6-1-8336b9cd6c34%40gmail.com patch subject: [PATCH v6 1/3] drm/mipi-dsi: add mipi_dsi_compression_mode_multi config: x86_64-rhel-8.3 (https://download.01.org/0day-ci/archive/20241009/202410092245.tfsuUllL-lkp@intel.com/config) compiler: gcc-12 (Debian 12.2.0-14) 12.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241009/202410092245.tfsuUllL-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202410092245.tfsuUllL-lkp@intel.com/ All warnings (new ones prefixed by >>): >> drivers/gpu/drm/drm_mipi_dsi.c:1533: warning: Function parameter or struct member 'ctx' not described in 'mipi_dsi_compression_mode_multi' >> drivers/gpu/drm/drm_mipi_dsi.c:1533: warning: Excess function parameter 'dsi' description in 'mipi_dsi_compression_mode_multi' vim +1533 drivers/gpu/drm/drm_mipi_dsi.c 1522 1523 /** 1524 * mipi_dsi_compression_mode_multi() - enable/disable DSC on the peripheral 1525 * @dsi: DSI peripheral device 1526 * @enable: Whether to enable or disable the DSC 1527 * 1528 * Enable or disable Display Stream Compression on the peripheral using the 1529 * default Picture Parameter Set and VESA DSC 1.1 algorithm. 1530 */ 1531 void mipi_dsi_compression_mode_multi(struct mipi_dsi_multi_context *ctx, 1532 bool enable) > 1533 { 1534 return mipi_dsi_compression_mode_ext_multi(ctx, enable, 1535 MIPI_DSI_COMPRESSION_DSC, 0); 1536 } 1537 EXPORT_SYMBOL(mipi_dsi_compression_mode_multi); 1538
Hi, On 09/10/2024 14:18, kernel test robot wrote: > Hi Dzmitry, > > kernel test robot noticed the following build warnings: > > [auto build test WARNING on 58ca61c1a866bfdaa5e19fb19a2416764f847d75] > > url: https://github.com/intel-lab-lkp/linux/commits/Dzmitry-Sankouski/drm-mipi-dsi-add-mipi_dsi_compression_mode_multi/20241007-022151 > base: 58ca61c1a866bfdaa5e19fb19a2416764f847d75 > patch link: https://lore.kernel.org/r/20241006-starqltechn_integration_upstream-v6-1-8336b9cd6c34%40gmail.com > patch subject: [PATCH v6 1/3] drm/mipi-dsi: add mipi_dsi_compression_mode_multi > config: x86_64-rhel-8.3 (https://download.01.org/0day-ci/archive/20241009/202410092245.tfsuUllL-lkp@intel.com/config) > compiler: gcc-12 (Debian 12.2.0-14) 12.2.0 > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241009/202410092245.tfsuUllL-lkp@intel.com/reproduce) > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot <lkp@intel.com> > | Closes: https://lore.kernel.org/oe-kbuild-all/202410092245.tfsuUllL-lkp@intel.com/ > > All warnings (new ones prefixed by >>): > >>> drivers/gpu/drm/drm_mipi_dsi.c:1533: warning: Function parameter or struct member 'ctx' not described in 'mipi_dsi_compression_mode_multi' >>> drivers/gpu/drm/drm_mipi_dsi.c:1533: warning: Excess function parameter 'dsi' description in 'mipi_dsi_compression_mode_multi' I missed this, Dmitry, can you send a follow-up patch fixing the kerneldoc ? Thanks, Neil > > > vim +1533 drivers/gpu/drm/drm_mipi_dsi.c > > 1522 > 1523 /** > 1524 * mipi_dsi_compression_mode_multi() - enable/disable DSC on the peripheral > 1525 * @dsi: DSI peripheral device > 1526 * @enable: Whether to enable or disable the DSC > 1527 * > 1528 * Enable or disable Display Stream Compression on the peripheral using the > 1529 * default Picture Parameter Set and VESA DSC 1.1 algorithm. > 1530 */ > 1531 void mipi_dsi_compression_mode_multi(struct mipi_dsi_multi_context *ctx, > 1532 bool enable) >> 1533 { > 1534 return mipi_dsi_compression_mode_ext_multi(ctx, enable, > 1535 MIPI_DSI_COMPRESSION_DSC, 0); > 1536 } > 1537 EXPORT_SYMBOL(mipi_dsi_compression_mode_multi); > 1538 >
diff --git a/drivers/gpu/drm/drm_mipi_dsi.c b/drivers/gpu/drm/drm_mipi_dsi.c index 2bc3973d35a1..d8ee74701f1e 100644 --- a/drivers/gpu/drm/drm_mipi_dsi.c +++ b/drivers/gpu/drm/drm_mipi_dsi.c @@ -1520,6 +1520,22 @@ void mipi_dsi_compression_mode_ext_multi(struct mipi_dsi_multi_context *ctx, } EXPORT_SYMBOL(mipi_dsi_compression_mode_ext_multi); +/** + * mipi_dsi_compression_mode_multi() - enable/disable DSC on the peripheral + * @dsi: DSI peripheral device + * @enable: Whether to enable or disable the DSC + * + * Enable or disable Display Stream Compression on the peripheral using the + * default Picture Parameter Set and VESA DSC 1.1 algorithm. + */ +void mipi_dsi_compression_mode_multi(struct mipi_dsi_multi_context *ctx, + bool enable) +{ + return mipi_dsi_compression_mode_ext_multi(ctx, enable, + MIPI_DSI_COMPRESSION_DSC, 0); +} +EXPORT_SYMBOL(mipi_dsi_compression_mode_multi); + /** * mipi_dsi_dcs_nop_multi() - send DCS NOP packet * @ctx: Context for multiple DSI transactions diff --git a/include/drm/drm_mipi_dsi.h b/include/drm/drm_mipi_dsi.h index f725f8654611..94400a78031f 100644 --- a/include/drm/drm_mipi_dsi.h +++ b/include/drm/drm_mipi_dsi.h @@ -280,6 +280,8 @@ void mipi_dsi_compression_mode_ext_multi(struct mipi_dsi_multi_context *ctx, bool enable, enum mipi_dsi_compression_algo algo, unsigned int pps_selector); +void mipi_dsi_compression_mode_multi(struct mipi_dsi_multi_context *ctx, + bool enable); void mipi_dsi_picture_parameter_set_multi(struct mipi_dsi_multi_context *ctx, const struct drm_dsc_picture_parameter_set *pps);
mipi_dsi_compression_mode_multi can help with error handling. Signed-off-by: Dzmitry Sankouski <dsankouski@gmail.com> --- drivers/gpu/drm/drm_mipi_dsi.c | 16 ++++++++++++++++ include/drm/drm_mipi_dsi.h | 2 ++ 2 files changed, 18 insertions(+)