| Message ID | 20241007083921.47525-1-ubizjak@gmail.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | dma-buf: Use atomic64_inc_return() in dma_buf_getfile() | expand |
On Mon, Oct 7, 2024 at 11:21 AM Patchwork Integration <patchwork@media-ci.org> wrote: > > Dear Uros Bizjak: > > The unreliable Media-CI system has found some issues with your series. > Check the report at: https://linux-media.pages.freedesktop.org/-/users/patchwork/-/jobs/64723788/artifacts/report.htm > > Please fix your series, and upload a new version. If you have a patchwork > account, do not forget to mark the current series as Superseded. > > If you believe that the CI is wrong, kindly reply-all to this email. I don't think CI is correct in my case, the failure log says that I should prefix my patch with "media:": WARNING: ./0001-dma-buf-Use-atomic64_inc_return-in-dma_buf_getfile.patch: Missing 'media:' prefix in Subject But the patch is not specific to media, it is specific to dma-buf. Best regards, Uros.
Hi Uros Thanks for the email! We have fixed it in the latest version Regards! On Mon, 7 Oct 2024 at 18:30, Uros Bizjak <ubizjak@gmail.com> wrote: > > On Mon, Oct 7, 2024 at 11:21 AM Patchwork Integration > <patchwork@media-ci.org> wrote: > > > > Dear Uros Bizjak: > > > > The unreliable Media-CI system has found some issues with your series. > > Check the report at: https://linux-media.pages.freedesktop.org/-/users/patchwork/-/jobs/64723788/artifacts/report.htm > > > > Please fix your series, and upload a new version. If you have a patchwork > > account, do not forget to mark the current series as Superseded. > > > > If you believe that the CI is wrong, kindly reply-all to this email. > > I don't think CI is correct in my case, the failure log says that I > should prefix my patch with "media:": > > WARNING: ./0001-dma-buf-Use-atomic64_inc_return-in-dma_buf_getfile.patch: > Missing 'media:' prefix in Subject > > But the patch is not specific to media, it is specific to dma-buf. > > Best regards, > Uros.
diff --git a/drivers/dma-buf/dma-buf.c b/drivers/dma-buf/dma-buf.c index 8892bc701a66..a3649db76add 100644 --- a/drivers/dma-buf/dma-buf.c +++ b/drivers/dma-buf/dma-buf.c @@ -558,7 +558,7 @@ static struct file *dma_buf_getfile(size_t size, int flags) * Override ->i_ino with the unique and dmabuffs specific * value. */ - inode->i_ino = atomic64_add_return(1, &dmabuf_inode); + inode->i_ino = atomic64_inc_return(&dmabuf_inode); flags &= O_ACCMODE | O_NONBLOCK; file = alloc_file_pseudo(inode, dma_buf_mnt, "dmabuf", flags, &dma_buf_fops);
Use atomic64_inc_return(&ref) instead of atomic64_add_return(1, &ref) to use optimized implementation and ease register pressure around the primitive for targets that implement optimized variant. Signed-off-by: Uros Bizjak <ubizjak@gmail.com> Cc: Sumit Semwal <sumit.semwal@linaro.org> Cc: "Christian König" <christian.koenig@amd.com> --- drivers/dma-buf/dma-buf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)