diff mbox series

[RFC,net,1/2] MAINTAINERS: consistently exclude wireless files from NETWORKING [GENERAL]

Message ID 20241004-maint-net-hdrs-v1-1-41fd555aacc5@kernel.org (mailing list archive)
State Not Applicable
Delegated to: Kalle Valo
Headers show
Series MAINTAINERS: Networking file coverage updates | expand

Commit Message

Simon Horman Oct. 4, 2024, 10:03 a.m. UTC
We already exclude wireless drivers from the netdev@ traffic, to
delegate it to linux-wireless@, and avoid overwhelming netdev@.

Many of the following wireless-related sections MAINTAINERS
are already not included in the NETWORKING [GENERAL] section.
For consistency, exclude those that are.

* 802.11 (including CFG80211/NL80211)
* MAC80211
* RFKILL

Signed-off-by: Simon Horman <horms@kernel.org>
---
 MAINTAINERS | 11 +++++++++++
 1 file changed, 11 insertions(+)

Comments

Johannes Berg Oct. 4, 2024, 2:32 p.m. UTC | #1
On Fri, 2024-10-04 at 11:03 +0100, Simon Horman wrote:
> We already exclude wireless drivers from the netdev@ traffic, to
> delegate it to linux-wireless@, and avoid overwhelming netdev@.
> 
> Many of the following wireless-related sections MAINTAINERS
> are already not included in the NETWORKING [GENERAL] section.
> For consistency, exclude those that are.
> 
> * 802.11 (including CFG80211/NL80211)
> * MAC80211
> * RFKILL
> 
> Signed-off-by: Simon Horman <horms@kernel.org>

Makes sense to me!

Acked-by: Johannes Berg <johannes@sipsolutions.net>

johannes
Kalle Valo Oct. 4, 2024, 3:27 p.m. UTC | #2
Simon Horman <horms@kernel.org> writes:

> We already exclude wireless drivers from the netdev@ traffic, to
> delegate it to linux-wireless@, and avoid overwhelming netdev@.
>
> Many of the following wireless-related sections MAINTAINERS
> are already not included in the NETWORKING [GENERAL] section.
> For consistency, exclude those that are.
>
> * 802.11 (including CFG80211/NL80211)
> * MAC80211
> * RFKILL
>
> Signed-off-by: Simon Horman <horms@kernel.org>
> ---
>  MAINTAINERS | 11 +++++++++++
>  1 file changed, 11 insertions(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index c27f3190737f..ea3ea2c0d3fa 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -16197,8 +16197,19 @@ F:	lib/random32.c
>  F:	net/
>  F:	tools/net/
>  F:	tools/testing/selftests/net/
> +X:	Documentation/networking/mac80211-injection.rst
> +X:	Documentation/networking/mac80211_hwsim/
> +X:	Documentation/networking/regulatory.rst
> +X:	include/net/cfg80211.h
> +X:	include/net/ieee80211_radiotap.h
> +X:	include/net/iw_handler.h
> +X:	include/net/mac80211.h
> +X:	include/net/wext.h

Should we add also lib80211.h?
Simon Horman Oct. 7, 2024, 2:13 p.m. UTC | #3
On Fri, Oct 04, 2024 at 06:27:38PM +0300, Kalle Valo wrote:
> Simon Horman <horms@kernel.org> writes:
> 
> > We already exclude wireless drivers from the netdev@ traffic, to
> > delegate it to linux-wireless@, and avoid overwhelming netdev@.
> >
> > Many of the following wireless-related sections MAINTAINERS
> > are already not included in the NETWORKING [GENERAL] section.
> > For consistency, exclude those that are.
> >
> > * 802.11 (including CFG80211/NL80211)
> > * MAC80211
> > * RFKILL
> >
> > Signed-off-by: Simon Horman <horms@kernel.org>
> > ---
> >  MAINTAINERS | 11 +++++++++++
> >  1 file changed, 11 insertions(+)
> >
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index c27f3190737f..ea3ea2c0d3fa 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -16197,8 +16197,19 @@ F:	lib/random32.c
> >  F:	net/
> >  F:	tools/net/
> >  F:	tools/testing/selftests/net/
> > +X:	Documentation/networking/mac80211-injection.rst
> > +X:	Documentation/networking/mac80211_hwsim/
> > +X:	Documentation/networking/regulatory.rst
> > +X:	include/net/cfg80211.h
> > +X:	include/net/ieee80211_radiotap.h
> > +X:	include/net/iw_handler.h
> > +X:	include/net/mac80211.h
> > +X:	include/net/wext.h
> 
> Should we add also lib80211.h?

Thanks, I missed that one. Perhaps it should have:

* An F: entry in the MAC80211
* An X: entry in the NETWORKING [GENERAL]

If so, perhaps I can just add that to a v2 of this patch.
Let me know what you think.
Johannes Berg Oct. 7, 2024, 5:30 p.m. UTC | #4
On Mon, 2024-10-07 at 15:13 +0100, Simon Horman wrote:
> On Fri, Oct 04, 2024 at 06:27:38PM +0300, Kalle Valo wrote:
> > Simon Horman <horms@kernel.org> writes:
> > 
> > > We already exclude wireless drivers from the netdev@ traffic, to
> > > delegate it to linux-wireless@, and avoid overwhelming netdev@.
> > > 
> > > Many of the following wireless-related sections MAINTAINERS
> > > are already not included in the NETWORKING [GENERAL] section.
> > > For consistency, exclude those that are.
> > > 
> > > * 802.11 (including CFG80211/NL80211)
> > > * MAC80211
> > > * RFKILL
> > > 
> > > Signed-off-by: Simon Horman <horms@kernel.org>
> > > ---
> > >  MAINTAINERS | 11 +++++++++++
> > >  1 file changed, 11 insertions(+)
> > > 
> > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > index c27f3190737f..ea3ea2c0d3fa 100644
> > > --- a/MAINTAINERS
> > > +++ b/MAINTAINERS
> > > @@ -16197,8 +16197,19 @@ F:	lib/random32.c
> > >  F:	net/
> > >  F:	tools/net/
> > >  F:	tools/testing/selftests/net/
> > > +X:	Documentation/networking/mac80211-injection.rst
> > > +X:	Documentation/networking/mac80211_hwsim/
> > > +X:	Documentation/networking/regulatory.rst
> > > +X:	include/net/cfg80211.h
> > > +X:	include/net/ieee80211_radiotap.h
> > > +X:	include/net/iw_handler.h
> > > +X:	include/net/mac80211.h
> > > +X:	include/net/wext.h
> > 
> > Should we add also lib80211.h?
> 
> Thanks, I missed that one. Perhaps it should have:
> 
> * An F: entry in the MAC80211

I suppose it should rather be in the 802.11 entry rather than the
MAC80211 one. I don't like the code anyway, but it's there for now :)

johannes
Kalle Valo Oct. 7, 2024, 5:41 p.m. UTC | #5
Simon Horman <horms@kernel.org> writes:

> On Fri, Oct 04, 2024 at 06:27:38PM +0300, Kalle Valo wrote:
>
>> Simon Horman <horms@kernel.org> writes:
>> 
>> > We already exclude wireless drivers from the netdev@ traffic, to
>> > delegate it to linux-wireless@, and avoid overwhelming netdev@.
>> >
>> > Many of the following wireless-related sections MAINTAINERS
>> > are already not included in the NETWORKING [GENERAL] section.
>> > For consistency, exclude those that are.
>> >
>> > * 802.11 (including CFG80211/NL80211)
>> > * MAC80211
>> > * RFKILL
>> >
>> > Signed-off-by: Simon Horman <horms@kernel.org>
>> > ---
>> >  MAINTAINERS | 11 +++++++++++
>> >  1 file changed, 11 insertions(+)
>> >
>> > diff --git a/MAINTAINERS b/MAINTAINERS
>> > index c27f3190737f..ea3ea2c0d3fa 100644
>> > --- a/MAINTAINERS
>> > +++ b/MAINTAINERS
>> > @@ -16197,8 +16197,19 @@ F:	lib/random32.c
>> >  F:	net/
>> >  F:	tools/net/
>> >  F:	tools/testing/selftests/net/
>> > +X:	Documentation/networking/mac80211-injection.rst
>> > +X:	Documentation/networking/mac80211_hwsim/
>> > +X:	Documentation/networking/regulatory.rst
>> > +X:	include/net/cfg80211.h
>> > +X:	include/net/ieee80211_radiotap.h
>> > +X:	include/net/iw_handler.h
>> > +X:	include/net/mac80211.h
>> > +X:	include/net/wext.h
>> 
>> Should we add also lib80211.h?
>
> Thanks, I missed that one. Perhaps it should have:
>
> * An F: entry in the MAC80211
> * An X: entry in the NETWORKING [GENERAL]
>
> If so, perhaps I can just add that to a v2 of this patch.
> Let me know what you think.

Like Johannes said, the cfg80211 entry is more approriate but otherwise
sounds like a good plan, thanks!
Johannes Berg Oct. 7, 2024, 6:03 p.m. UTC | #6
On Mon, 2024-10-07 at 20:41 +0300, Kalle Valo wrote:
> Simon Horman <horms@kernel.org> writes:
> 
> > On Fri, Oct 04, 2024 at 06:27:38PM +0300, Kalle Valo wrote:
> > 
> > > Simon Horman <horms@kernel.org> writes:
> > > 
> > > > We already exclude wireless drivers from the netdev@ traffic, to
> > > > delegate it to linux-wireless@, and avoid overwhelming netdev@.
> > > > 
> > > > Many of the following wireless-related sections MAINTAINERS
> > > > are already not included in the NETWORKING [GENERAL] section.
> > > > For consistency, exclude those that are.
> > > > 
> > > > * 802.11 (including CFG80211/NL80211)
> > > > * MAC80211
> > > > * RFKILL
> > > > 
> > > > Signed-off-by: Simon Horman <horms@kernel.org>
> > > > ---
> > > >  MAINTAINERS | 11 +++++++++++
> > > >  1 file changed, 11 insertions(+)
> > > > 
> > > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > > index c27f3190737f..ea3ea2c0d3fa 100644
> > > > --- a/MAINTAINERS
> > > > +++ b/MAINTAINERS
> > > > @@ -16197,8 +16197,19 @@ F:	lib/random32.c
> > > >  F:	net/
> > > >  F:	tools/net/
> > > >  F:	tools/testing/selftests/net/
> > > > +X:	Documentation/networking/mac80211-injection.rst
> > > > +X:	Documentation/networking/mac80211_hwsim/
> > > > +X:	Documentation/networking/regulatory.rst
> > > > +X:	include/net/cfg80211.h
> > > > +X:	include/net/ieee80211_radiotap.h
> > > > +X:	include/net/iw_handler.h
> > > > +X:	include/net/mac80211.h
> > > > +X:	include/net/wext.h
> > > 
> > > Should we add also lib80211.h?
> > 
> > Thanks, I missed that one. Perhaps it should have:
> > 
> > * An F: entry in the MAC80211
> > * An X: entry in the NETWORKING [GENERAL]
> > 
> > If so, perhaps I can just add that to a v2 of this patch.
> > Let me know what you think.
> 
> Like Johannes said, the cfg80211 entry is more approriate but otherwise
> sounds like a good plan, thanks!

Actually scratch that, please just ignore it. I'm going to remove that
header file entirely and move the functionality into libipw in the
ipw2x00 drivers.

johannes
Simon Horman Oct. 9, 2024, 8:43 a.m. UTC | #7
On Mon, Oct 07, 2024 at 08:03:22PM +0200, Johannes Berg wrote:
> On Mon, 2024-10-07 at 20:41 +0300, Kalle Valo wrote:
> > Simon Horman <horms@kernel.org> writes:
> > 
> > > On Fri, Oct 04, 2024 at 06:27:38PM +0300, Kalle Valo wrote:
> > > 
> > > > Simon Horman <horms@kernel.org> writes:
> > > > 
> > > > > We already exclude wireless drivers from the netdev@ traffic, to
> > > > > delegate it to linux-wireless@, and avoid overwhelming netdev@.
> > > > > 
> > > > > Many of the following wireless-related sections MAINTAINERS
> > > > > are already not included in the NETWORKING [GENERAL] section.
> > > > > For consistency, exclude those that are.
> > > > > 
> > > > > * 802.11 (including CFG80211/NL80211)
> > > > > * MAC80211
> > > > > * RFKILL
> > > > > 
> > > > > Signed-off-by: Simon Horman <horms@kernel.org>
> > > > > ---
> > > > >  MAINTAINERS | 11 +++++++++++
> > > > >  1 file changed, 11 insertions(+)
> > > > > 
> > > > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > > > index c27f3190737f..ea3ea2c0d3fa 100644
> > > > > --- a/MAINTAINERS
> > > > > +++ b/MAINTAINERS
> > > > > @@ -16197,8 +16197,19 @@ F:	lib/random32.c
> > > > >  F:	net/
> > > > >  F:	tools/net/
> > > > >  F:	tools/testing/selftests/net/
> > > > > +X:	Documentation/networking/mac80211-injection.rst
> > > > > +X:	Documentation/networking/mac80211_hwsim/
> > > > > +X:	Documentation/networking/regulatory.rst
> > > > > +X:	include/net/cfg80211.h
> > > > > +X:	include/net/ieee80211_radiotap.h
> > > > > +X:	include/net/iw_handler.h
> > > > > +X:	include/net/mac80211.h
> > > > > +X:	include/net/wext.h
> > > > 
> > > > Should we add also lib80211.h?
> > > 
> > > Thanks, I missed that one. Perhaps it should have:
> > > 
> > > * An F: entry in the MAC80211
> > > * An X: entry in the NETWORKING [GENERAL]
> > > 
> > > If so, perhaps I can just add that to a v2 of this patch.
> > > Let me know what you think.
> > 
> > Like Johannes said, the cfg80211 entry is more approriate but otherwise
> > sounds like a good plan, thanks!
> 
> Actually scratch that, please just ignore it. I'm going to remove that
> header file entirely and move the functionality into libipw in the
> ipw2x00 drivers.

Thanks,

In that case I'll post a v2 without any code changes.
Rather, bumping it to non-RFC and accumulating tags.
diff mbox series

Patch

diff --git a/MAINTAINERS b/MAINTAINERS
index c27f3190737f..ea3ea2c0d3fa 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -16197,8 +16197,19 @@  F:	lib/random32.c
 F:	net/
 F:	tools/net/
 F:	tools/testing/selftests/net/
+X:	Documentation/networking/mac80211-injection.rst
+X:	Documentation/networking/mac80211_hwsim/
+X:	Documentation/networking/regulatory.rst
+X:	include/net/cfg80211.h
+X:	include/net/ieee80211_radiotap.h
+X:	include/net/iw_handler.h
+X:	include/net/mac80211.h
+X:	include/net/wext.h
 X:	net/9p/
 X:	net/bluetooth/
+X:	net/mac80211/
+X:	net/rfkill/
+X:	net/wireless/
 
 NETWORKING [IPSEC]
 M:	Steffen Klassert <steffen.klassert@secunet.com>