| Message ID | 20241001210209.2554-1-zichenxie0106@gmail.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | ASoC: qcom: Fix NULL Dereference in asoc_qcom_lpass_cpu_platform_probe() | expand |
On 01/10/2024 23:02, Gax-c wrote: > A devm_kzalloc() in asoc_qcom_lpass_cpu_platform_probe() could > possibly return NULL pointer. NULL Pointer Dereference may be > triggerred without addtional check. > Add a NULL check for the returned pointer. > > Fixes: b5022a36d28f ("ASoC: qcom: lpass: Use regmap_field for i2sctl and dmactl registers") > Signed-off-by: Zichen Xie <zichenxie0106@gmail.com> > Cc: stable@vger.kernel.org > Reported-by: Zichen Xie <zichenxie0106@gmail.com> Drop, you cannot report own work. To whom do you report it? Was this compiled? Based on the previous work I have doubts. Best regards, Krzysztof
> > Drop, you cannot report own work. To whom do you report it? I'll drop the report tag and re-commit. Thank you for your suggestion! Was this compiled? Based on the previous work I have doubts. Yes, it compiles. Sorry for putting you into such doubts. On Wed, Oct 2, 2024 at 12:47 AM Krzysztof Kozlowski <krzk@kernel.org> wrote: > On 01/10/2024 23:02, Gax-c wrote: > > A devm_kzalloc() in asoc_qcom_lpass_cpu_platform_probe() could > > possibly return NULL pointer. NULL Pointer Dereference may be > > triggerred without addtional check. > > Add a NULL check for the returned pointer. > > > > Fixes: b5022a36d28f ("ASoC: qcom: lpass: Use regmap_field for i2sctl and > dmactl registers") > > Signed-off-by: Zichen Xie <zichenxie0106@gmail.com> > > Cc: stable@vger.kernel.org > > Reported-by: Zichen Xie <zichenxie0106@gmail.com> > > Drop, you cannot report own work. To whom do you report it? > > Was this compiled? Based on the previous work I have doubts. > > Best regards, > Krzysztof > >
diff --git a/sound/soc/qcom/lpass-cpu.c b/sound/soc/qcom/lpass-cpu.c index 5a47f661e0c6..242bc16da36d 100644 --- a/sound/soc/qcom/lpass-cpu.c +++ b/sound/soc/qcom/lpass-cpu.c @@ -1242,6 +1242,8 @@ int asoc_qcom_lpass_cpu_platform_probe(struct platform_device *pdev) /* Allocation for i2sctl regmap fields */ drvdata->i2sctl = devm_kzalloc(&pdev->dev, sizeof(struct lpaif_i2sctl), GFP_KERNEL); + if (!drvdata->i2sctl) + return -ENOMEM; /* Initialize bitfields for dai I2SCTL register */ ret = lpass_cpu_init_i2sctl_bitfields(dev, drvdata->i2sctl,
A devm_kzalloc() in asoc_qcom_lpass_cpu_platform_probe() could possibly return NULL pointer. NULL Pointer Dereference may be triggerred without addtional check. Add a NULL check for the returned pointer. Fixes: b5022a36d28f ("ASoC: qcom: lpass: Use regmap_field for i2sctl and dmactl registers") Signed-off-by: Zichen Xie <zichenxie0106@gmail.com> Cc: stable@vger.kernel.org Reported-by: Zichen Xie <zichenxie0106@gmail.com> --- sound/soc/qcom/lpass-cpu.c | 2 ++ 1 file changed, 2 insertions(+)