| Message ID | 20241001124150.1637835-1-danieller@nvidia.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | ethtool: Add support for writing firmware | expand |
On Tue, Oct 01, 2024 at 03:41:48PM +0300, Danielle Ratson wrote: > In the CMIS specification for pluggable modules, LPL (Local Payload) and > EPL (Extended Payload) are two types of data payloads used for managing > various functions and features of the module. > > EPL payloads are used for more complex and extensive management functions > that require a larger amount of data, so writing firmware blocks using EPL > is much more efficient. > > Currently, only LPL payload is supported for writing firmware blocks to > the module. > > Add support for writing firmware block using EPL payload, both to support > modules that support only EPL write mechanism, and to optimize the flashing > process of modules that support LPL and EPL. > > Running the flashing command on the same sample module using EPL vs. LPL > showed an improvement of 84%. > > Patchset overview: > Patch #1: preparations > Patch #2: Add EPL support > > v4: Resending the right version after wrong v3. Thanks, this one looks good :) > > v2: > * Fix the commit meassges to align the cover letter about the > right meaning of LPL and EPL. > Patch #2: > * Initialize the variable 'bytes_written' before the first > iteration. > > Danielle Ratson (2): > net: ethtool: Add new parameters and a function to support EPL > net: ethtool: Add support for writing firmware blocks using EPL > payload > > net/ethtool/cmis.h | 16 ++++-- > net/ethtool/cmis_cdb.c | 94 +++++++++++++++++++++++++----- > net/ethtool/cmis_fw_update.c | 108 +++++++++++++++++++++++++++++------ > 3 files changed, 184 insertions(+), 34 deletions(-) > > -- > 2.45.0 >
On Tue, 1 Oct 2024 15:41:48 +0300 Danielle Ratson wrote: > Patchset overview: > Patch #1: preparations > Patch #2: Add EPL support Would you mind reposting? I'm worried people who may need to review this didn't pay attention, plus NIPA build testing got wedged on Rust code during the merge window so we got no testing coverage of this set :(
> From: Jakub Kicinski <kuba@kernel.org> > Sent: Tuesday, 8 October 2024 18:12 > To: Danielle Ratson <danieller@nvidia.com> > Cc: netdev@vger.kernel.org; davem@davemloft.net; edumazet@google.com; > pabeni@redhat.com; yuehaibing@huawei.com; horms@kernel.org; linux- > kernel@vger.kernel.org; Petr Machata <petrm@nvidia.com> > Subject: Re: [PATCH net-next v4 0/2] ethtool: Add support for writing > firmware > > On Tue, 1 Oct 2024 15:41:48 +0300 Danielle Ratson wrote: > > Patchset overview: > > Patch #1: preparations > > Patch #2: Add EPL support > > Would you mind reposting? > I'm worried people who may need to review this didn't pay attention, plus > NIPA build testing got wedged on Rust code during the merge window so we > got no testing coverage of this set :( No problem, I will, thanks. Please note that this patch was already reviewed in the last kernel window and wasn’t applied, according to you, as there was no "clear enough signal form the discussion to merge it in time". This will be reposting the same reposted version from the last window. > -- > pw-bot: cr
In the CMIS specification for pluggable modules, LPL (Local Payload) and EPL (Extended Payload) are two types of data payloads used for managing various functions and features of the module. EPL payloads are used for more complex and extensive management functions that require a larger amount of data, so writing firmware blocks using EPL is much more efficient. Currently, only LPL payload is supported for writing firmware blocks to the module. Add support for writing firmware block using EPL payload, both to support modules that support only EPL write mechanism, and to optimize the flashing process of modules that support LPL and EPL. Running the flashing command on the same sample module using EPL vs. LPL showed an improvement of 84%. Patchset overview: Patch #1: preparations Patch #2: Add EPL support v4: Resending the right version after wrong v3. v2: * Fix the commit meassges to align the cover letter about the right meaning of LPL and EPL. Patch #2: * Initialize the variable 'bytes_written' before the first iteration. Danielle Ratson (2): net: ethtool: Add new parameters and a function to support EPL net: ethtool: Add support for writing firmware blocks using EPL payload net/ethtool/cmis.h | 16 ++++-- net/ethtool/cmis_cdb.c | 94 +++++++++++++++++++++++++----- net/ethtool/cmis_fw_update.c | 108 +++++++++++++++++++++++++++++------ 3 files changed, 184 insertions(+), 34 deletions(-)