| Message ID | 20241008203940.2573684-11-heiko@sntech.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Fixing some dtbscheck warnings | expand |
Hello Heiko, On Tue, Oct 08, 2024 at 10:39:36PM GMT, Heiko Stuebner wrote: > The patch adding display support for the pinephone pro introduced two > regulators that contain pinctrl-names props but no pinctrl-assignments. > > Looks like someone forgot the pinctrl settings, so remove the orphans > for now, until that changes. Reviewed-by: Ondrej Jirman <megi@xff.cz> Thank you, o. > Fixes: 3e987e1f22b9 ("arm64: dts: rockchip: Add internal display support to rk3399-pinephone-pro") > Cc: Martijn Braam <martijn@brixit.nl> > Cc: Javier Martinez Canillas <javierm@redhat.com> > Cc: Ondrej Jirman <megi@xff.cz> > Signed-off-by: Heiko Stuebner <heiko@sntech.de> > --- > arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts b/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts > index 1a44582a49fb..09a016ea8c76 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts > +++ b/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts > @@ -166,7 +166,6 @@ vcc1v8_lcd: vcc1v8-lcd { > regulator-max-microvolt = <1800000>; > vin-supply = <&vcc3v3_sys>; > gpio = <&gpio3 RK_PA5 GPIO_ACTIVE_HIGH>; > - pinctrl-names = "default"; > }; > > /* MIPI DSI panel 2.8v supply */ > @@ -178,7 +177,6 @@ vcc2v8_lcd: vcc2v8-lcd { > regulator-max-microvolt = <2800000>; > vin-supply = <&vcc3v3_sys>; > gpio = <&gpio3 RK_PA1 GPIO_ACTIVE_HIGH>; > - pinctrl-names = "default"; > }; > > vibrator { > -- > 2.43.0 >
Heiko Stuebner <heiko@sntech.de> writes: Hello Heiko, > The patch adding display support for the pinephone pro introduced two > regulators that contain pinctrl-names props but no pinctrl-assignments. > > Looks like someone forgot the pinctrl settings, so remove the orphans > for now, until that changes. > > Fixes: 3e987e1f22b9 ("arm64: dts: rockchip: Add internal display support to rk3399-pinephone-pro") > Cc: Martijn Braam <martijn@brixit.nl> > Cc: Javier Martinez Canillas <javierm@redhat.com> > Cc: Ondrej Jirman <megi@xff.cz> > Signed-off-by: Heiko Stuebner <heiko@sntech.de> > --- Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
Hello Heiko, On 2024-10-08 22:39, Heiko Stuebner wrote: > The patch adding display support for the pinephone pro introduced two > regulators that contain pinctrl-names props but no pinctrl-assignments. > > Looks like someone forgot the pinctrl settings, so remove the orphans > for now, until that changes. > > Fixes: 3e987e1f22b9 ("arm64: dts: rockchip: Add internal display > support to rk3399-pinephone-pro") > Cc: Martijn Braam <martijn@brixit.nl> > Cc: Javier Martinez Canillas <javierm@redhat.com> > Cc: Ondrej Jirman <megi@xff.cz> > Signed-off-by: Heiko Stuebner <heiko@sntech.de> Looking good to me, thanks for the patch. The introduced change is obviously correct. Reviewed-by: Dragan Simic <dsimic@manjaro.org> > --- > arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts > b/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts > index 1a44582a49fb..09a016ea8c76 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts > +++ b/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts > @@ -166,7 +166,6 @@ vcc1v8_lcd: vcc1v8-lcd { > regulator-max-microvolt = <1800000>; > vin-supply = <&vcc3v3_sys>; > gpio = <&gpio3 RK_PA5 GPIO_ACTIVE_HIGH>; > - pinctrl-names = "default"; > }; > > /* MIPI DSI panel 2.8v supply */ > @@ -178,7 +177,6 @@ vcc2v8_lcd: vcc2v8-lcd { > regulator-max-microvolt = <2800000>; > vin-supply = <&vcc3v3_sys>; > gpio = <&gpio3 RK_PA1 GPIO_ACTIVE_HIGH>; > - pinctrl-names = "default"; > }; > > vibrator {
diff --git a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts b/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts index 1a44582a49fb..09a016ea8c76 100644 --- a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts +++ b/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts @@ -166,7 +166,6 @@ vcc1v8_lcd: vcc1v8-lcd { regulator-max-microvolt = <1800000>; vin-supply = <&vcc3v3_sys>; gpio = <&gpio3 RK_PA5 GPIO_ACTIVE_HIGH>; - pinctrl-names = "default"; }; /* MIPI DSI panel 2.8v supply */ @@ -178,7 +177,6 @@ vcc2v8_lcd: vcc2v8-lcd { regulator-max-microvolt = <2800000>; vin-supply = <&vcc3v3_sys>; gpio = <&gpio3 RK_PA1 GPIO_ACTIVE_HIGH>; - pinctrl-names = "default"; }; vibrator {
The patch adding display support for the pinephone pro introduced two regulators that contain pinctrl-names props but no pinctrl-assignments. Looks like someone forgot the pinctrl settings, so remove the orphans for now, until that changes. Fixes: 3e987e1f22b9 ("arm64: dts: rockchip: Add internal display support to rk3399-pinephone-pro") Cc: Martijn Braam <martijn@brixit.nl> Cc: Javier Martinez Canillas <javierm@redhat.com> Cc: Ondrej Jirman <megi@xff.cz> Signed-off-by: Heiko Stuebner <heiko@sntech.de> --- arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts | 2 -- 1 file changed, 2 deletions(-)