| Message ID | 20241008203940.2573684-15-heiko@sntech.de (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Fixing some dtbscheck warnings | expand |
Hello Heiko, On 2024-10-08 22:39, Heiko Stuebner wrote: > Both the node name as well as the compatible were not named > according to the binding expectations, fix that. > > Fixes: 47bf3a5c9e2a ("ARM: dts: rockchip: add the sound setup for > rk3036-kylin board") > Cc: Caesar Wang <wxt@rock-chips.com> > Signed-off-by: Heiko Stuebner <heiko@sntech.de> Looking good to me, thanks for the patch. The introduced changes are obviously correct. Reviewed-by: Dragan Simic <dsimic@manjaro.org> > --- > arch/arm/boot/dts/rockchip/rk3036-kylin.dts | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/boot/dts/rockchip/rk3036-kylin.dts > b/arch/arm/boot/dts/rockchip/rk3036-kylin.dts > index e32c73d32f0a..2f84e2805712 100644 > --- a/arch/arm/boot/dts/rockchip/rk3036-kylin.dts > +++ b/arch/arm/boot/dts/rockchip/rk3036-kylin.dts > @@ -325,8 +325,8 @@ regulator-state-mem { > &i2c2 { > status = "okay"; > > - rt5616: rt5616@1b { > - compatible = "rt5616"; > + rt5616: audio-codec@1b { > + compatible = "realtek,rt5616"; > reg = <0x1b>; > clocks = <&cru SCLK_I2S_OUT>; > clock-names = "mclk";
diff --git a/arch/arm/boot/dts/rockchip/rk3036-kylin.dts b/arch/arm/boot/dts/rockchip/rk3036-kylin.dts index e32c73d32f0a..2f84e2805712 100644 --- a/arch/arm/boot/dts/rockchip/rk3036-kylin.dts +++ b/arch/arm/boot/dts/rockchip/rk3036-kylin.dts @@ -325,8 +325,8 @@ regulator-state-mem { &i2c2 { status = "okay"; - rt5616: rt5616@1b { - compatible = "rt5616"; + rt5616: audio-codec@1b { + compatible = "realtek,rt5616"; reg = <0x1b>; clocks = <&cru SCLK_I2S_OUT>; clock-names = "mclk";
Both the node name as well as the compatible were not named according to the binding expectations, fix that. Fixes: 47bf3a5c9e2a ("ARM: dts: rockchip: add the sound setup for rk3036-kylin board") Cc: Caesar Wang <wxt@rock-chips.com> Signed-off-by: Heiko Stuebner <heiko@sntech.de> --- arch/arm/boot/dts/rockchip/rk3036-kylin.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)