diff mbox series

[net-next,01/11] dt-bindings: net: add compatible string for i.MX95 EMDIO

Message ID 20241009095116.147412-2-wei.fang@nxp.com (mailing list archive)
State Superseded
Delegated to: Netdev Maintainers
Headers show
Series add basic support for i.MX95 NETC | expand

Checks

Context Check Description
netdev/series_format success Posting correctly formatted
netdev/tree_selection success Clearly marked for net-next, async
netdev/ynl success Generated files up to date; no warnings/errors; no diff in generated;
netdev/fixes_present success Fixes tag not required for -next series
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 5 this patch: 5
netdev/build_tools success No tools touched, skip
netdev/cc_maintainers success CCed 12 of 12 maintainers
netdev/build_clang success Errors and warnings before: 5 this patch: 5
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/deprecated_api success None detected
netdev/check_selftest success No net selftest shell script
netdev/verify_fixes success No Fixes tag
netdev/build_allmodconfig_warn success Errors and warnings before: 3 this patch: 3
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 21 lines checked
netdev/build_clang_rust success No Rust files in patch. Skipping build
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0

Commit Message

Wei Fang Oct. 9, 2024, 9:51 a.m. UTC 
The EMDIO of i.MX95 has been upgraded to revision 4.1, and the vendor
ID and device ID have also changed, so add the new compatible strings
for i.MX95 EMDIO.

Signed-off-by: Wei Fang <wei.fang@nxp.com>
---
 .../devicetree/bindings/net/fsl,enetc-mdio.yaml   | 15 +++++++++++----
 1 file changed, 11 insertions(+), 4 deletions(-)

Comments

Frank Li Oct. 9, 2024, 4:26 p.m. UTC | #1 
On Wed, Oct 09, 2024 at 05:51:06PM +0800, Wei Fang wrote:
> The EMDIO of i.MX95 has been upgraded to revision 4.1, and the vendor
> ID and device ID have also changed, so add the new compatible strings
> for i.MX95 EMDIO.
>
> Signed-off-by: Wei Fang <wei.fang@nxp.com>
> ---
>  .../devicetree/bindings/net/fsl,enetc-mdio.yaml   | 15 +++++++++++----
>  1 file changed, 11 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/net/fsl,enetc-mdio.yaml b/Documentation/devicetree/bindings/net/fsl,enetc-mdio.yaml
> index c1dd6aa04321..71f1e32b00dc 100644
> --- a/Documentation/devicetree/bindings/net/fsl,enetc-mdio.yaml
> +++ b/Documentation/devicetree/bindings/net/fsl,enetc-mdio.yaml
> @@ -20,10 +20,17 @@ maintainers:
>
>  properties:
>    compatible:
> -    items:
> -      - enum:
> -          - pci1957,ee01
> -      - const: fsl,enetc-mdio
> +    oneOf:
> +      - items:
> +          - enum:
> +              - pci1957,ee01
> +          - const: fsl,enetc-mdio
> +      - items:
> +          - const: pci1131,ee00
> +      - items:
> +          - enum:
> +              - nxp,netc-emdio
> +          - const: pci1131,ee00

why reverse order here. suggested:

oneOf:
  - items:
      - enum:
          - pci1957,ee01
          - pci1131,ee00
      - const: fsl,enetc-mdio
  - items:
      - const: pci1131,ee00

Frank
>
>    reg:
>      maxItems: 1
> --
> 2.34.1
>
Wei Fang Oct. 10, 2024, 1:42 a.m. UTC | #2 
> -----Original Message-----
> From: Frank Li <frank.li@nxp.com>
> Sent: 2024年10月10日 0:27
> To: Wei Fang <wei.fang@nxp.com>
> Cc: davem@davemloft.net; edumazet@google.com; kuba@kernel.org;
> pabeni@redhat.com; robh@kernel.org; krzk+dt@kernel.org;
> conor+dt@kernel.org; Vladimir Oltean <vladimir.oltean@nxp.com>; Claudiu
> Manoil <claudiu.manoil@nxp.com>; Clark Wang <xiaoning.wang@nxp.com>;
> christophe.leroy@csgroup.eu; linux@armlinux.org.uk; bhelgaas@google.com;
> imx@lists.linux.dev; netdev@vger.kernel.org; devicetree@vger.kernel.org;
> linux-kernel@vger.kernel.org; linux-pci@vger.kernel.org
> Subject: Re: [PATCH net-next 01/11] dt-bindings: net: add compatible string for
> i.MX95 EMDIO
> 
> On Wed, Oct 09, 2024 at 05:51:06PM +0800, Wei Fang wrote:
> > The EMDIO of i.MX95 has been upgraded to revision 4.1, and the vendor
> > ID and device ID have also changed, so add the new compatible strings
> > for i.MX95 EMDIO.
> >
> > Signed-off-by: Wei Fang <wei.fang@nxp.com>
> > ---
> >  .../devicetree/bindings/net/fsl,enetc-mdio.yaml   | 15 +++++++++++----
> >  1 file changed, 11 insertions(+), 4 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/net/fsl,enetc-mdio.yaml
> > b/Documentation/devicetree/bindings/net/fsl,enetc-mdio.yaml
> > index c1dd6aa04321..71f1e32b00dc 100644
> > --- a/Documentation/devicetree/bindings/net/fsl,enetc-mdio.yaml
> > +++ b/Documentation/devicetree/bindings/net/fsl,enetc-mdio.yaml
> > @@ -20,10 +20,17 @@ maintainers:
> >
> >  properties:
> >    compatible:
> > -    items:
> > -      - enum:
> > -          - pci1957,ee01
> > -      - const: fsl,enetc-mdio
> > +    oneOf:
> > +      - items:
> > +          - enum:
> > +              - pci1957,ee01
> > +          - const: fsl,enetc-mdio
> > +      - items:
> > +          - const: pci1131,ee00
> > +      - items:
> > +          - enum:
> > +              - nxp,netc-emdio
> > +          - const: pci1131,ee00
> 
> why reverse order here. suggested:

Hi Frank,

The Vendor ID and Device ID of the following NETC IP will not change
for a long time in the future, but it will be used on different platforms.
It is not certain whether special processing is required on different
platforms, so the enum type is added for subsequent expansion.
>

> oneOf:
>   - items:
>       - enum:
>           - pci1957,ee01
>           - pci1131,ee00
>       - const: fsl,enetc-mdio
>   - items:
>       - const: pci1131,ee00
> 
> Frank
> >
> >    reg:
> >      maxItems: 1
> > --
> > 2.34.1
> >
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/net/fsl,enetc-mdio.yaml b/Documentation/devicetree/bindings/net/fsl,enetc-mdio.yaml
index c1dd6aa04321..71f1e32b00dc 100644
--- a/Documentation/devicetree/bindings/net/fsl,enetc-mdio.yaml
+++ b/Documentation/devicetree/bindings/net/fsl,enetc-mdio.yaml
@@ -20,10 +20,17 @@  maintainers:
 
 properties:
   compatible:
-    items:
-      - enum:
-          - pci1957,ee01
-      - const: fsl,enetc-mdio
+    oneOf:
+      - items:
+          - enum:
+              - pci1957,ee01
+          - const: fsl,enetc-mdio
+      - items:
+          - const: pci1131,ee00
+      - items:
+          - enum:
+              - nxp,netc-emdio
+          - const: pci1131,ee00
 
   reg:
     maxItems: 1