| Message ID | 20241009-iio-adc-ad4695-fix-kconfig-v1-1-e2a4dfde8d55@baylibre.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | iio: adc: ad4695: Add missing Kconfig select | expand |
On 09/10/2024 23:23, David Lechner wrote: > Add select IIO_BUFFER and select IIO_TRIGGERED_BUFFER to the Kconfig for > the ad4695 driver. > > Fixes: 6cc7e4bf2e08 ("iio: adc: ad4695: implement triggered buffer") > Signed-off-by: David Lechner <dlechner@baylibre.com> > --- > I didn't see this one in the recent series with similar changes [1][2], > so here is another one. > > [1]: https://lore.kernel.org/linux-iio/20241003-ad2s1210-select-v1-0-4019453f8c33@gmail.com/ > [2]: https://lore.kernel.org/linux-iio/20241003-iio-select-v1-0-67c0385197cd@gmail.com/ > --- > drivers/iio/adc/Kconfig | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig > index 85b82a708c36..98d441d6cc5c 100644 > --- a/drivers/iio/adc/Kconfig > +++ b/drivers/iio/adc/Kconfig > @@ -52,6 +52,8 @@ config AD4695 > tristate "Analog Device AD4695 ADC Driver" > depends on SPI > select REGMAP_SPI > + select IIO_BUFFER > + select IIO_TRIGGERED_BUFFER > help > Say yes here to build support for Analog Devices AD4695 and similar > analog to digital converters (ADC). > > --- > base-commit: 96be67caa0f0420d4128cb67f07bbd7a6f49e03a > change-id: 20241009-iio-adc-ad4695-fix-kconfig-279c9ef8d9ef > > Best regards, I guess the kernel I ran when I found the issues did not have triggered buffers for the ad4695, which was (more ore less) recently added. Good catch! Reviewed-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
On Wed, 2024-10-09 at 16:23 -0500, David Lechner wrote: > Add select IIO_BUFFER and select IIO_TRIGGERED_BUFFER to the Kconfig for > the ad4695 driver. > > Fixes: 6cc7e4bf2e08 ("iio: adc: ad4695: implement triggered buffer") > Signed-off-by: David Lechner <dlechner@baylibre.com> > --- Reviewed-by: Nuno Sa <nuno.sa@analog.com> > I didn't see this one in the recent series with similar changes [1][2], > so here is another one. > > [1]: > https://lore.kernel.org/linux-iio/20241003-ad2s1210-select-v1-0-4019453f8c33@gmail.com/ > [2]: > https://lore.kernel.org/linux-iio/20241003-iio-select-v1-0-67c0385197cd@gmail.com/ > --- > drivers/iio/adc/Kconfig | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig > index 85b82a708c36..98d441d6cc5c 100644 > --- a/drivers/iio/adc/Kconfig > +++ b/drivers/iio/adc/Kconfig > @@ -52,6 +52,8 @@ config AD4695 > tristate "Analog Device AD4695 ADC Driver" > depends on SPI > select REGMAP_SPI > + select IIO_BUFFER > + select IIO_TRIGGERED_BUFFER > help > Say yes here to build support for Analog Devices AD4695 and similar > analog to digital converters (ADC). > > --- > base-commit: 96be67caa0f0420d4128cb67f07bbd7a6f49e03a > change-id: 20241009-iio-adc-ad4695-fix-kconfig-279c9ef8d9ef > > Best regards,
diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig index 85b82a708c36..98d441d6cc5c 100644 --- a/drivers/iio/adc/Kconfig +++ b/drivers/iio/adc/Kconfig @@ -52,6 +52,8 @@ config AD4695 tristate "Analog Device AD4695 ADC Driver" depends on SPI select REGMAP_SPI + select IIO_BUFFER + select IIO_TRIGGERED_BUFFER help Say yes here to build support for Analog Devices AD4695 and similar analog to digital converters (ADC).
Add select IIO_BUFFER and select IIO_TRIGGERED_BUFFER to the Kconfig for the ad4695 driver. Fixes: 6cc7e4bf2e08 ("iio: adc: ad4695: implement triggered buffer") Signed-off-by: David Lechner <dlechner@baylibre.com> --- I didn't see this one in the recent series with similar changes [1][2], so here is another one. [1]: https://lore.kernel.org/linux-iio/20241003-ad2s1210-select-v1-0-4019453f8c33@gmail.com/ [2]: https://lore.kernel.org/linux-iio/20241003-iio-select-v1-0-67c0385197cd@gmail.com/ --- drivers/iio/adc/Kconfig | 2 ++ 1 file changed, 2 insertions(+) --- base-commit: 96be67caa0f0420d4128cb67f07bbd7a6f49e03a change-id: 20241009-iio-adc-ad4695-fix-kconfig-279c9ef8d9ef Best regards,