| Message ID | c662cae0f545a4e4e3921ae13bf69dc02884d9ee.1728308312.git.federico.serafini@bugseng.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | x86: address violations of MISRA C Rule 16.3 | expand |
On Mon, 7 Oct 2024, Federico Serafini wrote: > Refactor the code to avoid an implicit fallthrough and address > a violation of MISRA C:2012 Rule 16.3: "An unconditional `break' > statement shall terminate every switch-clause". > > No functional change. > > Signed-off-by: Federico Serafini <federico.serafini@bugseng.com> Reviewed-by: Stefano Stabellini <sstabellini@kernel.org> > --- > Changes in v2: > - improved description. > --- > xen/drivers/passthrough/pci.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/xen/drivers/passthrough/pci.c b/xen/drivers/passthrough/pci.c > index 5a446d3dce..a5705def3f 100644 > --- a/xen/drivers/passthrough/pci.c > +++ b/xen/drivers/passthrough/pci.c > @@ -170,8 +170,10 @@ static int __init cf_check parse_phantom_dev(const char *str) > { > case 1: case 2: case 4: > if ( *s ) > - default: > return -EINVAL; > + break; > + default: > + return -EINVAL; > } > > phantom_devs[nr_phantom_devs++] = phantom; > -- > 2.43.0 >
On Mon, Oct 07, 2024 at 04:16:19PM +0200, Federico Serafini wrote: > Refactor the code to avoid an implicit fallthrough and address > a violation of MISRA C:2012 Rule 16.3: "An unconditional `break' > statement shall terminate every switch-clause". > > No functional change. > > Signed-off-by: Federico Serafini <federico.serafini@bugseng.com> > --- > Changes in v2: > - improved description. > --- > xen/drivers/passthrough/pci.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/xen/drivers/passthrough/pci.c b/xen/drivers/passthrough/pci.c > index 5a446d3dce..a5705def3f 100644 > --- a/xen/drivers/passthrough/pci.c > +++ b/xen/drivers/passthrough/pci.c > @@ -170,8 +170,10 @@ static int __init cf_check parse_phantom_dev(const char *str) > { > case 1: case 2: case 4: > if ( *s ) > - default: > return -EINVAL; > + break; Would you mind adding a newline here between the break and the default case? With that: Acked-by: Roger Pau Monné <roger.pau@citrix.com> Thanks, Roger.
On 11.10.2024 10:45, Roger Pau Monné wrote: > On Mon, Oct 07, 2024 at 04:16:19PM +0200, Federico Serafini wrote: >> Refactor the code to avoid an implicit fallthrough and address >> a violation of MISRA C:2012 Rule 16.3: "An unconditional `break' >> statement shall terminate every switch-clause". >> >> No functional change. >> >> Signed-off-by: Federico Serafini <federico.serafini@bugseng.com> >> --- >> Changes in v2: >> - improved description. >> --- >> xen/drivers/passthrough/pci.c | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/xen/drivers/passthrough/pci.c b/xen/drivers/passthrough/pci.c >> index 5a446d3dce..a5705def3f 100644 >> --- a/xen/drivers/passthrough/pci.c >> +++ b/xen/drivers/passthrough/pci.c >> @@ -170,8 +170,10 @@ static int __init cf_check parse_phantom_dev(const char *str) >> { >> case 1: case 2: case 4: >> if ( *s ) >> - default: >> return -EINVAL; >> + break; > > Would you mind adding a newline here between the break and the default > case? I actually took the liberty to do so while committing (already a few days ago). Jan
On Fri, Oct 11, 2024 at 10:48:13AM +0200, Jan Beulich wrote: > On 11.10.2024 10:45, Roger Pau Monné wrote: > > On Mon, Oct 07, 2024 at 04:16:19PM +0200, Federico Serafini wrote: > >> Refactor the code to avoid an implicit fallthrough and address > >> a violation of MISRA C:2012 Rule 16.3: "An unconditional `break' > >> statement shall terminate every switch-clause". > >> > >> No functional change. > >> > >> Signed-off-by: Federico Serafini <federico.serafini@bugseng.com> > >> --- > >> Changes in v2: > >> - improved description. > >> --- > >> xen/drivers/passthrough/pci.c | 4 +++- > >> 1 file changed, 3 insertions(+), 1 deletion(-) > >> > >> diff --git a/xen/drivers/passthrough/pci.c b/xen/drivers/passthrough/pci.c > >> index 5a446d3dce..a5705def3f 100644 > >> --- a/xen/drivers/passthrough/pci.c > >> +++ b/xen/drivers/passthrough/pci.c > >> @@ -170,8 +170,10 @@ static int __init cf_check parse_phantom_dev(const char *str) > >> { > >> case 1: case 2: case 4: > >> if ( *s ) > >> - default: > >> return -EINVAL; > >> + break; > > > > Would you mind adding a newline here between the break and the default > > case? > > I actually took the liberty to do so while committing (already a few days > ago). Oh, thanks, should have looked at xen.git before commenting. Roger.
diff --git a/xen/drivers/passthrough/pci.c b/xen/drivers/passthrough/pci.c index 5a446d3dce..a5705def3f 100644 --- a/xen/drivers/passthrough/pci.c +++ b/xen/drivers/passthrough/pci.c @@ -170,8 +170,10 @@ static int __init cf_check parse_phantom_dev(const char *str) { case 1: case 2: case 4: if ( *s ) - default: return -EINVAL; + break; + default: + return -EINVAL; } phantom_devs[nr_phantom_devs++] = phantom;
Refactor the code to avoid an implicit fallthrough and address a violation of MISRA C:2012 Rule 16.3: "An unconditional `break' statement shall terminate every switch-clause". No functional change. Signed-off-by: Federico Serafini <federico.serafini@bugseng.com> --- Changes in v2: - improved description. --- xen/drivers/passthrough/pci.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)