| Message ID | 20241007-dcd-type2-upstream-v4-1-c261ee6eeded@intel.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Delegated to: | Ira Weiny |
| Headers | show |
| Series | DCD: Add support for Dynamic Capacity Devices (DCD) | expand |
On Mon, Oct 07, 2024 at 06:16:07PM -0500, Ira Weiny wrote: > The printk tests for struct resource were stubbed out. struct range > printing will leverage the struct resource implementation. > > To prevent regression add some basic sanity tests for struct resource. Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Good we start having them!
On Mon, 07 Oct 2024 18:16:07 -0500 Ira Weiny <ira.weiny@intel.com> wrote: > The printk tests for struct resource were stubbed out. struct range > printing will leverage the struct resource implementation. > > To prevent regression add some basic sanity tests for struct resource. > > To: Petr Mladek <pmladek@suse.com> > To: Steven Rostedt <rostedt@goodmis.org> > To: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > To: Rasmus Villemoes <linux@rasmusvillemoes.dk> > To: Sergey Senozhatsky <senozhatsky@chromium.org> > Cc: linux-doc@vger.kernel.org > Signed-off-by: Ira Weiny <ira.weiny@intel.com> > Looks sane to me. Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
On Mon, Oct 07, 2024 at 06:16:07PM -0500, Ira Weiny wrote: > The printk tests for struct resource were stubbed out. struct range > printing will leverage the struct resource implementation. > > To prevent regression add some basic sanity tests for struct resource. > > To: Petr Mladek <pmladek@suse.com> > To: Steven Rostedt <rostedt@goodmis.org> > To: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > To: Rasmus Villemoes <linux@rasmusvillemoes.dk> > To: Sergey Senozhatsky <senozhatsky@chromium.org> > Cc: linux-doc@vger.kernel.org > Signed-off-by: Ira Weiny <ira.weiny@intel.com> Reviewed-by: Fan Ni <fan.ni@samsung.com> Tested-by: Fan Ni <fan.ni@samsung.com> > > --- > [lkp: ensure phys_addr_t is within limits for all arch's] > --- > lib/test_printf.c | 44 ++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 44 insertions(+) > > diff --git a/lib/test_printf.c b/lib/test_printf.c > index 8448b6d02bd9..5afdf5efc627 100644 > --- a/lib/test_printf.c > +++ b/lib/test_printf.c > @@ -386,6 +386,50 @@ kernel_ptr(void) > static void __init > struct_resource(void) > { > + struct resource test_resource = { > + .start = 0xc0ffee00, > + .end = 0xc0ffee00, > + .flags = IORESOURCE_MEM, > + }; > + > + test("[mem 0xc0ffee00 flags 0x200]", > + "%pr", &test_resource); > + > + test_resource = (struct resource) { > + .start = 0xc0ffee, > + .end = 0xba5eba11, > + .flags = IORESOURCE_MEM, > + }; > + test("[mem 0x00c0ffee-0xba5eba11 flags 0x200]", > + "%pr", &test_resource); > + > + test_resource = (struct resource) { > + .start = 0xba5eba11, > + .end = 0xc0ffee, > + .flags = IORESOURCE_MEM, > + }; > + test("[mem 0xba5eba11-0x00c0ffee flags 0x200]", > + "%pr", &test_resource); > + > + test_resource = (struct resource) { > + .start = 0xba5eba11, > + .end = 0xba5eca11, > + .flags = IORESOURCE_MEM, > + }; > + > + test("[mem 0xba5eba11-0xba5eca11 flags 0x200]", > + "%pr", &test_resource); > + > + test_resource = (struct resource) { > + .start = 0xba11, > + .end = 0xca10, > + .flags = IORESOURCE_IO | > + IORESOURCE_DISABLED | > + IORESOURCE_UNSET, > + }; > + > + test("[io size 0x1000 disabled]", > + "%pR", &test_resource); > } > > static void __init > > -- > 2.46.0 >
On Mon 2024-10-07 18:16:07, Ira Weiny wrote: > The printk tests for struct resource were stubbed out. struct range > printing will leverage the struct resource implementation. > > To prevent regression add some basic sanity tests for struct resource. > > To: Petr Mladek <pmladek@suse.com> > To: Steven Rostedt <rostedt@goodmis.org> > To: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > To: Rasmus Villemoes <linux@rasmusvillemoes.dk> > To: Sergey Senozhatsky <senozhatsky@chromium.org> > Cc: linux-doc@vger.kernel.org > Signed-off-by: Ira Weiny <ira.weiny@intel.com> Thanks for adding them. They look good: Acked-by: Petr Mladek <pmladek@suse.com> Best Regards, Petr
Petr Mladek wrote: > On Mon 2024-10-07 18:16:07, Ira Weiny wrote: > > The printk tests for struct resource were stubbed out. struct range > > printing will leverage the struct resource implementation. > > > > To prevent regression add some basic sanity tests for struct resource. > > > > To: Petr Mladek <pmladek@suse.com> > > To: Steven Rostedt <rostedt@goodmis.org> > > To: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > To: Rasmus Villemoes <linux@rasmusvillemoes.dk> > > To: Sergey Senozhatsky <senozhatsky@chromium.org> > > Cc: linux-doc@vger.kernel.org > > Signed-off-by: Ira Weiny <ira.weiny@intel.com> > > Thanks for adding them. They look good: > > Acked-by: Petr Mladek <pmladek@suse.com> Thanks I've queued them in cxl-next even if this series is not ready by then. Ira
diff --git a/lib/test_printf.c b/lib/test_printf.c index 8448b6d02bd9..5afdf5efc627 100644 --- a/lib/test_printf.c +++ b/lib/test_printf.c @@ -386,6 +386,50 @@ kernel_ptr(void) static void __init struct_resource(void) { + struct resource test_resource = { + .start = 0xc0ffee00, + .end = 0xc0ffee00, + .flags = IORESOURCE_MEM, + }; + + test("[mem 0xc0ffee00 flags 0x200]", + "%pr", &test_resource); + + test_resource = (struct resource) { + .start = 0xc0ffee, + .end = 0xba5eba11, + .flags = IORESOURCE_MEM, + }; + test("[mem 0x00c0ffee-0xba5eba11 flags 0x200]", + "%pr", &test_resource); + + test_resource = (struct resource) { + .start = 0xba5eba11, + .end = 0xc0ffee, + .flags = IORESOURCE_MEM, + }; + test("[mem 0xba5eba11-0x00c0ffee flags 0x200]", + "%pr", &test_resource); + + test_resource = (struct resource) { + .start = 0xba5eba11, + .end = 0xba5eca11, + .flags = IORESOURCE_MEM, + }; + + test("[mem 0xba5eba11-0xba5eca11 flags 0x200]", + "%pr", &test_resource); + + test_resource = (struct resource) { + .start = 0xba11, + .end = 0xca10, + .flags = IORESOURCE_IO | + IORESOURCE_DISABLED | + IORESOURCE_UNSET, + }; + + test("[io size 0x1000 disabled]", + "%pR", &test_resource); } static void __init
The printk tests for struct resource were stubbed out. struct range printing will leverage the struct resource implementation. To prevent regression add some basic sanity tests for struct resource. To: Petr Mladek <pmladek@suse.com> To: Steven Rostedt <rostedt@goodmis.org> To: Andy Shevchenko <andriy.shevchenko@linux.intel.com> To: Rasmus Villemoes <linux@rasmusvillemoes.dk> To: Sergey Senozhatsky <senozhatsky@chromium.org> Cc: linux-doc@vger.kernel.org Signed-off-by: Ira Weiny <ira.weiny@intel.com> --- [lkp: ensure phys_addr_t is within limits for all arch's] --- lib/test_printf.c | 44 ++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 44 insertions(+)