diff mbox series

watchdog: armada_37xx_wdt: remove struct resource

Message ID 20241003214508.121107-1-rosenp@gmail.com (mailing list archive)
State New
Headers show
Series watchdog: armada_37xx_wdt: remove struct resource | expand

Commit Message

Rosen Penev Oct. 3, 2024, 9:45 p.m. UTC 
No need for it with devm_platform_ioremap_resource. Simplifies probe
slightly.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
 drivers/watchdog/armada_37xx_wdt.c | 10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)

Comments

Marek Behún Oct. 4, 2024, 7:34 a.m. UTC | #1 
Reviewed-by: Marek Behún <kabel@kernel.org>
Guenter Roeck Oct. 12, 2024, 3:49 p.m. UTC | #2 
On 10/3/24 14:45, Rosen Penev wrote:
> No need for it with devm_platform_ioremap_resource. Simplifies probe
> slightly.
> 
> Signed-off-by: Rosen Penev <rosenp@gmail.com>

Reviewed-by: Guenter Roeck <linux@roeck-us.net>
diff mbox series

Patch

diff --git a/drivers/watchdog/armada_37xx_wdt.c b/drivers/watchdog/armada_37xx_wdt.c
index 8133a5d05647..a17a7911771a 100644
--- a/drivers/watchdog/armada_37xx_wdt.c
+++ b/drivers/watchdog/armada_37xx_wdt.c
@@ -248,7 +248,6 @@  static const struct watchdog_ops armada_37xx_wdt_ops = {
 static int armada_37xx_wdt_probe(struct platform_device *pdev)
 {
 	struct armada_37xx_watchdog *dev;
-	struct resource *res;
 	struct regmap *regmap;
 	int ret;
 
@@ -266,12 +265,9 @@  static int armada_37xx_wdt_probe(struct platform_device *pdev)
 		return PTR_ERR(regmap);
 	dev->cpu_misc = regmap;
 
-	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	if (!res)
-		return -ENODEV;
-	dev->reg = devm_ioremap(&pdev->dev, res->start, resource_size(res));
-	if (!dev->reg)
-		return -ENOMEM;
+	dev->reg = devm_platform_ioremap_resource(pdev, 0);
+	if (IS_ERR(dev->reg))
+		return PTR_ERR(dev->reg);
 
 	/* init clock */
 	dev->clk = devm_clk_get_enabled(&pdev->dev, NULL);